Refs #272 Branch mode: `new`; base: `main`; head: `feature/272` Implementation model: `gpt-6.1-sol` / reasoning: `medium` ## Automated implementation (requires human review) タグ補完で前方一致を優先し、20件に満たない場合に後方一致を重複なく末尾へ追加しました。正式名・別名・外部タグが対象です。 `git diff --check` は通過しました。指定に従い、テスト・lint・ビルドは未実行です。 ## Verification - Tests/builds/migrations were not authorized and were not invoked by the controller. - Codex was instructed not to run them; inspect its command transcript. - The repository owner alone reviews changes. No AI review is executed. - Do not merge before human acceptance and required checks. --------- Co-authored-by: Codex Night Worker <codex-night@localhost> Co-authored-by: miteruzo <miteruzo@naver.com> Co-authored-by: みてるぞ <miteruzo@naver.com> Reviewed-on: #458 Co-authored-by: テツノニジカ <969+codex-bot@noreply.localhost>
このコミットはプルリクエスト #458 でマージされました。
このコミットが含まれているのは:
@@ -492,9 +492,9 @@ RSpec.describe 'Tags API', type: :request do
|
||||
end
|
||||
|
||||
{
|
||||
'wild*end' => [0, 1, 2],
|
||||
'wild?end' => [1],
|
||||
'not:wild?end' => [1],
|
||||
'wild*end' => [0, 1, 2, 3],
|
||||
'wild?end' => [1, 3],
|
||||
'not:wild?end' => [1, 3],
|
||||
'nico:wild?end' => [1] }.each do |query, indices|
|
||||
it "matches primary, alias, and external names with #{ query.inspect }" do
|
||||
get '/tags/autocomplete', params: { q: query }
|
||||
@@ -557,6 +557,7 @@ RSpec.describe 'Tags API', type: :request do
|
||||
create(:tag, category: :general, primary_name: name, post_count: 1)
|
||||
create(:external_tag, name:, post_count: 1)
|
||||
end
|
||||
create(:external_tag, name: 'suffix_combined', post_count: 100)
|
||||
|
||||
get '/tags/autocomplete', params: { q: 'combined' }
|
||||
|
||||
@@ -565,6 +566,40 @@ RSpec.describe 'Tags API', type: :request do
|
||||
expect(json.map { |row| row.fetch('name') }).to eq(expected.first(20))
|
||||
end
|
||||
|
||||
it 'appends primary, alias, and external partial matches without duplicate resources' do
|
||||
prefix = create(:tag, primary_name: 'tail', post_count: 1)
|
||||
create(:tag_name, :alias, name: 'tail_alias', tag: prefix)
|
||||
create(:tag_name, :alias, name: 'alias_tail', tag: prefix)
|
||||
create(:tag, primary_name: 'primary_tail', post_count: 4)
|
||||
alias_target = create(:tag, primary_name: 'alias_target', post_count: 3)
|
||||
create(:tag_name, :alias, name: 'middle_tail_alias', tag: alias_target)
|
||||
external = create(:external_tag, id: prefix.id, name: 'external_tail', post_count: 5)
|
||||
create(:tag, primary_name: 'middle_tail_only', post_count: 100)
|
||||
create(:external_tag, name: 'middle_tail_only', post_count: 100)
|
||||
|
||||
get '/tags/autocomplete', params: { q: 'tail' }
|
||||
|
||||
expect(response).to have_http_status(:ok)
|
||||
expect(json.map { |row| row.fetch('name') }).to eq(
|
||||
['tail', 'middle_tail_only', 'nico:middle_tail_only',
|
||||
'nico:external_tail', 'primary_tail', 'alias_target'])
|
||||
expect(json.first.fetch('matched_alias')).to eq('tail_alias')
|
||||
expect(json.last.fetch('matched_alias')).to eq('middle_tail_alias')
|
||||
expect(json[3]).to include('id' => external.id, 'category' => 'nico')
|
||||
end
|
||||
|
||||
it 'fills only the remaining places with partial matches' do
|
||||
names = 19.times.map { |number| "capacity_#{ number.to_s.rjust(2, '0') }" }
|
||||
names.each { create(:tag, primary_name: _1, post_count: 1) }
|
||||
create(:tag, primary_name: 'first_capacity_match', post_count: 3)
|
||||
create(:external_tag, name: 'second_capacity_match', post_count: 2)
|
||||
|
||||
get '/tags/autocomplete', params: { q: 'capacity' }
|
||||
|
||||
expect(response).to have_http_status(:ok)
|
||||
expect(json.map { |row| row.fetch('name') }).to eq(names + ['first_capacity_match'])
|
||||
end
|
||||
|
||||
it 'excludes external tags but preserves internal alias matches when nico is false' do
|
||||
internal = create(:tag, category: :general, primary_name: 'switch_internal', post_count: 1)
|
||||
alias_target = create(:tag, category: :general, primary_name: 'alias_target', post_count: 1)
|
||||
@@ -593,12 +628,20 @@ RSpec.describe 'Tags API', type: :request do
|
||||
create(:external_tag, name: literal, post_count: 1)
|
||||
create(:tag, category: :general, primary_name: 'literalXmatch', post_count: 2)
|
||||
create(:external_tag, name: 'literalXmatch', post_count: 2)
|
||||
suffix = "suffix_literal#{ wildcard }"
|
||||
create(:tag, primary_name: suffix, post_count: 1)
|
||||
suffix_alias = create(:tag, primary_name: 'suffix_alias_target', post_count: 1)
|
||||
create(:tag_name, :alias, name: "alias_#{ suffix }", tag: suffix_alias)
|
||||
create(:external_tag, name: suffix, post_count: 1)
|
||||
create(:tag, primary_name: 'suffix_literalX', post_count: 2)
|
||||
create(:external_tag, name: 'suffix_literalX', post_count: 2)
|
||||
|
||||
get '/tags/autocomplete', params: { q: "literal#{ wildcard }" }
|
||||
|
||||
expect(json.map { |row| row.fetch('name') })
|
||||
.to contain_exactly(
|
||||
literal, primary_tag_name_for(alias_target, 'ja').name, "nico:#{ literal }")
|
||||
literal, primary_tag_name_for(alias_target, 'ja').name, "nico:#{ literal }",
|
||||
suffix, 'suffix_alias_target', "nico:#{ suffix }")
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
新しいイシューから参照
ユーザーをブロックする