AI: #450 最新系から履歴系を参照することのないやぅに変更 (#462)

Refs #450

Branch mode: `new`; base: `main`; head: `feature/450`

Implementation model: `gpt-6.1-sol` / reasoning: `high`

## Automated implementation (requires human review)
実装しました。

- `/posts` の履歴集計を廃止し、更新日時の表示・絞り込み・並び順を `posts.updated_at` に統一しました。
- 現在テーブルに対する履歴判定と、不要になった共通メソッドを削除しました。
- `_versions` を読む処理の認可は維持しています。

`git diff --check` は通過しました。指定に従い、テスト・lint・ビルド・マイグレーションは未実行です。

## Verification
- Tests/builds/migrations were not authorized and were not invoked by the controller.
- Codex was instructed not to run them; inspect its command transcript.
- The repository owner alone reviews changes. No AI review is executed.
- Do not merge before human acceptance and required checks.

---------

Co-authored-by: Codex Night Worker <codex-night@localhost>
Co-authored-by: みてるぞ <miteruzo@naver.com>
Reviewed-on: #462
Co-authored-by: テツノニジカ <969+codex-bot@noreply.localhost>
このコミットはプルリクエスト #462 でマージされました。
このコミットが含まれているのは:
2026-11-23 03:49:46 +09:00
committed by みてるぞ
co-authored by Codex Night Worker みてるぞ
コミット 33af84d7fe
11個のファイルの変更、86行の追加、67行の削除
+22 -4
ファイルの表示
@@ -14,22 +14,40 @@ RSpec.describe 'History boundaries shared with Counts', type: :request do
end
end
it 'denies the same discarded description through Counts, the facade and the ordinary API' do
it 'keeps discarded history private while exposing the current description' do
get '/counts/query', params: { resource: 'tag_descriptions', definition: 'history',
mode: 'details', locale: 'ja', execution_at: '2025-01-01T00:00:00Z' }
expect(response).to have_http_status(:ok)
expect(response.parsed_body).to include('count' => 0, 'output_count' => 2,
'excluded_count' => 2, 'versions' => [])
["/wiki/#{ description.id }", "/tags/#{ tag.id }/description"].each do |path|
paths = [
"/wiki/#{ description.id }", '/wiki/title/description%20tag',
"/tags/#{ tag.id }/description"]
paths.each do |path|
get path, params: { locale: 'ja' }
expect(response).to have_http_status(:not_found)
expect(response.body).not_to include('private body')
expect(response).to have_http_status(:ok)
expect(response.parsed_body.fetch('body')).to eq(description.body)
end
get '/sitemap_entries/descriptions', params: { locale: 'ja' }
expect(response).to have_http_status(:ok)
expect(response.parsed_body['ids']).not_to include(description.id)
end
it 'omits private revision references and rejects history and diff requests' do
get "/wiki/#{ description.id }", params: { locale: 'ja' }
expect(response).to have_http_status(:ok)
expect(response.parsed_body).to include(
'revision_id' => nil, 'pred' => nil, 'succ' => nil,
'updated_at' => description.updated_at.iso8601(3))
version = TagDescriptionVersion.find_by!(
tag_id: tag.id, language_code: 'ja', version_no: 2)
get "/wiki/#{ description.id }", params: { locale: 'ja', version: version.id }
expect(response).to have_http_status(:not_found)
get "/wiki/#{ description.id }/diff", params: { locale: 'ja' }
expect(response).to have_http_status(:not_found)
end
it 'permits the server-authenticated administrator to read the discarded description' do
sign_in_as(create(:user, :admin))
get "/tags/#{ tag.id }/description", params: { locale: 'ja' }
+8 -10
ファイルの表示
@@ -69,40 +69,38 @@ RSpec.describe 'Post history privacy', type: :request do
sign_in_as(create(:user, role.to_sym)) unless role == 'anonymous'
end
it 'uses only authorised history timestamps for display' do
it 'uses the latest version timestamp for display regardless of role' do
get '/posts'
expect(response).to have_http_status(:ok)
row = response.parsed_body.fetch('posts').find { _1.fetch('id') == post_record.id }
expected = origin + (role == 'admin' ? 4 : 3).days
expected = origin + 4.days
expect(Time.zone.parse(row.fetch('updated_at'))).to eq(expected)
end
it 'uses the same visibility for date bounds and count' do
it 'uses the latest version timestamp for date bounds and count regardless of role' do
get '/posts', params: { updated_from: (origin + 4.days).iso8601,
updated_to: (origin + 4.days).iso8601 }
expect(response).to have_http_status(:ok)
ids = response.parsed_body.fetch('posts').pluck('id')
expect(ids).to eq(role == 'admin' ? [post_record.id] : [])
expect(ids).to eq([post_record.id])
expect(response.parsed_body.fetch('count')).to eq(ids.length)
end
it 'sorts using authorised timestamps in both directions' do
it 'sorts using the latest version timestamps in both directions regardless of role' do
['asc', 'desc'].each do |direction|
get '/posts', params: { order: "updated_at:#{ direction }" }
expect(response).to have_http_status(:ok)
expected = role == 'admin' ? [other_post.id, post_record.id] :
[post_record.id, other_post.id]
expected = [other_post.id, post_record.id]
expected.reverse! if direction == 'desc'
expect(response.parsed_body.fetch('posts').pluck('id')).to eq(expected)
end
end
it 'applies authorised timestamp ordering before pagination' do
it 'applies latest version timestamp ordering before pagination regardless of role' do
get '/posts', params: { order: 'updated_at:desc', limit: 1 }
expect(response).to have_http_status(:ok)
expected = role == 'admin' ? post_record.id : other_post.id
expect(response.parsed_body.fetch('posts').pluck('id')).to eq([expected])
expect(response.parsed_body.fetch('posts').pluck('id')).to eq([post_record.id])
expect(response.parsed_body.fetch('count')).to eq(2)
end
+4 -2
ファイルの表示
@@ -62,10 +62,12 @@ RSpec.describe 'Tag description Wiki compatibility', type: :request do
expect(response).to have_http_status(:not_found)
end
it 'does not fall back when the new current revision is missing' do
it 'reads current content when the corresponding revision is missing' do
TagDescriptionVersion.where(id: versions.last.id).delete_all
without_legacy_reads { get "/wiki/#{ description.id }" }
expect(response).to have_http_status(:not_found)
expect(response).to have_http_status(:ok)
expect(json).to include('body' => description.body,
'revision_id' => nil, 'pred' => nil, 'succ' => nil)
end
end
+24
ファイルの表示
@@ -42,6 +42,30 @@ RSpec.describe 'Tag group Wiki facade reads', type: :request do
'updated_at' => first_revision.created_at.iso8601(3))
end
it 'reads current structure while keeping discarded history private' do
TagGroupVersion.where(id: last_revision.id).update_all(event_type: 'discard')
without_group_legacy_reads { get path }
expect(response).to have_http_status(:ok)
expect(json).to include(
'body' => '- 新タグ', 'revision_id' => nil, 'pred' => nil, 'succ' => nil,
'updated_at' => page.updated_at.iso8601(3))
get path, params: { version: last_revision.id }
expect(response).to have_http_status(:not_found)
get "/wiki/#{ page.id }/diff"
expect(response).to have_http_status(:not_found)
end
it 'reads current structure when the corresponding revision is missing' do
TagGroupVersion.where(id: last_revision.id).delete_all
without_group_legacy_reads { get path }
expect(response).to have_http_status(:ok)
expect(json).to include(
'body' => '- 新タグ', 'revision_id' => nil, 'pred' => nil, 'succ' => nil)
end
it 'checks existence without consulting migrated Wiki tables' do
without_group_legacy_reads { get "#{ path }/exists" }
expect(response).to have_http_status(:no_content)