AI: address review on PR #490

このコミットが含まれているのは:
Codex Night Worker
2026-11-22 12:03:27 +09:00
コミット 91787d4187
2個のファイルの変更、3行の追加、39行の削除
+3 -7
ファイルの表示
@@ -81,14 +81,10 @@ class HistoryAccess < ActiveSupport::CurrentAttributes
table = model.table_name
source = "JSON_TABLE(COALESCE(#{ row }.tags_json, JSON_ARRAY()), '$[*]' COLUMNS (" +
"tag_id BIGINT PATH '$.#{ key }', version_no INT PATH '$.version_no')) tag_reference"
# DISTINCT prevents derived-table merging: evaluate privacy independently of each post row.
private_versions = "SELECT DISTINCT reference_version.tag_id, reference_version.version_no, " +
"reference_version.created_at FROM #{ table } reference_version " +
"WHERE NOT (#{ sql(model, 'reference_version') })"
match = 'reference_version.tag_id = tag_reference.tag_id'
if external
match += " AND reference_version.created_at <= #{ row }.created_at"
latest = "WHERE NOT EXISTS (SELECT 1 FROM #{ table } later_reference " +
latest = "AND NOT EXISTS (SELECT 1 FROM #{ table } later_reference " +
'WHERE later_reference.tag_id = reference_version.tag_id ' +
"AND later_reference.created_at <= #{ row }.created_at " +
'AND later_reference.version_no > reference_version.version_no)'
@@ -96,8 +92,8 @@ class HistoryAccess < ActiveSupport::CurrentAttributes
match += ' AND reference_version.version_no = tag_reference.version_no'
latest = ''
end
"(SELECT 1 FROM #{ source } JOIN (#{ private_versions }) reference_version ON #{ match } " +
"#{ latest } LIMIT 1) IS NULL"
"(SELECT 1 FROM #{ source } JOIN #{ table } reference_version ON #{ match } " +
"WHERE NOT (#{ sql(model, 'reference_version') }) #{ latest } LIMIT 1) IS NULL"
end
def self.reference_sql(table, row)