#399

backend/app/services/post_import_row_normaliser.rb

@@ -78,8 +78,12 @@ class PostImportRowNormaliser
   private_class_method :normalise_source_row!
 
   def self.normalise_url! value
-    raise ArgumentError, 'URL の形式が不正です．' unless value.is_a?(String)
-    raise ArgumentError, 'URL が長すぎます．' if value.bytesize > PostImportUrlListParser::MAX_URL_BYTES
+    unless value.is_a?(String)
+      raise ArgumentError, 'URL の形式が不正です．'
+    end
+    if value.bytesize > PostImportUrlListParser::MAX_URL_BYTES
+      raise ArgumentError, 'URL が長すぎます．'
+    end
   end
   private_class_method :normalise_url!
 
@@ -112,20 +116,32 @@ class PostImportRowNormaliser
   private_class_method :normalise_attributes!
 
   def self.normalise_provenance! provenance
-    raise ArgumentError, 'provenance の形式が不正です．' unless provenance.is_a?(Hash)
+    unless provenance.is_a?(Hash)
+      raise ArgumentError, 'provenance の形式が不正です．'
+    end
 
     allowed = ATTRIBUTE_FIELDS + ['url']
-    raise ArgumentError, '値の由来が不正です．' unless (provenance.keys - allowed).empty?
-    raise ArgumentError, '値の由来が不正です．' unless provenance.values.all? { ORIGINS.include?(_1) }
+    unless (provenance.keys - allowed).empty?
+      raise ArgumentError, '値の由来が不正です．'
+    end
+    unless provenance.values.all? { ORIGINS.include?(_1) }
+      raise ArgumentError, '値の由来が不正です．'
+    end
   end
   private_class_method :normalise_provenance!
 
   def self.normalise_tag_sources! tag_sources
     return if tag_sources.nil?
 
-    raise ArgumentError, 'タグ由来の形式が不正です．' unless tag_sources.is_a?(Hash)
-    raise ArgumentError, 'タグ由来の形式が不正です．' unless (tag_sources.keys - ORIGINS).empty?
-    raise ArgumentError, 'タグ由来の形式が不正です．' unless tag_sources.values.all? { _1.is_a?(String) }
+    unless tag_sources.is_a?(Hash)
+      raise ArgumentError, 'タグ由来の形式が不正です．'
+    end
+    unless (tag_sources.keys - ORIGINS).empty?
+      raise ArgumentError, 'タグ由来の形式が不正です．'
+    end
+    unless tag_sources.values.all? { _1.is_a?(String) }
+      raise ArgumentError, 'タグ由来の形式が不正です．'
+    end
     if tag_sources.values.any? { _1.bytesize > PostImportUrlListParser::MAX_URL_BYTES }
       raise ArgumentError, 'タグ由来が大きすぎます．'
     end
@@ -143,7 +159,9 @@ class PostImportRowNormaliser
       raise ArgumentError, '警告の形式が不正です．'
     end
     field_warnings&.each do |key, values|
-      raise ArgumentError, '警告の形式が不正です．' unless ATTRIBUTE_FIELDS.include?(key) || key == 'url'
+      unless ATTRIBUTE_FIELDS.include?(key) || key == 'url'
+        raise ArgumentError, '警告の形式が不正です．'
+      end
       unless values.is_a?(Array) && values.all? { _1.is_a?(String) }
         raise ArgumentError, '警告の形式が不正です．'
       end