#419

backend/app/controllers/post_versions_controller.rb

@@ -43,50 +43,19 @@ class PostVersionsController < ApplicationController
   private
 
   def serialise_versions rows
+    rows = rows.to_a
     user_ids = rows.map(&:created_by_user_id).compact.uniq
     users_by_id = User.where(id: user_ids).pluck(:id, :name).to_h
+    snapshots = rows.flat_map { |row|
+      [normalise_json(row.tags_json),
+       normalise_json(row.attributes['prev_tags_json']) || []]
+    }
+    external_tag_names = external_tag_names_for(snapshots)
 
     rows.map do |row|
-      cur_tags =
-          normalise_json(row.tags_json)
-          .sort_by { [(case _1.fetch('category')
-                       when 'deerjikist'
-                         0
-                       when 'meme'
-                         1
-                       when 'character'
-                         2
-                       when 'general'
-                         3
-                       when 'material'
-                         4
-                       when 'meta'
-                         5
-                       else
-                         6
-                       end),
-                      _1.fetch('name').downcase] }
-          .map { Post.tag_snapshot_literal(_1) }
-      prev_tags =
-          (normalise_json(row.attributes['prev_tags_json']) || [])
-          .sort_by { [(case _1.fetch('category')
-                       when 'deerjikist'
-                         0
-                       when 'meme'
-                         1
-                       when 'character'
-                         2
-                       when 'general'
-                         3
-                       when 'material'
-                         4
-                       when 'meta'
-                         5
-                       else
-                         6
-                       end),
-                      _1.fetch('name').downcase] }
-          .map { Post.tag_snapshot_literal(_1) }
+      cur_tags = snapshot_tag_literals(normalise_json(row.tags_json), external_tag_names)
+      prev_tags = snapshot_tag_literals(
+          normalise_json(row.attributes['prev_tags_json']) || [], external_tag_names)
 
       { post_id: row.post_id,
         version_no: row.version_no,
@@ -113,6 +82,40 @@ class PostVersionsController < ApplicationController
     end
   end
 
+  def external_tag_names_for snapshots
+    ids = snapshots.flatten.filter_map { _1['external_tag_id'] }.uniq
+    names = ExternalTag.where(id: ids).pluck(:id, :platform, :name).to_h { |id, platform, name|
+      [id, "#{ platform }:#{ name }"]
+    }
+    missing_ids = ids - names.keys
+
+    NicoTagVersion
+        .where(tag_id: missing_ids)
+        .order(:tag_id, version_no: :desc)
+        .pluck(:tag_id, :name)
+        .each { |id, name| names[id] ||= name }
+
+    names
+  end
+
+  def snapshot_tag_literals snapshots, external_tag_names
+    snapshots
+        .filter_map { |snapshot|
+          if snapshot.key?('tag_id')
+            [tag_category_order(snapshot['category']),
+             Post.tag_snapshot_literal(snapshot)]
+          elsif external_tag_names[snapshot['external_tag_id']]
+            [6, external_tag_names[snapshot['external_tag_id']]]
+          end
+        }
+        .sort_by { |order, name| [order, name.downcase] }
+        .map(&:second)
+  end
+
+  def tag_category_order category
+    ['deerjikist', 'meme', 'character', 'general', 'material', 'meta'].index(category) || 6
+  end
+
   def build_version_tags cur_tags, prev_tags
     (cur_tags | prev_tags).map do |name|
       type =