#424

backend/app/services/wiki/commit.rb

@@ -8,12 +8,13 @@ module Wiki
     end
 
     def self.create_content! tag_name:, body:, created_by_user:, message: nil
-      if tag_name.tag && tag_name.language_code == 'ja'
+      if tag_name.tag && tag_name.language_code == 'ja' && !tag_name.name.include?(':')
         return TagDescriptionOperation.create!(
             tag: tag_name.tag, body:, created_by_user:, message:)
       end
 
-      create_legacy_content!(tag_name:, body:, created_by_user:, message:)
+      tag_name.errors.add(:base, :invalid)
+      raise ActiveRecord::RecordInvalid, tag_name
     end
 
     def self.create_legacy_content! tag_name:, body:, created_by_user:, message: nil
@@ -42,14 +43,17 @@ module Wiki
     end
 
     def self.content! page:, body:, created_user:, message: nil, base_revision_id: nil
-      description = TagDescription.find_by(id: page.id)
-      if description
+      description = TagDescription.find_by(tag_id: page.tag_name.tag_id, language_code: 'ja')
+      description ||= TagDescription.joins(:tag).find_by(
+          tags: { tag_name_id: page.tag_name_id }, language_code: 'ja')
+      if description && !page.title.include?(':')
         return TagDescriptionOperation.update!(
             tag: description.tag, body:, updated_by_user: created_user,
             message:, base_revision_id:)
       end
 
-      legacy_content!(page:, body:, created_user:, message:, base_revision_id:)
+      page.errors.add(:base, :invalid)
+      raise ActiveRecord::RecordInvalid, page
     end
 
     def self.legacy_content! page:, body:, created_user:, message: nil,

backend/app/services/wiki/compatibility_writer.rb

@@ -1,8 +1,16 @@
 module Wiki
   class CompatibilityWriter
     def self.create! tag_name:, body:, created_by_user:, message: nil
-      Commit.create_legacy_content!(
-          tag_name:, body:, created_by_user:, message:)
+      ApplicationRecord.transaction do
+        tag_name.lock!
+        page = WikiPage.lock.find_by(tag_name_id: tag_name.id)
+        if page
+          update!(page:, body:, updated_by_user: created_by_user, message:)
+          page
+        else
+          Commit.create_legacy_content!(tag_name:, body:, created_by_user:, message:)
+        end
+      end
     end
 
     def self.update! page:, body:, updated_by_user:, message: nil,
@@ -23,7 +31,9 @@ module Wiki
         end
       end
 
-      return if Commit.normalise_body(page.body) == normalised
+      if Commit.normalise_body(page.body) == normalised && page.wiki_revisions.exists?
+        return
+      end
 
       Commit.legacy_content!(
           page:, body: normalised, created_user: updated_by_user, message:,