#424

backend/spec/services/shared_resource_id_allocator_spec.rb

@@ -0,0 +1,65 @@
+require 'rails_helper'
+
+RSpec.describe SharedResourceIdAllocator do
+  let(:record) { build(:external_tag) }
+  let(:connection) { double('connection') }
+  let(:transaction) { double('transaction', open?: true) }
+  let(:callbacks) { { } }
+  let(:sql) { [] }
+
+  before do
+    config = double('config', database: 'test_shared_ids')
+    allow(connection).to receive_message_chain(:pool, :db_config).and_return(config)
+    allow(connection).to receive(:quote) { "'#{ _1 }'" }
+    allow(connection).to receive(:quote_table_name) { "`#{ _1 }`" }
+    allow(connection).to receive(:select_value) do |statement|
+      sql << statement
+      if statement.include?('GET_LOCK') || statement.include?('RELEASE_LOCK')
+        1
+      elsif statement.include?('`tags`')
+        8
+      else
+        3
+      end
+    end
+    allow(ExternalTag).to receive(:connection).and_return(connection)
+    allow(ExternalTag).to receive(:current_transaction).and_return(transaction)
+    allow(ExternalTag).to receive(:uncached).and_yield
+    [:after_commit, :after_rollback].each do |event|
+      allow(transaction).to receive(event) { |&callback| callbacks[event] = callback }
+    end
+  end
+
+  [:after_commit, :after_rollback].each do |event|
+    it "holds the shared lock until #{ event }" do
+      described_class.assign!(record)
+      expect(record.id).to eq(9)
+      expect(sql.grep(/RELEASE_LOCK/)).to be_empty
+      expect(sql.grep(/FOR UPDATE/).size).to eq(2)
+      callbacks.fetch(event).call
+      expect(sql.grep(/RELEASE_LOCK/).size).to eq(1)
+    end
+  end
+
+  it 'does not silently proceed after an acquisition timeout' do
+    allow(connection).to receive(:select_value).and_return(0)
+    expect { described_class.assign!(record) }.to raise_error(ActiveRecord::LockWaitTimeout)
+    expect(record.id).to be_nil
+    expect(callbacks).to be_empty
+  end
+
+  it 'releases a successfully acquired lock when allocation fails and rolls back' do
+    allow(connection).to receive(:select_value).with(/FOR UPDATE/).and_raise('query failed')
+    expect { described_class.assign!(record) }.to raise_error(RuntimeError, 'query failed')
+    callbacks.fetch(:after_rollback).call
+    expect(sql.grep(/RELEASE_LOCK/).size).to eq(1)
+  end
+
+  it 'preserves explicitly supplied historical IDs' do
+    record.id = 5
+    described_class.assign!(record)
+    expect(record.id).to eq(5)
+    expect(sql.grep(/FOR UPDATE/)).to be_empty
+    callbacks.fetch(:after_commit).call
+  end
+end

backend/spec/services/wiki/commit_integrity_spec.rb

@@ -7,29 +7,37 @@ RSpec.describe Wiki::Commit do
 
   def create_page title:, body: 'initial body'
     seed_wiki_page(
-        tag_name: create(:tag_name, name: title),
+        tag_name: create(:tag, primary_name: title).tag_name('ja'),
         body:,
         created_by_user: user,
         message: 'init')
   end
 
   describe '.create_content!' do
-    [:create_content!, :create_legacy_content!].each do |operation|
-      it "freezes #{ operation } without adding page or history" do
-        name = create(:tag_name, name: 'Help:frozen_service')
-        counts = [WikiPage.count, WikiRevision.count, WikiVersion.count]
-        begin
-          described_class.public_send(operation, tag_name: name, body: 'initial',
-                                      created_by_user: user)
-        rescue ActiveRecord::RecordInvalid
-          # A validation rejection is allowed; persistence is not.
-        end
-        expect([WikiPage.count, WikiRevision.count, WikiVersion.count]).to eq(counts)
-      end
+    it 'rejects standalone Help creation without adding page or history' do
+      name = create(:tag_name, name: 'Help:frozen_service')
+      counts = [WikiPage.count, WikiRevision.count, WikiVersion.count]
+      expect do
+        described_class.create_content!(tag_name: name, body: 'initial', created_by_user: user)
+      end.to raise_error(ActiveRecord::RecordInvalid)
+      expect([WikiPage.count, WikiRevision.count, WikiVersion.count]).to eq(counts)
+    end
+
+    it 'keeps the internal compatibility writer available' do
+      name = create(:tag_name, name: 'タググループ:compatibility_service')
+      page = nil
+      expect do
+        page = described_class.create_legacy_content!(
+            tag_name: name, body: 'initial', created_by_user: user)
+      end.to change(WikiPage, :count).by(1)
+          .and change(WikiRevision, :count).by(1)
+          .and change(WikiVersion, :count).by(1)
+      expect(page.current_revision.body).to eq('initial')
+      expect(page.wiki_versions.sole.body).to eq('initial')
     end
 
     it 'rejects body that becomes blank after normalisation' do
-      tag_name = create(:tag_name, name: 'commit_integrity_blank')
+      tag_name = create(:tag, primary_name: 'commit_integrity_blank').tag_name('ja')
 
       expect {
         described_class.create_content!(
@@ -45,6 +53,17 @@ RSpec.describe Wiki::Commit do
   end
 
   describe '.content!' do
+    it 'rejects standalone Help updates without modifying histories' do
+      page = seed_wiki_page(tag_name: create(:tag_name, name: 'Help:standalone'),
+                            body: 'before', created_by_user: user)
+      counts = [WikiRevision.count, WikiVersion.count]
+      expect do
+        described_class.content!(page:, body: 'after', created_user: user)
+      end.to raise_error(ActiveRecord::RecordInvalid)
+      expect(page.reload.body).to eq('before')
+      expect([WikiRevision.count, WikiVersion.count]).to eq(counts)
+    end
+
     it 'updates page body, revision, and version' do
       page = create_page(title: 'commit_integrity_update', body: 'before')
       current_id = page.current_revision.id

backend/spec/services/wiki/commit_spec.rb

@@ -5,7 +5,7 @@ RSpec.describe Wiki::Commit do
   let(:user) { create_member_user! }
 
   def create_page(title: 'commit_spec_page', body: 'initial body')
-    tag_name = create(:tag_name, name: title)
+    tag_name = create(:tag, primary_name: title).tag_name('ja')
 
     seed_wiki_page(
         tag_name:,