#419

backend/app/services/post_create_plan.rb

@@ -20,23 +20,22 @@ class PostCreatePlan
     parent_post_ids = normalise_parent_post_ids
     validate_parent_post_ids!(parent_post_ids)
 
-    {
-        url: @attributes[:url],
-        title: @attributes[:title].to_s,
-        thumbnail_base: @attributes[:thumbnail_base].presence,
-        original_created_from: @attributes[:original_created_from].presence,
-        original_created_before: @attributes[:original_created_before].presence,
-        tags: serialised_tags(direct_tag_specs, tag_sections),
-        display_tags: display_tags(direct_tag_specs, tag_sections),
-        duration: @attributes[:duration].to_s,
-        video_ms: video_ms,
-        parent_post_ids: parent_post_ids.join(' '),
-        direct_tag_specs: direct_tag_specs,
-        default_tag_specs: default_tag_specs,
-        snapshot_tag_specs: snapshot_tag_specs,
-        post_tag_specs: post_tag_specs,
-        tag_sections: tag_sections,
-        normalised_parent_post_ids: parent_post_ids }
+    { url: @attributes[:url],
+      title: @attributes[:title].to_s,
+      thumbnail_base: @attributes[:thumbnail_base].presence,
+      original_created_from: @attributes[:original_created_from].presence,
+      original_created_before: @attributes[:original_created_before].presence,
+      tags: serialised_tags(direct_tag_specs, tag_sections),
+      display_tags: display_tags(direct_tag_specs, tag_sections),
+      duration: @attributes[:duration].to_s,
+      video_ms: video_ms,
+      parent_post_ids: parent_post_ids.join(' '),
+      direct_tag_specs: direct_tag_specs,
+      default_tag_specs: default_tag_specs,
+      snapshot_tag_specs: snapshot_tag_specs,
+      post_tag_specs: post_tag_specs,
+      tag_sections: tag_sections,
+      normalised_parent_post_ids: parent_post_ids }
   end
 
   private
@@ -50,7 +49,6 @@ class PostCreatePlan
     tag_names.each do |raw_name|
       tag_name, category, sections = parse_raw_tag_name(raw_name)
       existing_tag = existing_tags_by_name[tag_name]
-      raise Tag::NicoTagNormalisationError if existing_tag&.nico?
       raise Tag::DeprecatedTagNormalisationError, [existing_tag.name] if existing_tag&.deprecated?
 
       direct_tag_specs << {
@@ -139,14 +137,14 @@ class PostCreatePlan
         Tag.expand_parent_tags(existing_snapshot_tags)
            .reject(&:deprecated?)
            .map { |tag|
-             {
-                 name: tag.name,
-                 category: tag.category.to_sym } }
+             { name: tag.name,
+               category: tag.category.to_sym }
+        }
     merge_tag_specs(snapshot_tag_specs + expanded_parent_specs)
   end
 
   def merge_tag_specs specs
-    specs.each_with_object({ }) do |spec, merged|
+    specs.each_with_object({ }) { |spec, merged|
       merged[spec[:name]] =
           if merged.key?(spec[:name]) && merged[spec[:name]][:category] != :general
             merged[spec[:name]]
@@ -155,7 +153,7 @@ class PostCreatePlan
                 name: spec[:name],
                 category: spec[:category] }
           end
-    end.values.sort_by { _1[:name] }
+    }.values.sort_by { _1[:name] }
   end
 
   def existing_tags_by_name