#399

backend/app/services/post_creator.rb

@@ -10,16 +10,17 @@ class PostCreator
   end
 
   def create!
+    thumbnail_attachment = prepare_thumbnail_attachment
     post = Post.new(title: @attributes[:title].presence,
                     url: @attributes[:url],
                     thumbnail_base: @attributes[:thumbnail_base].presence,
                     uploaded_user: @actor,
                     original_created_from: @attributes[:original_created_from].presence,
                     original_created_before: @attributes[:original_created_before].presence)
-    attach_thumbnail!(post)
 
     ApplicationRecord.transaction do
       post.save!
+      post.thumbnail.attach(thumbnail_attachment) if thumbnail_attachment.present?
       Tag.normalise_tags!(tag_names, deny_deprecated: true, with_sections: true) =>
           { tags:, sections: }
       TagVersioning.record_tag_snapshots!(tags, created_by_user: @actor)
@@ -36,19 +37,10 @@ class PostCreator
 
   private
 
-  def attach_thumbnail! post
-    thumbnail = @attributes[:thumbnail]
-    if thumbnail.present?
-      post.thumbnail.attach(Post.resized_thumbnail_attachment(thumbnail))
-      return
-    end
-
-    thumbnail_base = post.thumbnail_base
-    return if thumbnail_base.blank?
-
-    post.attach_thumbnail_from_url!(thumbnail_base)
-  rescue Post::RemoteThumbnailFetchFailed => e
-    @field_warnings[:thumbnail_base] = [e.message]
+  def prepare_thumbnail_attachment
+    PostThumbnailAttachmentBuilder.build(
+        thumbnail: @attributes[:thumbnail],
+        thumbnail_base: @attributes[:thumbnail_base].presence)
   end
 
   def tag_names = @attributes[:tags].to_s.split