#55

backend/spec/requests/materials_spec.rb

@@ -26,10 +26,10 @@ RSpec.describe 'Materials API', type: :request do
 
   describe 'GET /materials' do
     let!(:tag_a) do
-      Tag.create!(tag_name: TagName.create!(name: 'material_index_a'), category: :material)
+      create(:tag, name: 'material_index_a', category: :material)
     end
     let!(:tag_b) do
-      Tag.create!(tag_name: TagName.create!(name: 'material_index_b'), category: :material)
+      create(:tag, name: 'material_index_b', category: :material)
     end
 
     let!(:material_a) do
@@ -116,20 +116,20 @@ RSpec.describe 'Materials API', type: :request do
 
     it 'filters by descendant tags and returns stable parent tag groups' do
       root =
-          Tag.create!(tag_name: TagName.create!(name: 'material_scope_root'),
+          create(:tag, name: 'material_scope_root',
                       category: :material)
       child_b =
-          Tag.create!(tag_name: TagName.create!(name: 'material_scope_b'),
+          create(:tag, name: 'material_scope_b',
                       category: :material)
       child_a =
-          Tag.create!(tag_name: TagName.create!(name: 'material_scope_a'),
+          create(:tag, name: 'material_scope_a',
                       category: :material)
       deprecated =
-          Tag.create!(tag_name: TagName.create!(name: 'material_scope_old'),
+          create(:tag, name: 'material_scope_old',
                       category: :material,
                       deprecated_at: Time.current)
       grandchild =
-          Tag.create!(tag_name: TagName.create!(name: 'material_scope_grandchild'),
+          create(:tag, name: 'material_scope_grandchild',
                       category: :material)
       root_material =
           build_material(tag: root, user: member_user,
@@ -179,7 +179,7 @@ RSpec.describe 'Materials API', type: :request do
 
   describe 'GET /materials/:id' do
     let!(:tag) do
-      Tag.create!(tag_name: TagName.create!(name: 'material_show'), category: :material)
+      create(:tag, name: 'material_show', category: :material)
     end
     let!(:material) do
       build_material(tag:, user: member_user, file: dummy_upload(filename: 'show.png'))
@@ -323,8 +323,8 @@ RSpec.describe 'Materials API', type: :request do
       end
 
       it 'returns 422 when the existing tag is not material/character' do
-        general_tag_name = TagName.create!(name: 'material_create_general_tag')
-        Tag.create!(tag_name: general_tag_name, category: :general)
+        general_tag_name = create(:tag_name, name: 'material_create_general_tag')
+        create(:tag, tag_name: general_tag_name, category: :general)
 
         post '/materials', params: {
           tag: 'material_create_general_tag',
@@ -384,7 +384,7 @@ RSpec.describe 'Materials API', type: :request do
 
   describe 'PUT /materials/:id' do
     let!(:tag) do
-      Tag.create!(tag_name: TagName.create!(name: 'material_update_old'), category: :material)
+      create(:tag, name: 'material_update_old', category: :material)
     end
     let!(:material) do
       build_material(tag:, user: member_user, file: dummy_upload(filename: 'old.png'))
@@ -508,7 +508,7 @@ RSpec.describe 'Materials API', type: :request do
 
       it 'backfills a create tag_version for an existing material tag without history' do
         existing_tag =
-            Tag.create!(tag_name: TagName.create!(name: 'material_update_existing_no_history'),
+            create(:tag, name: 'material_update_existing_no_history',
                         category: :material)
 
         expect(existing_tag.tag_versions).to be_empty
@@ -531,7 +531,7 @@ RSpec.describe 'Materials API', type: :request do
 
       it 'backfills a create tag_version for an existing character tag without history' do
         existing_tag =
-            Tag.create!(tag_name: TagName.create!(name: 'material_update_character_no_history'),
+            create(:tag, name: 'material_update_character_no_history',
                         category: :character)
 
         expect(existing_tag.tag_versions).to be_empty
@@ -651,8 +651,8 @@ RSpec.describe 'Materials API', type: :request do
   end
 
   describe 'GET /materials/download.zip' do
-    let!(:tag_a) { Tag.create!(tag_name: TagName.create!(name: 'zip_a'), category: :material) }
-    let!(:tag_b) { Tag.create!(tag_name: TagName.create!(name: 'zip_b'), category: :material) }
+    let!(:tag_a) { create(:tag, name: 'zip_a', category: :material) }
+    let!(:tag_b) { create(:tag, name: 'zip_b', category: :material) }
     let!(:material_a) do
       build_material(tag: tag_a, user: member_user,
                      file: dummy_upload(filename: 'a.png', body: 'zip-a'))
@@ -701,7 +701,7 @@ RSpec.describe 'Materials API', type: :request do
 
   describe 'GET /materials/versions' do
     let!(:tag) do
-      Tag.create!(tag_name: TagName.create!(name: 'material_history'), category: :material)
+      create(:tag, name: 'material_history', category: :material)
     end
     let!(:material) do
       build_material(tag:, user: member_user, file: dummy_upload(filename: 'history.png'))
@@ -776,7 +776,7 @@ RSpec.describe 'Materials API', type: :request do
 
   describe 'DELETE /materials/:id' do
     let!(:tag) do
-      Tag.create!(tag_name: TagName.create!(name: 'material_destroy'), category: :material)
+      create(:tag, name: 'material_destroy', category: :material)
     end
     let!(:material) do
       build_material(tag:, user: member_user, file: dummy_upload(filename: 'destroy.png'))