#399

backend/app/models/post.rb

@@ -138,8 +138,10 @@ class Post < ApplicationRecord
   end
 
   def self.section_literal section
-    "[#{ Post.ms_to_time(section.begin_ms) }-"\
-    "#{ section.end_ms ? Post.ms_to_time(section.end_ms) : '' }]"
+    end_ms =
+        section.end_ms ? Post.ms_to_time(section.end_ms) : ''
+
+    "[#{ Post.ms_to_time(section.begin_ms) }-#{ end_ms }]"
   end
 
   def self.ms_to_time ms

backend/app/representations/post_repr.rb

@@ -106,11 +106,14 @@ module PostRepr
 
     Rails.application.routes.url_helpers.rails_storage_proxy_url(post.thumbnail, **options)
   rescue ActionController::UrlGenerationError, ArgumentError, URI::InvalidURIError => e
-    Rails.logger.warn(
-        "PostRepr.thumbnail_url failed post_id=#{post.id} " \
-        "attachment_id=#{post.thumbnail.attachment&.id} " \
-        "blob_id=#{post.thumbnail.blob&.id} " \
-        "error_class=#{e.class} message=#{e.message}")
+    payload = {
+        post_id: post.id,
+        attachment_id: post.thumbnail.attachment&.id,
+        blob_id: post.thumbnail.blob&.id,
+        error_class: e.class,
+        message: e.message }
+
+    Rails.logger.warn("PostRepr.thumbnail_url failed #{ payload.to_json }")
     nil
   end
 end

backend/app/services/post_import_previewer.rb

@@ -225,15 +225,15 @@ class PostImportPreviewer
     end
     { data:, warnings:, validation_errors: { } }
   rescue Preview::UrlSafety::UnsafeUrl => e
+    payload = { error: e.class.name, message: e.message }
     Rails.logger.info(
-        "post_import_metadata_fetch_unsafe_url "\
-        "#{ { error: e.class.name, message: e.message }.to_json }")
+        "post_import_metadata_fetch_unsafe_url #{ payload.to_json }")
     { data: { }, warnings: { }, validation_errors: { url: [e.message] } }
   rescue Preview::HttpFetcher::FetchFailed,
          Preview::HttpFetcher::ResponseTooLarge => e
+    payload = { error: e.class.name, message: e.message }
     Rails.logger.info(
-        "post_import_metadata_fetch_failure "\
-        "#{ { error: e.class.name, message: e.message }.to_json }")
+        "post_import_metadata_fetch_failure #{ payload.to_json }")
     { data: { }, warnings: { 'url' => [METADATA_FETCH_WARNING] }, validation_errors: { } }
   end
 
@@ -335,14 +335,14 @@ class PostImportPreviewer
   def safe_fetch_metadata url
     fetch_metadata(url)
   rescue Preview::UrlSafety::UnsafeUrl => e
+    payload = { error: e.class.name, message: e.message }
     Rails.logger.info(
-        "post_import_metadata_fetch_unsafe_url "\
-        "#{ { error: e.class.name, message: e.message }.to_json }")
+        "post_import_metadata_fetch_unsafe_url #{ payload.to_json }")
     { data: { }, warnings: { }, validation_errors: { url: [e.message] } }
   rescue StandardError => e
+    payload = { error: e.class.name, message: e.message }
     Rails.logger.error(
-        "post_import_metadata_fetch_unexpected_failure "\
-        "#{ { error: e.class.name, message: e.message }.to_json }")
+        "post_import_metadata_fetch_unexpected_failure #{ payload.to_json }")
     { data: { }, warnings: { 'url' => [METADATA_FETCH_WARNING] }, validation_errors: { } }
   end
 

backend/app/services/post_metadata_fetcher.rb

@@ -3,10 +3,9 @@ require 'date'
 
 class PostMetadataFetcher
   TIMESTAMP_PATTERN =
-      Regexp.new(
-          '\A(\d{4})-(\d{2})-(\d{2})T(\d{2})' \
-          '(?::(\d{2})(?::(\d{2})(?:\.(\d+))?)?)?' \
-          '(Z|[+-]\d{2}:?\d{2})?\z')
+      /\A(\d{4})-(\d{2})-(\d{2})T(\d{2})
+        (?::(\d{2})(?::(\d{2})(?:\.(\d+))?)?)?
+        (Z|[+-]\d{2}:?\d{2})?\z/x
 
   def self.fetch raw_url
     uri, = Preview::UrlSafety.validate(raw_url)