#428

backend/spec/models/locale_spec.rb

@@ -57,6 +57,7 @@ RSpec.describe Locale, type: :model do
     tag = create(:tag, primary_name: 'already_named')
     existing = create(:tag_name, name: 'existing_ainu', tag:,
                                  language_code: 'ain', script_code: 'Kana')
+    versions_before = tag.tag_versions.order(:version_no).map(&:attributes)
 
     create_ainu_locale!
 
@@ -65,6 +66,7 @@ RSpec.describe Locale, type: :model do
     expect(existing.reload).to have_attributes(
         tag_id: tag.id, language_code: 'ain', script_code: 'Kana',
         primary_flg: true, auto_generated: false)
+    expect(tag.tag_versions.order(:version_no).map(&:attributes)).to eq(versions_before)
   end
 
   it 'adds the new language primary while preserving existing names and aliases' do
@@ -88,6 +90,7 @@ RSpec.describe Locale, type: :model do
     prepare_ainu_reference!
     first = create(:tag, primary_name: 'atomic_first')
     second = create(:tag, primary_name: 'atomic_second')
+    versions_before = TagVersion.order(:id).map(&:attributes)
     allow(TagName).to receive(:generate_name).and_call_original
     allow(TagName).to receive(:generate_name)
         .with(kind_of(described_class), second, primary_tag_name_for(second, 'ja'))
@@ -97,6 +100,69 @@ RSpec.describe Locale, type: :model do
 
     expect(described_class.exists?(code: 'ain-Kana')).to be(false)
     expect(TagName.where(language_code: 'ain', tag_id: [first.id, second.id])).to be_empty
+    expect(TagVersion.order(:id).map(&:attributes)).to eq(versions_before)
+  end
+
+  it 'records a separate automatic update for each tag without changing its authored create' do
+    author = create(:user, :admin)
+    tags = ['locale_history_first', 'locale_history_second'].map do |name|
+      Tag.find_or_create_by_tag_name!(Locale.nipponese, name, category: :general,
+                                     created_by_user: author)
+    end
+    originals = tags.map { |tag| tag.tag_versions.sole.attributes }
+
+    expect { create_ainu_locale! }.to change(TagVersion, :count).by(2)
+
+    tags.zip(originals).each do |tag, original|
+      versions = tag.tag_versions.order(:version_no).to_a
+      expect(versions.map(&:event_type)).to eq(['create', 'update'])
+      expect(versions.first.attributes).to eq(original)
+      expect(versions.first.created_by_user_id).to eq(author.id)
+      expect(versions.last).to have_attributes(version_no: 2, created_by_user_id: nil)
+      expect(versions.last.names.fetch('ain')).to eq(
+          'name' => tag.name('ja'), 'script_code' => 'Kana',
+          'auto_generated' => true, 'aliases' => [])
+      expect(versions.first.names.keys).to eq(['ja'])
+      expect(tag.reload.version_no).to eq(2)
+    end
+
+    expect { TagNameCompletion.for_locale!(Locale.find('ain-Kana')) }
+        .not_to change(TagVersion, :count)
+  end
+
+  it 'records automatic before and after snapshots for a tag without any history' do
+    tag = create(:tag, primary_name: 'legacy_before_locale')
+    expect(tag.tag_versions).to be_empty
+
+    create_ainu_locale!
+
+    versions = tag.tag_versions.order(:version_no).to_a
+    expect(versions.map(&:event_type)).to eq(['create', 'update'])
+    expect(versions.map(&:created_by_user_id)).to eq([nil, nil])
+    expect(versions.first.names.keys).to eq(['ja'])
+    expect(versions.last.names.keys).to match_array(['ja', 'ain'])
+    expect(versions.last.names.fetch('ja')).to eq(versions.first.names.fetch('ja'))
+  end
+
+  it 'rolls back earlier tag names and histories when a later history fails' do
+    first = create(:tag, primary_name: 'history_atomic_first')
+    second = create(:tag, primary_name: 'history_atomic_second')
+    names_before = TagName.order(:id).map(&:attributes)
+    versions_before = TagVersion.order(:id).map(&:attributes)
+    allow(TagVersioning).to receive(:record!).and_wrap_original do |original, tag, **options|
+      if tag.id == second.id && options[:event_type] == :update
+        raise ActiveRecord::RecordNotSaved, 'history failed'
+      end
+      original.call(tag, **options)
+    end
+
+    expect { create_ainu_locale! }
+        .to raise_error(ActiveRecord::RecordNotSaved, 'history failed')
+
+    expect(described_class.exists?(code: 'ain-Kana')).to be(false)
+    expect(TagName.order(:id).map(&:attributes)).to eq(names_before)
+    expect(TagVersion.order(:id).map(&:attributes)).to eq(versions_before)
+    expect([first.reload.version_no, second.reload.version_no]).to eq([1, 1])
   end
 
   it 'rejects a private locale code outside the supported locale set' do

backend/spec/requests/locale_write_paths_spec.rb

@@ -14,7 +14,19 @@ RSpec.describe 'Locale propagation on write paths', type: :request do
     expect(tag_name).to have_attributes(
         script_code: expected_locale.script_code, primary_flg: true)
     expect(tag_name.tag_id).to be_present
-    tag_name.tag
+    tag = tag_name.tag
+    version = tag.tag_versions.sole
+    expect(version).to have_attributes(
+        event_type: 'create', version_no: 1, created_by_user_id: member.id)
+    expect(tag.reload.version_no).to eq(1)
+    expect(version.names.keys).to match_array(
+        Locale.where(deprecated_at: nil).distinct.pluck(:language_code))
+    tag.tag_names.where(primary_flg: true).each do |primary|
+      expect(version.names.fetch(primary.language_code)).to include(
+          'name' => primary.name, 'script_code' => primary.script_code,
+          'auto_generated' => primary.auto_generated, 'aliases' => [])
+    end
+    tag
   end
 
   it 'confirms a generated Nipponese primary when a human renames it' do

backend/spec/requests/nico_tags_spec.rb

@@ -231,11 +231,14 @@ RSpec.describe 'NicoTags', type: :request do
         replacement: 'valid'
       )
       nico_tag
+      before_counts = [Tag.count, TagName.count, TagVersion.count]
 
       expect {
         patch "/tags/nico/#{nico_tag.id}", params: { tags: 'created_first invalid' }
       }.not_to change(TagName, :count)
 
+      expect([Tag.count, TagName.count, TagVersion.count]).to eq(before_counts)
+
       expect(response).to have_http_status(:unprocessable_entity)
       expect(json.fetch('errors').fetch('tags')).to include(
           a_string_including('タグ名 “invalid”:', '名前に使用できない文字が含まれてゐます．'))

backend/spec/requests/sitemap_entries_spec.rb

@@ -0,0 +1,155 @@
+require 'rails_helper'
+
+RSpec.describe 'Sitemap entries API', type: :request do
+  include_context 'Ainu locale'
+
+  let(:user) { create(:user, :member) }
+
+  it 'serves public resource counts with the default locale and page size' do
+    create(:post)
+    create(:tag, primary_name: 'sitemap_count_tag')
+
+    get '/sitemap_entries'
+
+    expect(response).to have_http_status(:ok)
+    expect(json.fetch('page_size')).to eq(1_000)
+    counts = json.fetch('resources').to_h { |entry|
+      [entry.fetch('resource'), entry.fetch('count')]
+    }
+    expect(counts).to eq(
+        'posts' => Post.count, 'tags' => Tag.count, 'deerjikists' => 0,
+        'materials' => 0, 'descriptions' => 0, 'tag_groups' => 0, 'theatres' => 0)
+  end
+
+  it 'paginates public post IDs in ascending order without exposing post contents' do
+    stub_const('SitemapEntriesController::PAGE_SIZE', 2)
+    posts = create_list(:post, 3)
+
+    get '/sitemap_entries/posts'
+    expect(response).to have_http_status(:ok)
+    expect(json).to eq('ids' => posts.first(2).map(&:id))
+
+    get '/sitemap_entries/posts', params: { page: 2 }
+    expect(response).to have_http_status(:ok)
+    expect(json).to eq('ids' => [posts.last.id])
+
+    get '/sitemap_entries/posts', params: { page: 3 }
+    expect(response).to have_http_status(:not_found)
+  end
+
+  ['0', '-1', 'invalid', '1.5'].each do |page|
+    it "rejects invalid sitemap page #{ page.inspect }" do
+      get '/sitemap_entries/posts', params: { page: }
+
+      expect(response).to have_http_status(:bad_request)
+    end
+  end
+
+  it 'rejects unsupported resource names' do
+    get '/sitemap_entries/users'
+
+    expect(response).to have_http_status(:not_found)
+  end
+
+  it 'returns an empty first page for a resource without entries' do
+    get '/sitemap_entries/posts'
+
+    expect(response).to have_http_status(:ok)
+    expect(json).to eq('ids' => [])
+  end
+
+  it 'rejects unregistered, deprecated and unsupported locales' do
+    get '/sitemap_entries', params: { locale: 'ain-Kana' }
+    expect(response).to have_http_status(:not_found)
+
+    locale.update!(deprecated_at: Time.current)
+    ['/sitemap_entries', '/sitemap_entries/posts'].each do |path|
+      get path, params: { locale: 'ain-Kana' }
+      expect(response).to have_http_status(:not_found)
+
+      get path, params: { locale: 'en' }
+      expect(response).to have_http_status(:not_found)
+    end
+  end
+
+  it 'only lists live materials and theatres' do
+    material = Material.create!(url: 'https://example.com/sitemap-material')
+    discarded_material = Material.create!(url: 'https://example.com/sitemap-discarded')
+    discarded_material.discard!
+    theatre = create(:theatre)
+    create(:theatre).discard!
+
+    get '/sitemap_entries/materials'
+    expect(response).to have_http_status(:ok)
+    expect(json).to eq('ids' => [material.id])
+
+    get '/sitemap_entries/theatres'
+    expect(response).to have_http_status(:ok)
+    expect(json).to eq('ids' => [theatre.id])
+  end
+
+  context 'with an active Ainu locale' do
+    before { locale }
+
+    it 'uses tag IDs and only includes deerjikists with linked accounts' do
+      tagged = create(:tag, primary_name: 'sitemap_deer', category: :deerjikist)
+      unlinked = create(:tag, primary_name: 'sitemap_unlinked', category: :deerjikist)
+      Deerjikist.create!(tag: tagged, platform: 'youtube', code: 'sitemap-channel')
+      Deerjikist.create!(tag: tagged, platform: 'nico', code: 'sitemap-nico')
+
+      get '/sitemap_entries/tags', params: { locale: 'ain-Kana' }
+      expect(response).to have_http_status(:ok)
+      expect(json.fetch('ids')).to contain_exactly(tagged.id, unlinked.id)
+
+      get '/sitemap_entries/deerjikists', params: { locale: 'ain-Kana' }
+      expect(response).to have_http_status(:ok)
+      expect(json).to eq('ids' => [tagged.id])
+    end
+
+    it 'lists description IDs for the requested language with a nonempty current version' do
+      tag = create(:tag, primary_name: 'sitemap_description')
+      japanese = TagDescriptionOperation.create!(
+          Locale.nipponese, tag:, body: 'Japanese sitemap body', created_by_user: user)
+      ainu = TagDescriptionOperation.create!(
+          locale, tag:, body: 'Ainu sitemap body', created_by_user: user)
+      unversioned_tag = create(:tag, primary_name: 'sitemap_unversioned')
+      TagDescription.create!(tag: unversioned_tag, language_code: 'ain',
+                             body: 'No revision', version_no: 1)
+      empty_tag = create(:tag, primary_name: 'sitemap_empty')
+      # Legacy empty bodies can exist even though the write service rejects them.
+      empty = TagDescription.create!(tag: empty_tag, language_code: 'ain',
+                                     body: '', version_no: 1)
+      TagDescriptionVersion.create!(tag_id: empty_tag.id, language_code: 'ain',
+                                    body: '', version_no: 1, event_type: 'create',
+                                    created_by_user_id: user.id, created_at: Time.current)
+
+      get '/sitemap_entries/descriptions', params: { locale: 'ain-Kana' }
+      expect(response).to have_http_status(:ok)
+      expect(json).to eq('ids' => [ainu.id])
+      expect(json.fetch('ids')).not_to include(japanese.id, empty.id)
+
+      get '/sitemap_entries/descriptions', params: { locale: 'ja' }
+      expect(response).to have_http_status(:ok)
+      expect(json).to eq('ids' => [japanese.id])
+
+      get '/sitemap_entries', params: { locale: 'ain-Kana' }
+      expect(response).to have_http_status(:ok)
+      descriptions = json.fetch('resources').find { |entry|
+        entry.fetch('resource') == 'descriptions'
+      }
+      expect(descriptions.fetch('count')).to eq(1)
+    end
+
+    it 'excludes groups without a revision matching the current version' do
+      group = TagGroupOperation.create!(
+          Locale.nipponese, name: 'Sitemap group', description: 'Group description',
+          members: [], placements: [], actor: user)
+      TagGroup.create!(name: 'Unversioned sitemap group', version_no: 1)
+
+      get '/sitemap_entries/tag_groups', params: { locale: 'ain-Kana' }
+
+      expect(response).to have_http_status(:ok)
+      expect(json).to eq('ids' => [group.id])
+    end
+  end
+end

backend/spec/services/post_creator_spec.rb

@@ -95,7 +95,8 @@ RSpec.describe PostCreator do
         post = described_class.new(actor:, attributes:).create!(locale)
 
         expect(Tag).to have_received(:find_or_create_by_tag_name!)
-            .with(locale, 'locale_character', category: :character).at_least(:once)
+            .with(locale, 'locale_character', category: :character,
+                  created_by_user: actor).at_least(:once)
         tag_name = TagName.find_by!(language_code: 'ain', name: 'locale_character')
         expect(tag_name).to have_attributes(script_code: 'Kana', primary_flg: true)
         expect(post.tags).to include(tag_name.tag)

backend/spec/services/tag_name_completion_spec.rb

@@ -1,6 +1,7 @@
 require 'rails_helper'
 
 RSpec.describe TagNameCompletion do
+  let(:author) { create(:user, :member) }
   let!(:language) { Language.create!(code: 'ain', name: 'ain') }
   let!(:script) { Script.create!(code: 'Kana', name: 'Kana') }
   let(:locale) do
@@ -65,4 +66,62 @@ RSpec.describe TagNameCompletion do
         .to contain_exactly(['ja', 'アイヌ'], ['ain', 'アイヌ'])
     expect(Tag.find_or_create_by_tag_name!(locale, 'アイヌ', category: :general)).to eq(tag)
   end
+
+  ['ja', 'ain'].each do |language|
+    it "records one authored create with all names for a #{ language } origin" do
+      ainu_locale = locale
+      origin = language == 'ja' ? Locale.nipponese : ainu_locale
+      tag = nil
+
+      expect {
+        tag = Tag.find_or_create_by_tag_name!(origin, 'アイヌ', category: :general,
+                                             created_by_user: author)
+      }.to change(TagVersion, :count).by(1)
+
+      version = tag.tag_versions.sole
+      expect(version).to have_attributes(
+          event_type: 'create', version_no: 1, created_by_user_id: author.id)
+      expect(tag.reload.version_no).to eq(1)
+      expect(version.names).to eq(
+          'ja' => { 'name' => 'アイヌ', 'script_code' => 'Jpan',
+                    'auto_generated' => language != 'ja', 'aliases' => [] },
+          'ain' => { 'name' => 'アイヌ', 'script_code' => 'Kana',
+                     'auto_generated' => language != 'ain', 'aliases' => [] })
+
+      expect {
+        described_class.for_tag!(tag, created_by_user: author)
+        found = Tag.find_or_create_by_tag_name!(origin, 'アイヌ', category: :general,
+                                               created_by_user: author)
+        expect(found).to eq(tag)
+        TagVersioning.record_tag_snapshot!(tag, created_by_user: author)
+      }.not_to change(TagVersion, :count)
+      expect(version.reload.created_by_user_id).to eq(author.id)
+    end
+  end
+
+  it 'records the author even when no additional language needs completion' do
+    tag = build(:tag, primary_name: 'single_language_creation')
+
+    described_class.for_tag!(tag, created_by_user: author)
+
+    expect(tag).to be_persisted
+    expect(tag.tag_versions.sole).to have_attributes(
+        event_type: 'create', version_no: 1, created_by_user_id: author.id)
+    expect(tag.tag_versions.sole.names.keys).to eq(['ja'])
+  end
+
+  it 'rolls back a new tag and all names when its create history fails' do
+    locale
+    author
+    before_counts = [Tag.count, TagName.count, TagVersion.count]
+    allow(TagVersioning).to receive(:record!).and_raise('history failed')
+
+    expect {
+      Tag.find_or_create_by_tag_name!(Locale.nipponese, 'atomic_new_history',
+                                     category: :general, created_by_user: author)
+    }.to raise_error('history failed')
+
+    expect([Tag.count, TagName.count, TagVersion.count]).to eq(before_counts)
+    expect(TagName.where(name: 'atomic_new_history')).to be_empty
+  end
 end