#399

backend/app/services/post_import_previewer.rb

@@ -1,5 +1,13 @@
 class PostImportPreviewer
-  FIELDS = %w[title thumbnail_base original_created_from original_created_before duration tags parent_post_ids].freeze
+  FIELDS = [
+    'title',
+    'thumbnail_base',
+    'original_created_from',
+    'original_created_before',
+    'duration',
+    'tags',
+    'parent_post_ids',
+  ].freeze
 
   def initialize parsed:, url_column:, mappings: { }, existing: 'skip'
     @parsed = parsed
@@ -17,20 +25,32 @@ class PostImportPreviewer
     rows.map do |row|
       row = row.symbolize_keys
       values = row[:values] || []
-      attributes = row[:attributes]&.stringify_keys || FIELDS.to_h { |field| [field, mapped_value(field, values)] }
+      attributes = row[:attributes]&.stringify_keys || FIELDS.to_h { |field|
+        [field, mapped_value(field, values)]
+      }
       provenance = row[:provenance]&.stringify_keys || mapped_provenance(attributes)
-      tag_sources = row[:tag_sources]&.stringify_keys || initial_tag_sources(attributes, provenance)
+      tag_sources =
+        row[:tag_sources]&.stringify_keys || initial_tag_sources(attributes, provenance)
       tag_sources['manual'] = attributes['tags'].to_s if provenance['tags'] == 'manual'
       url = row[:url].presence || values[@url_column].to_s.strip
       provenance['url'] ||= row[:url].present? ? 'manual' : 'mapped'
       url_for_metadata = normalised_url(url) || url
       existing_post = normalised_url(url).present? && Post.exists?(url: normalised_url(url))
       if existing_post && @existing == 'skip'
-        next { source_row: row[:source_row], url: normalised_url(url) || url, attributes:,
-               provenance:, tag_sources:, metadata_url: url_for_metadata,
-               fetch_warnings: [], validation_warnings: ['既存投稿のためスキップします．'],
-               warnings: ['既存投稿のためスキップします．'], validation_errors: { },
-               status: 'warning', existing: true }
+        next {
+          source_row: row[:source_row],
+          url: normalised_url(url) || url,
+          attributes:,
+          provenance:,
+          tag_sources:,
+          metadata_url: url_for_metadata,
+          fetch_warnings: [],
+          validation_warnings: ['既存投稿のためスキップします．'],
+          warnings: ['既存投稿のためスキップします．'],
+          validation_errors: { },
+          status: 'warning',
+          existing: true,
+        }
       end
       url_changed = row[:metadata_url].present? && row[:metadata_url] != url_for_metadata
       clear_automatic_values!(attributes, provenance, tag_sources) if url_changed
@@ -43,7 +63,8 @@ class PostImportPreviewer
           when false, nil then false
           else raise ArgumentError, 'メタデータ取得対象が不正です．'
           end
-      metadata, fetch_warnings = metadata_for(url_for_metadata, should_fetch, metadata_cache, fetch_warnings)
+      metadata, fetch_warnings =
+        metadata_for(url_for_metadata, should_fetch, metadata_cache, fetch_warnings)
       metadata.each do |field, value|
         if field == 'tags' && provenance[field] != 'manual'
           tag_sources['automatic'] = value.to_s
@@ -62,19 +83,37 @@ class PostImportPreviewer
       errors[:url] = ['URL が重複しています．'] if normal_url.present? && urls.key?(normal_url)
       urls[normal_url] = true if normal_url.present?
       if normal_url.present? && existing_post
-        @existing == 'error' ? errors[:url] = ['既存投稿です．'] : validation_warnings << '既存投稿のためスキップします．'
+        if @existing == 'error'
+          errors[:url] = ['既存投稿です．']
+        else
+          validation_warnings << '既存投稿のためスキップします．'
+        end
       end
       validate_basic_data(attributes, errors)
-      validate_preview_tags(merged_tags(tag_sources, provenance['tags']), errors, validation_warnings)
+      validate_preview_tags(
+        merged_tags(tag_sources, provenance['tags']),
+        errors,
+        validation_warnings,
+      )
       validate_parents(attributes['parent_post_ids'], errors)
       attributes.delete('url')
       attributes['tags'] = merged_tags(tag_sources, provenance['tags'])
-      { source_row: row[:source_row], url: normal_url || url, attributes:, provenance:, tag_sources:,
+      {
+        source_row: row[:source_row],
+        url: normal_url || url,
+        attributes:,
+        provenance:,
+        tag_sources:,
         metadata_url: url_for_metadata,
-        fetch_warnings:, validation_warnings:, warnings: fetch_warnings + validation_warnings,
+        fetch_warnings:,
+        validation_warnings:,
+        warnings: fetch_warnings + validation_warnings,
         validation_errors: errors,
-        status: errors.present? ? 'error' : ((fetch_warnings + validation_warnings).present? ? 'warning' : 'ready'),
-        existing: normal_url.present? && Post.exists?(url: normal_url) }
+        status: errors.present? \
+                  ? 'error' \
+                  : ((fetch_warnings + validation_warnings).present? ? 'warning' : 'ready'),
+        existing: normal_url.present? && Post.exists?(url: normal_url),
+      }
     end
   end
 
@@ -95,7 +134,9 @@ class PostImportPreviewer
     return '' if mapping.blank?
     return mapping['value'].to_s if mapping['kind'] == 'fixed'
 
-    Array(mapping['columns']).filter_map { |index| values[index.to_i].to_s.presence }.join(field == 'tags' ? ' ' : '')
+    Array(mapping['columns']).filter_map { |index|
+      values[index.to_i].to_s.presence
+    }.join(field == 'tags' ? ' ' : '')
   end
 
   def mapped_provenance attributes
@@ -122,11 +163,14 @@ class PostImportPreviewer
   def merged_tags sources, origin = nil
     return sources['manual'].to_s if origin == 'manual'
 
-    %w[automatic mapped fixed manual].flat_map { sources[_1].to_s.split }.uniq.join(' ')
+    ['automatic', 'mapped', 'fixed', 'manual'].flat_map {
+      sources[_1].to_s.split
+    }.uniq.join(' ')
   end
 
   def clear_automatic_values! attributes, provenance, tag_sources
-    %w[title thumbnail_base original_created_from original_created_before duration].each do |field|
+    ['title', 'thumbnail_base', 'original_created_from',
+     'original_created_before', 'duration'].each do |field|
       attributes[field] = '' if provenance[field] == 'automatic'
     end
     tag_sources['automatic'] = ''
@@ -140,8 +184,13 @@ class PostImportPreviewer
     warnings << 'タイトルを取得できませんでした．' if data['title'].blank?
     warnings << 'サムネールを取得できませんでした．' if data['thumbnail_base'].blank?
     [data.compact, warnings]
-  rescue Preview::UrlSafety::UnsafeUrl, Preview::HttpFetcher::FetchFailed, Preview::HttpFetcher::ResponseTooLarge => e
-    Rails.logger.info("post_import_metadata_fetch_failure #{ { error: e.class.name, message: e.message }.to_json }")
+  rescue Preview::UrlSafety::UnsafeUrl,
+         Preview::HttpFetcher::FetchFailed,
+         Preview::HttpFetcher::ResponseTooLarge => e
+    Rails.logger.info(
+      "post_import_metadata_fetch_failure "\
+      "#{ { error: e.class.name, message: e.message }.to_json }",
+    )
     [{ }, ['メタデータを取得できませんでした．']]
   end
 
@@ -190,7 +239,10 @@ class PostImportPreviewer
   def validate_parents raw, errors
     ids = raw.to_s.split.map { Integer(_1, exception: false) }
     return if ids.compact.empty? && raw.to_s.blank?
+
     errors[:parent_post_ids] = ['親投稿 Id. が不正です．'] and return if ids.any? { _1.nil? || _1 <= 0 }
-    errors[:parent_post_ids] = ['存在しない親投稿 Id. があります．'] if Post.where(id: ids).count != ids.uniq.length
+    if Post.where(id: ids).count != ids.uniq.length
+      errors[:parent_post_ids] = ['存在しない親投稿 Id. があります．']
+    end
   end
 end