#399

backend/app/services/post_import_runner.rb

@@ -1,6 +1,16 @@
 class PostImportRunner
   MAX_ROWS = PostImportSourceParser::MAX_ROWS
-  ATTRIBUTE_KEYS = %w[title thumbnail_base original_created_from original_created_before duration tags parent_post_ids video_ms].freeze
+  ATTRIBUTE_KEYS = [
+    'title',
+    'thumbnail_base',
+    'original_created_from',
+    'original_created_before',
+    'duration',
+    'tags',
+    'parent_post_ids',
+    'video_ms',
+  ].freeze
+
   def initialize actor:, rows:, existing: 'skip'
     @actor = actor
     @rows = rows
@@ -9,15 +19,21 @@ class PostImportRunner
 
   def run
     raise ArgumentError, "取込件数は #{ MAX_ROWS } 件までです．" if @rows.length > MAX_ROWS
-    raise ArgumentError, '取込データが大きすぎます．' if @rows.sum { |row| row.to_json.bytesize } > PostImportSourceParser::MAX_BYTES
+    if @rows.sum { |row| row.to_json.bytesize } > PostImportSourceParser::MAX_BYTES
+      raise ArgumentError, '取込データが大きすぎます．'
+    end
 
     normalised_rows = @rows.map { |row| normalise_row(row) }
     source_rows = normalised_rows.map { _1['source_row'] }
     raise ArgumentError, '元行番号が重複しています．' if source_rows.uniq.length != source_rows.length
 
     results = normalised_rows.map { |row| run_row(row) }
-    { created: results.count { _1[:status] == 'created' }, skipped: results.count { _1[:status] == 'skipped' },
-      failed: results.count { _1[:status] == 'failed' }, rows: results }
+    {
+      created: results.count { _1[:status] == 'created' },
+      skipped: results.count { _1[:status] == 'skipped' },
+      failed: results.count { _1[:status] == 'failed' },
+      rows: results,
+    }
   end
 
   private
@@ -26,20 +42,40 @@ class PostImportRunner
     validate_row_structure!(row)
     attributes = row.fetch('attributes', { }).to_h.transform_keys { _1.to_s.underscore }
     raise ArgumentError, '取込項目が不正です．' unless (attributes.keys - ATTRIBUTE_KEYS).empty?
-    raise ArgumentError, '取込項目が大きすぎます．' if attributes.values.any? { _1.to_s.bytesize > PostImportSourceParser::MAX_CELL_BYTES }
-    raise ArgumentError, 'URL が長すぎます．' if row['url'].to_s.bytesize > PostImportSourceParser::MAX_CELL_BYTES
-    validate_tag_sources!(row['tag_sources'])
-    preview = PostImportPreviewer.new(parsed: { columns: [], rows: [] }, url_column: 0,
-                                      mappings: {}, existing: @existing).preview_rows(
-                                          rows: [{ source_row: row['source_row'], url: row['url'],
-                                                   attributes:, provenance: row['provenance'],
-                                                   tag_sources: row['tag_sources'] }],
-                                          fetch_metadata: false).first
-    if preview[:validation_errors].present?
-      return { source_row: row['source_row'], status: 'failed',
-               errors: preview[:validation_errors] }
+    if attributes.values.any? { _1.to_s.bytesize > PostImportSourceParser::MAX_CELL_BYTES }
+      raise ArgumentError, '取込項目が大きすぎます．'
     end
-    return row.slice('source_row').merge(status: 'skipped') if @existing == 'skip' && preview[:existing]
+    if row['url'].to_s.bytesize > PostImportSourceParser::MAX_CELL_BYTES
+      raise ArgumentError, 'URL が長すぎます．'
+    end
+    validate_tag_sources!(row['tag_sources'])
+    preview = PostImportPreviewer.new(
+      parsed: { columns: [], rows: [] },
+      url_column: 0,
+      mappings: {},
+      existing: @existing,
+    ).preview_rows(
+      rows: [{
+        source_row: row['source_row'],
+        url: row['url'],
+        attributes:,
+        provenance: row['provenance'],
+        tag_sources: row['tag_sources'],
+      }],
+      fetch_metadata: false,
+    ).first
+    if preview[:validation_errors].present?
+      return {
+        source_row: row['source_row'],
+        status: 'failed',
+        errors: preview[:validation_errors],
+      }
+    end
+
+    if @existing == 'skip' && preview[:existing]
+      return row.slice('source_row').merge(status: 'skipped')
+    end
+
     attributes['tags'] = preview[:attributes]['tags']
     attributes['url'] = row['url']
     post = PostCreator.new(actor: @actor, attributes:).create!
@@ -53,7 +89,9 @@ class PostImportRunner
   rescue ArgumentError, PostCreator::VideoMsParseError
     { source_row: row['source_row'], status: 'failed', errors: { base: ['入力値が不正です．'] } }
   rescue StandardError => e
-    Rails.logger.error("post_import_runner_failure #{ { error: e.class.name, message: e.message }.to_json }")
+    Rails.logger.error(
+      "post_import_runner_failure #{ { error: e.class.name, message: e.message }.to_json }",
+    )
     { source_row: row['source_row'], status: 'failed', errors: { base: ['登録中にエラーが発生しました．'] } }
   end
 
@@ -61,9 +99,11 @@ class PostImportRunner
     return if sources.blank?
 
     sources = sources.to_h
-    raise ArgumentError unless (sources.keys - %w[automatic mapped fixed manual]).empty?
+    raise ArgumentError unless (sources.keys - ['automatic', 'mapped', 'fixed', 'manual']).empty?
     raise ArgumentError unless sources.values.all?(String)
-    raise ArgumentError if sources.values.any? { _1.bytesize > PostImportSourceParser::MAX_CELL_BYTES }
+    if sources.values.any? { _1.bytesize > PostImportSourceParser::MAX_CELL_BYTES }
+      raise ArgumentError
+    end
     raise ArgumentError if sources.values.sum(&:bytesize) > PostImportSourceParser::MAX_CELL_BYTES
   end
 
@@ -71,12 +111,22 @@ class PostImportRunner
     raise ArgumentError unless row['source_row'].is_a?(Integer) && row['source_row'].positive?
     raise ArgumentError unless row['url'].is_a?(String)
     raise ArgumentError unless row['attributes'].is_a?(Hash)
-    raise ArgumentError unless row['attributes'].values.all? { _1.is_a?(String) || _1.is_a?(Numeric) || _1 == true || _1 == false || _1.nil? }
+    unless row['attributes'].values.all? { |value|
+             value.is_a?(String) ||
+               value.is_a?(Numeric) ||
+               value == true ||
+               value == false ||
+               value.nil?
+           }
+      raise ArgumentError
+    end
     provenance = row['provenance']
     raise ArgumentError unless provenance.is_a?(Hash)
     allowed = ATTRIBUTE_KEYS + ['url']
     raise ArgumentError unless (provenance.keys - allowed).empty?
-    raise ArgumentError unless provenance.values.all? { _1.in?(['automatic', 'mapped', 'fixed', 'manual']) }
+    unless provenance.values.all? { _1.in?(['automatic', 'mapped', 'fixed', 'manual']) }
+      raise ArgumentError
+    end
     metadata_url = row['metadata_url']
     raise ArgumentError unless metadata_url.nil? || metadata_url.is_a?(String)
     raise ArgumentError if metadata_url.to_s.bytesize > PostImportSourceParser::MAX_CELL_BYTES
@@ -86,9 +136,7 @@ class PostImportRunner
   end
 
   def normalise_row row
-    unless row.is_a?(Hash)
-      raise ArgumentError, '取込行の形式が不正です．'
-    end
+    raise ArgumentError, '取込行の形式が不正です．' unless row.is_a?(Hash)
 
     normalised = row.deep_transform_keys { _1.to_s.underscore }
     source_row = Integer(normalised['source_row'], exception: false)