post_tags の論理削除と履歴管理を廃止 (#411) (#417)

Reviewed-on: #417
Co-authored-by: miteruzo <miteruzo@naver.com>

backend/app/controllers/posts_controller.rb

@@ -36,8 +36,8 @@ class PostsController < ApplicationController
     offset = (page - 1) * limit
 
     pt_max_sql =
-        PostTag
-        .select('post_id, MAX(updated_at) AS max_updated_at')
+        PostVersion
+        .select('post_id, MAX(created_at) AS max_updated_at')
         .group('post_id')
         .to_sql
 
@@ -50,9 +50,8 @@ class PostsController < ApplicationController
         .joins("LEFT JOIN (#{ pt_max_sql }) pt_max ON pt_max.post_id = posts.id")
         .reselect('posts.*', Arel.sql("#{ updated_at_all_sql } AS updated_at_all"))
         .preload(:uploaded_user, :parents, :children,
-                 active_post_tags: [:sections,
-                                    { tag: [:deerjikists, :materials,
-                                            { tag_name: :wiki_page }] }])
+                 post_tags: [:sections, { tag: [:deerjikists, :materials,
+                                                { tag_name: :wiki_page }] }])
         .with_attached_thumbnail
 
     q = q.where('posts.url LIKE ?', "%#{ url }%") if url
@@ -104,9 +103,8 @@ class PostsController < ApplicationController
 
   def random
     post = filtered_posts.preload(:uploaded_user, :parents, :children,
-                                  active_post_tags: [:sections,
-                                                     { tag: [:deerjikists, :materials,
-                                                             { tag_name: :wiki_page }] }])
+                                  post_tags: [:sections, { tag: [:deerjikists, :materials,
+                                                                 { tag_name: :wiki_page }] }])
                          .with_attached_thumbnail
                          .order('RAND()')
                          .first
@@ -190,9 +188,8 @@ class PostsController < ApplicationController
     post =
         Post
         .includes(:uploaded_user, :parents, :children,
-                  active_post_tags: [:sections,
-                                     { tag: [:deerjikists, :materials,
-                                             { tag_name: :wiki_page }] }])
+                  post_tags: [:sections, { tag: [:deerjikists, :materials,
+                                                 { tag_name: :wiki_page }] }])
         .with_attached_thumbnail
         .find_by(id: params[:id])
     return head :not_found unless post
@@ -384,50 +381,6 @@ class PostsController < ApplicationController
     render_post_form_record_invalid e.record
   end
 
-  def changes
-    id = params[:id].presence
-    tag_id = params[:tag].presence
-    page = (params[:page].presence || 1).to_i
-    limit = (params[:limit].presence || 20).to_i
-
-    page = 1 if page < 1
-    limit = 1 if limit < 1
-
-    offset = (page - 1) * limit
-
-    pts = PostTag.with_discarded
-    pts = pts.where(post_id: id) if id.present?
-    pts = pts.where(tag_id:) if tag_id.present?
-    pts = pts.includes(:post, :created_user, :deleted_user,
-                       tag: [:deerjikists, :materials, { tag_name: :wiki_page }])
-
-    events = []
-    pts.each do |pt|
-      tag = TagRepr.base(pt.tag)
-      post = pt.post
-
-      events << Event.new(
-          post:,
-          tag:,
-          user: pt.created_user && { id: pt.created_user.id, name: pt.created_user.name },
-          change_type: 'add',
-          timestamp: pt.created_at)
-
-      if pt.discarded_at
-        events << Event.new(
-            post:,
-            tag:,
-            user: pt.deleted_user && { id: pt.deleted_user.id, name: pt.deleted_user.name },
-            change_type: 'remove',
-            timestamp: pt.discarded_at)
-      end
-    end
-    events.sort_by!(&:timestamp)
-    events.reverse!
-
-    render json: { changes: (events.slice(offset, limit) || []).as_json, count: events.size }
-  end
-
   private
 
   def filtered_posts
@@ -502,13 +455,13 @@ class PostsController < ApplicationController
       end
     end
 
-    PostTag.where(post_id: post.id, tag_id: to_remove.to_a).kept.find_each do |pt|
-      pt.discard_by!(current_user)
+    PostTag.where(post_id: post.id, tag_id: to_remove.to_a).find_each do |pt|
+      pt.destroy!
     end
   end
 
   def build_tag_tree_for post
-    post_tags = post.active_post_tags.reject { |post_tag| post_tag.tag.deprecated? }
+    post_tags = post.post_tags.reject { |post_tag| post_tag.tag.deprecated? }
     tags = post_tags.map(&:tag)
     tag_ids = tags.map(&:id)
 
@@ -717,7 +670,6 @@ class PostsController < ApplicationController
   def editable_tag_names_from_post post
     post
         .post_tags
-        .kept
         .joins(tag: :tag_name)
         .merge(Tag.not_nico)
         .merge(Tag.where(deprecated_at: nil))