#399

2026-07-16 20:05:09 +09:00
@@ -68,7 +68,7 @@ RSpec.describe PostImportPreviewer do
      allow(PostMetadataFetcher).to receive(:fetch).and_return(
        title: 'metadata title',
        thumbnail_base: 'https://example.com/thumb.jpg',
-        duration: 2_000,
+        duration: '2',
        tags: 'known-tag'
      )

@@ -79,7 +79,7 @@ RSpec.describe PostImportPreviewer do
      expect(result.fetch(:attributes)).to include(
        'title' => 'metadata title',
        'thumbnail_base' => 'https://example.com/thumb.jpg',
-        'duration' => 2_000,
+        'duration' => '2',
        'tags' => 'known-tag'
      )
      expect(result.fetch(:field_warnings)).not_to have_key('tags')
@@ -6,7 +6,7 @@ RSpec.describe PostImportRowNormaliser do
      sourceRow: '1',
      url: 'https://example.com/post',
      metadataUrl: 'https://example.com/post',
-      attributes: { title: 'title', duration: 1_000 },
+      attributes: { title: 'title', duration: '1' },
      provenance: { url: 'manual', title: 'automatic' },
      tagSources: { automatic: 'tag', manual: '' }
    }.deep_merge(overrides)
@@ -21,7 +21,7 @@ RSpec.describe PostImportRowNormaliser do
          'source_row' => 1,
          'url' => 'https://example.com/post',
          'metadata_url' => 'https://example.com/post',
-          'attributes' => { 'title' => 'title', 'duration' => 1_000 },
+          'attributes' => { 'title' => 'title', 'duration' => '1' },
          'provenance' => { 'url' => 'manual', 'title' => 'automatic' },
          'tag_sources' => { 'automatic' => 'tag', 'manual' => '' }
        }
@@ -68,4 +68,42 @@ RSpec.describe PostMetadataFetcher do
    expect(result.fetch(:original_created_from)).to be_nil
    expect(result.fetch(:original_created_before)).to be_nil
  end
+
+  it 'returns nil dates for invalid calendar dates and invalid hour values' do
+    invalid_day = fetch_with_published_time('2024-02-31T12:00Z')
+    invalid_leap = fetch_with_published_time('2023-02-29T12:00Z')
+    invalid_hour = fetch_with_published_time('2024-02-29T24:00Z')
+
+    [invalid_day, invalid_leap, invalid_hour].each do |result|
+      expect(result.fetch(:original_created_from)).to be_nil
+      expect(result.fetch(:original_created_before)).to be_nil
+    end
+  end
+
+  it 'accepts a valid leap-day timestamp at minute precision' do
+    result = fetch_with_published_time('2024-02-29T12:34Z')
+
+    expect(result.fetch(:original_created_from)).to eq('2024-02-29T12:34:00Z')
+    expect(result.fetch(:original_created_before)).to eq('2024-02-29T12:35:00Z')
+  end
+
+  it 'serialises metadata duration as the same seconds string contract used by forms' do
+    html = <<~HTML
+      <html><head>
+        <meta property="article:published_time" content="2024-02-03T12:34:56.123+02:30">
+        <meta property="og:video:duration" content="2.5">
+      </head></html>
+    HTML
+    uri = URI.parse('https://example.com/video')
+    allow(Preview::UrlSafety).to receive(:validate)
+        .with('https://example.com/video')
+        .and_return([uri, ['8.8.8.8']])
+    allow(Preview::HttpFetcher).to receive(:fetch).and_return(Response.new(html))
+    allow(Preview::HtmlMetadataExtractor).to receive(:extract)
+        .and_return(title: 'title', image_url: nil)
+
+    result = described_class.fetch('https://example.com/video')
+
+    expect(result.fetch(:duration)).to eq('2.5')
+  end
 end