#422

backend/config/routes.rb

@@ -27,8 +27,8 @@ Rails.application.routes.draw do
       get :deerjikists
       put :deerjikists, action: :update_deerjikists
 
-      get :description, action: 'tag_descriptions#show'
+      get :description, to: 'tag_descriptions#show'
-      put :description, action: 'tag_descriptions#update'
+      put :description, to: 'tag_descriptions#update'
     end
   end
 

backend/spec/requests/tag_descriptions_spec.rb

@@ -42,10 +42,10 @@ RSpec.describe 'Tag description native API', type: :request do
     expect(request.path_parameters).to include(controller: 'tag_descriptions', action:)
   end
 
-  def native_write method, body:, request_headers: headers
+  def native_write body:, request_headers: headers
-    public_send(method, endpoint, params: { body: }, headers: request_headers)
+    put endpoint, params: { body: }, headers: request_headers
-    action = method == :post ? 'create' : 'update'
+    expect(request.path_parameters).to include(
-    expect(request.path_parameters).to include(controller: 'tag_descriptions', action:)
+        controller: 'tag_descriptions', action: 'update')
   end
 
   def expect_current description
@@ -71,9 +71,8 @@ RSpec.describe 'Tag description native API', type: :request do
           controller: 'tag_descriptions', action: 'show_by_title', name: 'native_description')
     end
 
-    it 'routes POST by Tag ID to create' do
+    it 'does not route POST by Tag ID' do
-      expect(post: '/tags/123/description').to route_to(
+      expect(post: '/tags/123/description').not_to be_routable
-          controller: 'tag_descriptions', action: 'create', id: '123')
     end
 
     it 'routes PUT by Tag ID to update' do
@@ -203,11 +202,12 @@ RSpec.describe 'Tag description native API', type: :request do
     end
   end
 
-  describe 'POST /tags/:id/description' do
+  describe 'PUT /tags/:id/description' do
+    context 'without an existing description' do
       before { tag }
 
       it 'creates both current resources and histories with matching compatibility IDs' do
-      expect { native_write(:post, body: 'created natively') }
+        expect { native_write(body: 'created natively') }
             .to change(TagDescription, :count).by(1)
             .and change(TagDescriptionVersion, :count).by(1)
             .and change(WikiPage, :count).by(1)
@@ -234,32 +234,19 @@ RSpec.describe 'Tag description native API', type: :request do
         expect(json).to include('body' => description.body, 'revision_id' => version.id)
       end
 
-    it 'returns the existing validation error format on duplicate creation' do
-      existing = TagDescription.create!(
-          tag:, language_code: 'ja', body: 'existing', version_no: 1,
-          created_by_user_id: author.id, updated_by_user_id: author.id)
-      before_state = stored_state
-      native_write(:post, body: 'duplicate')
-      expect(response).to have_http_status(:unprocessable_entity)
-      expect(json).to include('type' => 'validation_error', 'errors' => a_kind_of(Hash),
-                             'base_errors' => a_kind_of(Array), 'message' => a_kind_of(String))
-      expect(stored_state).to eq(before_state)
-      expect(existing.reload.body).to eq('existing')
-    end
-
       [WikiPage, WikiRevision, WikiVersion, TagDescription, TagDescriptionVersion].each do |model|
         it "rolls back native create when #{ model.name } persistence fails" do
           headers
           before_state = stored_state
           aggregate_failures do
-          fail_save(model) { native_write(:post, body: 'rollback create') }
+            fail_save(model) { native_write(body: 'rollback create') }
             expect(stored_state).to eq(before_state)
           end
         end
       end
     end
 
-  describe 'PUT /tags/:id/description' do
+    context 'with an existing description' do
       let!(:page) do
         tag
         Wiki::Commit.create_content!(tag_name:, body: 'before', created_by_user: author)
@@ -271,7 +258,7 @@ RSpec.describe 'Tag description native API', type: :request do
       it 'writes matching histories when the body changes' do
         expect(page.reload.version_no).to eq(1)
         expect(description.version_no).to eq(1)
-      expect { native_write(:put, body: 'after') }
+        expect { native_write(body: 'after') }
             .to change(WikiRevision, :count).by(1)
             .and change(WikiVersion, :count).by(1)
             .and change(TagDescriptionVersion, :count).by(1)
@@ -300,7 +287,7 @@ RSpec.describe 'Tag description native API', type: :request do
           description_state = description.reload.attributes
           current_revision_id = page.current_revision.id
 
-        native_write(:put, body:)
+          native_write(body:)
 
           expect(response).to have_http_status(:ok)
           expect(stored_state).to eq(before_state)
@@ -315,26 +302,20 @@ RSpec.describe 'Tag description native API', type: :request do
           headers
           before_state = stored_state
           aggregate_failures do
-          fail_save(model) { native_write(:put, body: 'rollback update') }
+            fail_save(model) { native_write(body: 'rollback update') }
             expect(stored_state).to eq(before_state)
           end
         end
       end
     end
+  end
 
   describe 'write access and validation' do
-    [:post, :put].each do |method|
+    before { tag }
-      context "with #{ method.upcase }" do
-        before do
-          tag
-          if method == :put
-            Wiki::Commit.create_content!(tag_name:, body: 'existing', created_by_user: author)
-          end
-        end
 
     it 'requires authentication without changing either system' do
       before_state = stored_state
-          native_write(method, body: 'unauthorised', request_headers: { })
+      native_write(body: 'unauthorised', request_headers: { })
       expect(response).to have_http_status(:unauthorized)
       expect(stored_state).to eq(before_state)
     end
@@ -342,7 +323,7 @@ RSpec.describe 'Tag description native API', type: :request do
     it 'rejects a guest without changing either system' do
       guest = create(:user, :guest)
       before_state = stored_state
-          native_write(method, body: 'forbidden',
+      native_write(body: 'forbidden',
                    request_headers: { 'X-Transfer-Code' => guest.inheritance_code })
       expect(response).to have_http_status(:forbidden)
       expect(stored_state).to eq(before_state)
@@ -351,7 +332,7 @@ RSpec.describe 'Tag description native API', type: :request do
     it 'rejects a banned member without changing either system' do
       banned = create(:user, :member, :banned)
       before_state = stored_state
-          native_write(method, body: 'forbidden',
+      native_write(body: 'forbidden',
                    request_headers: { 'X-Transfer-Code' => banned.inheritance_code })
       expect(response).to have_http_status(:forbidden)
       expect(stored_state).to eq(before_state)
@@ -360,13 +341,19 @@ RSpec.describe 'Tag description native API', type: :request do
     it 'rejects blank body using the existing validation error format' do
       headers
       before_state = stored_state
-          native_write(method, body: '')
+      native_write(body: '')
       expect(response).to have_http_status(:unprocessable_entity)
       expect(json).to include('type' => 'validation_error',
                              'errors' => include('body' => a_kind_of(Array)))
       expect(stored_state).to eq(before_state)
     end
-      end
+
+    it 'returns 404 when PUT targets a missing Tag' do
+      missing_id = Tag.maximum(:id).to_i + 1
+      put "/tags/#{ missing_id }/description",
+          params: { body: 'missing' },
+          headers: headers
+      expect(response).to have_http_status(:not_found)
     end
   end
 end