#55

backend/spec/requests/locale_write_paths_spec.rb

@@ -182,6 +182,51 @@ RSpec.describe 'Locale propagation on write paths', type: :request do
     end
     let!(:tag) { create(:tag, primary_tag_name: english_name) }
 
+    it 'marks a human-renamed generated primary as no longer auto-generated' do
+      generated_tag = create(:tag, primary_name: 'rename_generated_source')
+      generated_name = primary_tag_name_for(generated_tag, 'en')
+      expect(generated_name.auto_generated).to be(true)
+
+      patch "/tags/#{ generated_tag.id }", params: {
+          locale: 'en', name: 'human_english_name' }
+
+      expect(response).to have_http_status(:ok), response.body
+      expect(generated_name.reload).to have_attributes(
+          name: 'human_english_name', auto_generated: false)
+    end
+
+    it 'does not steal another tag primary for an alias' do
+      other_tag = create(:tag, primary_name: 'other_nipponese')
+      other_primary = primary_tag_name_for(other_tag, 'en')
+      other_primary.update!(name: 'other_english_primary', auto_generated: false)
+      create(:tag_name, :alias, tag:, name: 'existing_english_alias',
+                                language_code: 'en', script_code: 'Latn')
+      primary_name_before = primary_tag_name_for(tag, 'en').name
+      aliases_before =
+          tag.tag_names.where(language_code: 'en', primary_flg: false)
+              .order(:name).pluck(:name)
+      category_before = tag.category
+
+      put "/tags/#{ tag.id }", params: {
+          locale: 'en', name: 'renamed_before_alias_collision',
+          category: 'character', deprecated: false,
+          aliases: 'other_english_primary', parent_tags: '' }
+
+      aggregate_failures do
+        expect(response).to have_http_status(:unprocessable_entity)
+        expect(other_primary.reload).to have_attributes(
+            tag_id: other_tag.id, language_code: 'en', primary_flg: true)
+        expect(TagName.where(tag: other_tag, language_code: 'en', primary_flg: true))
+            .to contain_exactly(other_primary)
+        expect(primary_tag_name_for(tag.reload, 'en').name).to eq(primary_name_before)
+        expect(tag.category).to eq(category_before)
+        aliases_after =
+            tag.tag_names.where(language_code: 'en', primary_flg: false)
+                .order(:name).pluck(:name)
+        expect(aliases_after).to eq(aliases_before)
+      end
+    end
+
     it 'allows a rename to a name already used in Nipponese' do
       nipponese = create(:tag, primary_name: 'rename_target')