#419

backend/lib/tasks/sync_nico.rake

@@ -30,9 +30,28 @@ namespace :nico do
         end
       end
 
-      PostTag.where(post_id: post.id, tag_id: to_remove.to_a).find_each do |pt|
-        pt.destroy!
+      PostTag.where(post_id: post.id, tag_id: to_remove.to_a).find_each(&:destroy!)
+    end
+
+    def sync_post_external_tags! post, desired_external_tag_ids, current_external_tag_ids: nil
+      current_external_tag_ids ||=
+          PostExternalTag.where(post_id: post.id).pluck(:external_tag_id).to_set
+      desired_external_tag_ids = desired_external_tag_ids.compact.to_set
+
+      to_add = desired_external_tag_ids - current_external_tag_ids
+      to_remove = current_external_tag_ids - desired_external_tag_ids
+
+      ExternalTag.where(id: to_add.to_a).find_each do |external_tag|
+        begin
+          PostExternalTag.create!(post:, external_tag:)
+        rescue ActiveRecord::RecordNotUnique
+          ;
+        end
       end
+
+      PostExternalTag
+          .where(post_id: post.id, external_tag_id: to_remove.to_a)
+          .find_each(&:destroy!)
     end
 
     mysql_user = ENV['MYSQL_USER']
@@ -111,58 +130,63 @@ namespace :nico do
         sync_post_tags!(post, [Tag.tagme.id, Tag.bot.id, Tag.niconico.id, Tag.video.id])
       end
 
-      tags = post.tags
       # 既存のタグ Id. 集合
-      kept_tag_ids = tags.pluck(:id).to_set
-      # うち内部タグ Id. 集合
-      kept_non_nico_tag_ids = tags.pluck(:id).to_set
+      kept_tag_ids = post.tags.pluck(:id).to_set
+
+      # 既存の外部タグ Id. 集合
+      kept_external_tag_ids = post.external_tags.pluck(:id).to_set
+
+      # 記載すべき外部タグ Id. のリスト
+      desired_external_tag_ids = []
 
-      # 記載すべき外部タグ Id. および連携される内部タグ Id. のリスト
-      desired_nico_tag_based_ids = []
       # 記載すべき内部タグ Id. のリスト
-      desired_non_nico_tag_ids = []
+      desired_tag_ids = kept_tag_ids.to_a
 
       datum['tags'].each do |raw|
         tag = ExternalTag.find_or_create_by!(platform: :nico, name: raw)
 
         unless tag.nico_tag_versions.exists?
-          NicoTagVersionRecorder.record!(tag:, event_type: :create, created_by_user: nil)
+          NicoTagVersionRecorder.record!(external_tag: tag,
+                                         event_type: :create,
+                                         created_by_user: nil)
         end
 
-        desired_nico_tag_based_ids << tag.id
+        desired_external_tag_ids << tag.id
 
         # 新たに記載される外部タグと連携される内部タグを記載
-        unless tag.id.in?(kept_tag_ids)
-          linked_ids = tag.linked_tags.pluck(:id)
-          desired_non_nico_tag_ids.concat(linked_ids)
-          desired_nico_tag_based_ids.concat(linked_ids)
+        # 連携タグは記載すれども消除せず．
+        unless tag.id.in?(kept_external_tag_ids)
+          desired_tag_ids.concat(tag.linked_tags.pluck(:id))
         end
       end
 
       deerjikist = Deerjikist.find_by(platform: :nico, code: datum['user'])
       if deerjikist
-        desired_non_nico_tag_ids << deerjikist.tag_id
-        desired_nico_tag_based_ids << deerjikist.tag_id
-      elsif !(Tag.where(id: kept_non_nico_tag_ids).where(category: :deerjikist).exists?)
-        desired_non_nico_tag_ids << Tag.no_deerjikist.id
-        desired_nico_tag_based_ids << Tag.no_deerjikist.id
+        desired_tag_ids << deerjikist.tag_id
+      elsif !(Tag.where(id: kept_tag_ids).where(category: :deerjikist).exists?)
+        desired_tag_ids << Tag.no_deerjikist.id
       end
 
-      desired_nico_tag_based_ids.uniq!
+      desired_external_tag_ids.uniq!
+      desired_tag_ids.uniq!
 
-      desired_all_tag_ids = kept_non_nico_tag_ids.to_a + desired_nico_tag_based_ids
-      desired_non_nico_tag_ids.concat(kept_non_nico_tag_ids.to_a)
-      desired_non_nico_tag_ids.uniq!
-      if kept_non_nico_tag_ids != desired_non_nico_tag_ids.to_set
-        desired_all_tag_ids << Tag.bot.id
+      # 外部タグの記載に際しては “bot 操作” タグを記載しなぃ．
+      if kept_tag_ids != desired_tag_ids.to_set
+        desired_tag_ids << Tag.bot.id
+        desired_tag_ids.uniq!
       end
-      desired_all_tag_ids.uniq!
 
-      sync_post_tags!(post, desired_all_tag_ids, current_tag_ids: kept_tag_ids)
+      tags_changed =
+          kept_tag_ids != desired_tag_ids.to_set ||
+          kept_external_tag_ids != desired_external_tag_ids.to_set
+
+      sync_post_tags!(post, desired_tag_ids, current_tag_ids: kept_tag_ids)
+      sync_post_external_tags!(post, desired_external_tag_ids,
+                               current_external_tag_ids: kept_external_tag_ids)
 
       if post_created
         PostVersionRecorder.record!(post:, event_type: :create, created_by_user: nil)
-      elsif post_changed || kept_tag_ids != desired_all_tag_ids.to_set
+      elsif post_changed || tags_changed
         PostVersionRecorder.ensure_snapshot!(post, created_by_user: nil)
         PostVersionRecorder.record!(post:, event_type: :update, created_by_user: nil)
       end