#434

backend/spec/services/counts_export_spec.rb

@@ -193,11 +193,49 @@ RSpec.describe 'Counts download acknowledgement' do
     arguments = { file_token: 'file-token', attempt: receipt.fetch('download_attempt') }
     expect(CountsExportJobs.download_attempt(token, 'other', **arguments)).to be_nil
     expect(CountsExportJobs.download_attempt(token, 'owner', **arguments.merge(file_token: 'wrong'))).to be_nil
+    CountsExportJobs.download_attempt(token, 'owner', **arguments, status: 'streaming')
     CountsExportJobs.download_attempt(token, 'owner', **arguments, status: 'started')
     expect(CountsExportJobs.status(token, 'owner')['download_status']).to eq('started')
-    CountsExportJobs.download_attempt(token, 'owner')
+    expect(CountsExportJobs.download_attempt(token, 'owner')['download_attempt'])
+        .to eq(receipt['download_attempt'])
+    CountsExportJobs.download_attempt(token, 'owner', **arguments, status: 'failed')
+    fresh = CountsExportJobs.download_attempt(token, 'owner')
+    expect(fresh['download_attempt']).not_to eq(receipt['download_attempt'])
     expect(CountsExportJobs.download_attempt(token, 'owner', **arguments)).to be_nil
     CountsExportJobs.status(token, 'owner', cancel: true)
     expect(CountsExportJobs.download_attempt(token, 'owner')).to be_nil
   end
 end
+
+RSpec.describe CountsExportDownload::ResponseBody do
+  it 'acknowledges only after the first Rack yield and closes its bounded file body' do
+    Dir.mktmpdir('counts-body-spec') do |directory|
+      path = File.join(directory, 'file')
+      File.binwrite(path, 'x' * (64 * 1024 + 3))
+      states = []
+      body = described_class.new(path) { |state| states << state; true }
+      chunks = []
+      body.each do |chunk|
+        expect(states).not_to include('started') if chunks.empty?
+        chunks << chunk
+      end
+      expect(chunks.map(&:bytesize)).to eq([64 * 1024, 3])
+      expect(states.count('started')).to eq(1)
+      expect(body).not_to respond_to(:to_path)
+      expect { body.close }.not_to raise_error
+    end
+  end
+
+  it 'records a failed stream without converting an exception into a second HTTP response' do
+    Dir.mktmpdir('counts-body-spec') do |directory|
+      path = File.join(directory, 'file')
+      File.binwrite(path, 'data')
+      states = []
+      body = described_class.new(path) { |state| states << state; true }
+      expect { body.each { raise IOError, 'connection closed' } }.to raise_error(IOError)
+      expect(states).to include('failed')
+      expect(states).not_to include('started')
+      expect { body.close }.not_to raise_error
+    end
+  end
+end