親投稿機能 (#46) (#339)

Merge remote-tracking branch 'origin/main' into feature/046

#46

#46

#46

#46

#46

#46

Co-authored-by: miteruzo <miteruzo@naver.com>
Reviewed-on: #339

backend/app/controllers/nico_tags_controller.rb

@@ -33,8 +33,8 @@ class NicoTagsController < ApplicationController
     return head :bad_request unless tag.nico?
 
     linked_tag_names = params[:tags].to_s.split
-    linked_tags = Tag.normalise_tags(linked_tag_names, with_tagme: false,
-                                                       with_no_deerjikist: false)
+    linked_tags = Tag.normalise_tags!(linked_tag_names, with_tagme: false,
+                                                        with_no_deerjikist: false)
     return head :bad_request if linked_tags.any? { |t| t.nico? }
 
     ApplicationRecord.transaction do

backend/app/controllers/posts_controller.rb

@@ -109,7 +109,7 @@ class PostsController < ApplicationController
 
     render json: PostRepr.base(post, current_user)
                          .merge(tags: build_tag_tree_for(post.tags),
-                                related: post.related(limit: 20))
+                                related: PostRepr.many(post.related(limit: 20)))
   end
 
   def create
@@ -123,28 +123,36 @@ class PostsController < ApplicationController
     tag_names = params[:tags].to_s.split
     original_created_from = params[:original_created_from]
     original_created_before = params[:original_created_before]
+    parent_post_ids = parse_parent_post_ids
 
     post = Post.new(title:, url:, thumbnail_base: nil, uploaded_user: current_user,
                     original_created_from:, original_created_before:)
-    post.thumbnail.attach(thumbnail)
+    post.thumbnail.attach(thumbnail) if thumbnail.present?
 
     ApplicationRecord.transaction do
       post.save!
-      tags = Tag.normalise_tags(tag_names)
+
+      tags = Tag.normalise_tags!(tag_names)
       TagVersioning.record_tag_snapshots!(tags, created_by_user: current_user)
 
       tags = Tag.expand_parent_tags(tags)
       sync_post_tags!(post, tags)
+
+      sync_parent_posts!(post, parent_post_ids)
+
       post.resized_thumbnail!
+
       PostVersionRecorder.record!(post:, event_type: :create, created_by_user: current_user)
     end
 
     post.reload
     render json: PostRepr.base(post), status: :created
-  rescue ActiveRecord::RecordInvalid
-    render json: { errors: post.errors.full_messages }, status: :unprocessable_entity
   rescue Tag::NicoTagNormalisationError
     head :bad_request
+  rescue ArgumentError => e
+    render json: { errors: [e.message] }, status: :unprocessable_entity
+  rescue ActiveRecord::RecordInvalid => e
+    render json: { errors: e.record.errors.full_messages }, status: :unprocessable_entity
   end
 
   def viewed
@@ -169,6 +177,7 @@ class PostsController < ApplicationController
     tag_names = params[:tags].to_s.split
     original_created_from = params[:original_created_from]
     original_created_before = params[:original_created_before]
+    parent_post_ids = parse_parent_post_ids
 
     post = Post.find(params[:id].to_i)
 
@@ -177,12 +186,15 @@ class PostsController < ApplicationController
 
       post.update!(title:, original_created_from:, original_created_before:)
 
-      normalised_tags = Tag.normalise_tags(tag_names, with_tagme: false)
+      normalised_tags = Tag.normalise_tags!(tag_names, with_tagme: false)
       TagVersioning.record_tag_snapshots!(normalised_tags, created_by_user: current_user)
 
       tags = post.tags.nico.to_a + normalised_tags
       tags = Tag.expand_parent_tags(tags)
       sync_post_tags!(post, tags)
+
+      sync_parent_posts!(post, parent_post_ids)
+
       PostVersionRecorder.record!(post:, event_type: :update, created_by_user: current_user)
     end
 
@@ -190,10 +202,12 @@ class PostsController < ApplicationController
     json = post.as_json
     json['tags'] = build_tag_tree_for(post.tags)
     render json:, status: :ok
-  rescue ActiveRecord::RecordInvalid
-    render json: post.errors, status: :unprocessable_entity
   rescue Tag::NicoTagNormalisationError
     head :bad_request
+  rescue ArgumentError => e
+    render json: { errors: [e.message] }, status: :unprocessable_entity
+  rescue ActiveRecord::RecordInvalid => e
+    render json: { errors: e.record.errors.full_messages }, status: :unprocessable_entity
   end
 
   def changes
@@ -353,4 +367,41 @@ class PostsController < ApplicationController
 
     root_ids.filter_map { |id| build_node.call(id, []) }
   end
+
+  def parse_parent_post_ids
+    raise ArgumentError, 'parent_post_ids は必須です．' unless params.key?(:parent_post_ids)
+
+    params[:parent_post_ids].to_s.split.map { |token|
+      id = Integer(token, exception: false)
+      raise ArgumentError, "親投稿 Id. が不正です: #{ token }" if id.nil? || id <= 0
+
+      id
+    }.uniq
+  end
+
+  def sync_parent_posts! post, parent_post_ids
+    if parent_post_ids.include?(post.id)
+      post.errors.add(:base, '自分自身を親投稿にはできません．')
+      raise ActiveRecord::RecordInvalid, post
+    end
+
+    existing_ids = Post.where(id: parent_post_ids).pluck(:id)
+    missing_ids = parent_post_ids - existing_ids
+
+    if missing_ids.present?
+      post.errors.add(:base, "存在しない親投稿 ID があります: #{ missing_ids.join(' ') }")
+      raise ActiveRecord::RecordInvalid, post
+    end
+
+    current_ids = post.parent_posts.pluck(:id)
+
+    ids_to_add = parent_post_ids - current_ids
+    ids_to_remove = current_ids - parent_post_ids
+
+    PostImplication.where(post_id: post.id, parent_post_id: ids_to_remove).delete_all
+
+    ids_to_add.each do |parent_post_id|
+      PostImplication.create_or_find_by!(post_id: post.id, parent_post_id:)
+    end
+  end
 end

backend/app/controllers/tags_controller.rb

@@ -374,9 +374,9 @@ class TagsController < ApplicationController
   end
 
   def update_parent_tags! tag, parent_names
-    parent_tags = Tag.normalise_tags(parent_names, with_tagme: false,
-                                                   with_no_deerjikist: false,
-                                                   deny_nico: true)
+    parent_tags = Tag.normalise_tags!(parent_names, with_tagme: false,
+                                                    with_no_deerjikist: false,
+                                                    deny_nico: true)
 
     old_parent_tags = tag.parents.to_a
 

backend/app/models/post.rb

@@ -1,7 +1,6 @@
 class Post < ApplicationRecord
   require 'mini_magick'
 
-  belongs_to :parent, class_name: 'Post', optional: true, foreign_key: 'parent_id'
   belongs_to :uploaded_user, class_name: 'User', optional: true
 
   has_many :post_tags, dependent: :destroy, inverse_of: :post
@@ -13,6 +12,20 @@ class Post < ApplicationRecord
   has_many :post_similarities, dependent: :delete_all
   has_many :post_versions
 
+  has_many :parent_post_implications,
+           class_name: 'PostImplication',
+           foreign_key: :post_id,
+           dependent: :destroy,
+           inverse_of: :post
+  has_many :parents, through: :parent_post_implications, source: :parent_post
+
+  has_many :child_post_implications,
+           class_name: 'PostImplication',
+           foreign_key: :parent_post_id,
+           dependent: :destroy,
+           inverse_of: :parent_post
+  has_many :children, through: :child_post_implications, source: :post
+
   has_one_attached :thumbnail
 
   before_validation :normalise_url
@@ -22,17 +35,29 @@ class Post < ApplicationRecord
   validate :validate_original_created_range
   validate :url_must_be_http_url
 
+  def parent_posts = parents
+
+  def child_posts = children
+
+  def sibling_posts
+    parent_post_ids = parent_posts.order(:id).pluck(:id)
+
+    parent_post_ids.to_h { [_1, PostImplication.where(parent_post: _1).map(&:post)] }
+  end
+
   def as_json options = { }
-    super(options).merge({ thumbnail: thumbnail.attached? ?
-                                      Rails.application.routes.url_helpers.rails_blob_url(
-                                          thumbnail, only_path: false) :
-                                      nil })
+    super(options).merge(thumbnail: thumbnail.attached? ?
+                                    Rails.application.routes.url_helpers.rails_blob_url(
+                                        thumbnail, only_path: false) :
+                                    nil)
   rescue
     super(options).merge(thumbnail: nil)
   end
 
   def snapshot_tag_names = tags.joins(:tag_name).order('tag_names.name').pluck('tag_names.name')
 
+  def snapshot_parent_post_ids = parents.order(:id).pluck(:id)
+
   def related limit: nil
     ids = post_similarities.order(cos: :desc)
     ids = ids.limit(limit) if limit

backend/app/models/post_implication.rb

@@ -0,0 +1,19 @@
+class PostImplication < ApplicationRecord
+  self.primary_key = :post_id, :parent_post_id
+
+  belongs_to :post, inverse_of: :parent_post_implications
+  belongs_to :parent_post, class_name: 'Post', inverse_of: :child_post_implications
+
+  validates :post_id, presence: true, uniqueness: { scope: :parent_post_id }
+  validates :parent_post_id, presence: true
+
+  validate :parent_post_mustnt_be_itself
+
+  private
+
+  def parent_post_mustnt_be_itself
+    if parent_post_id == post_id
+      errors.add :parent_post_id, '親投稿に同じ投稿を設定することはできません．'
+    end
+  end
+end

backend/app/models/tag.rb

@@ -86,9 +86,9 @@ class Tag < ApplicationRecord
   def self.niconico = find_or_create_by_tag_name!('ニコニコ', category: :meta)
   def self.youtube = find_or_create_by_tag_name!('YouTube', category: :meta)
 
-  def self.normalise_tags tag_names, with_tagme: true,
-                                     with_no_deerjikist: true,
-                                     deny_nico: true
+  def self.normalise_tags! tag_names, with_tagme: true,
+                                      with_no_deerjikist: true,
+                                      deny_nico: true
     if deny_nico && tag_names.any? { |n| n.downcase.start_with?('nico:') }
       raise NicoTagNormalisationError
     end

backend/app/representations/post_repr.rb

@@ -2,7 +2,8 @@
 
 
 module PostRepr
-  BASE = { include: { tags: TagRepr::BASE, uploaded_user: UserRepr::BASE } }.freeze
+  BASE = { include: { tags: TagRepr::BASE, uploaded_user: UserRepr::BASE },
+           methods: [:parent_posts, :child_posts, :sibling_posts] }.freeze
 
   module_function
 

backend/app/services/post_version_recorder.rb

@@ -24,7 +24,7 @@ class PostVersionRecorder < VersionRecorder
       url: @record.url,
       thumbnail_base: @record.thumbnail_base,
       tags: @record.snapshot_tag_names.join(' '),
-      parent_id: @record.parent_id,
+      parent_post_ids: @record.snapshot_parent_post_ids.join(' '),
       original_created_from: @record.original_created_from,
       original_created_before: @record.original_created_before }
   end