#434

backend/spec/requests/counts_spec.rb

@@ -1,6 +1,6 @@
 require 'rails_helper'
 
-RSpec.describe 'Counts API', type: :request do
+RSpec.describe 'Legacy Counts API', type: :request do
   let!(:actor) { create(:user, :member) }
   let!(:post) { create(:post) }
   let!(:tag) { create(:tag, primary_name: 'counts tag', category: :general) }
@@ -28,16 +28,16 @@ RSpec.describe 'Counts API', type: :request do
     context resource do
       let(:path) { "/counts/#{ resource }" }
       let(:id) { resource == 'posts' ? post.id : tag.id }
-      let(:filters) { { resource_id: id, user_id: actor.id,
+      let(:filters) { { resource_id: id, user_id: actor.id, latest: '0',
                        from: '2024-01-01T00:00Z', before: '2024-02-01T00:00Z' } }
 
       it 'uses the same AND filters for SQL totals, groups and details' do
-        get path, params: filters.merge(axis: 'event_type')
+        get path, params: filters.merge(axis: 'month')
         expect(response).to have_http_status(:ok)
         summary = response.parsed_body
         expect(summary['count']).to eq(2)
         expect(summary['groups'].sum { _1['count'] }).to eq(2)
-        expect(summary['groups'].map { _1['key'] }).to eq(['create', 'update'])
+        expect(summary['groups'].map { _1['key'] }).to eq(['2024-01'])
 
         get path, params: filters.merge(mode: 'details')
         expect(response.parsed_body['count']).to eq(2)
@@ -45,16 +45,16 @@ RSpec.describe 'Counts API', type: :request do
       end
 
       it 'paginates details and groups independently from totals' do
-        get path, params: { resource_id: id, mode: 'details', limit: 1, page: 2 }
+        get path, params: { resource_id: id, latest: '0', mode: 'details', limit: 1, page: 2 }
         expect(response.parsed_body['count']).to eq(3)
         expect(response.parsed_body['versions'].sole['version_no']).to eq(2)
-        get path, params: { resource_id: id, axis: 'month', limit: 1, page: 2 }
+        get path, params: { resource_id: id, latest: '0', axis: 'month', limit: 1, page: 2 }
         expect(response.parsed_body['group_count']).to eq(2)
         expect(response.parsed_body['groups'].sole).to include('key' => '2024-02', 'count' => 1)
       end
 
       it 'groups null actors and supports their drill-down filter' do
-        get path, params: { resource_id: id, axis: 'user' }
+        get path, params: { resource_id: id, latest: '0', axis: 'user' }
         expect(response.parsed_body['groups']).to include(
             { 'key' => nil, 'name' => nil, 'count' => 1 })
         get path, params: { resource_id: id, mode: 'details', user_id: 'none' }
@@ -62,7 +62,7 @@ RSpec.describe 'Counts API', type: :request do
       end
 
       it 'uses an inclusive start and exclusive end' do
-        get path, params: { resource_id: id,
+        get path, params: { resource_id: id, latest: '0',
                             from: '2024-01-01T00:00Z', before: '2024-01-02T00:00Z' }
         expect(response.parsed_body['count']).to eq(1)
       end
@@ -88,9 +88,10 @@ RSpec.describe 'Counts API', type: :request do
   end
 
   it 'matches removed tags from the previous snapshot, not current post_tags' do
-    get '/counts/posts', params: { tag: tag.id, mode: 'details' }
+    get '/counts/posts', params: { tag: tag.id, latest: '0', mode: 'details' }
     expect(response.parsed_body['count']).to eq(2)
     expect(response.parsed_body['versions'].map { _1['version_no'] }).to eq([2, 1])
-    expect(response.parsed_body['versions'].first['tags'].sole['type']).to eq('removed')
+    expect(response.parsed_body['versions'].first['tags']).to be_empty
+    expect(response.parsed_body['versions'].last['tags'].sole['id']).to eq(tag.id)
   end
 end