タグ “廃止” 追加 (#378) (#379)

Reviewed-on: #379
Co-authored-by: miteruzo <miteruzo@naver.com>
Co-committed-by: miteruzo <miteruzo@naver.com>

backend/spec/requests/gekanator_learning_spec.rb

@@ -897,6 +897,37 @@ RSpec.describe 'Gekanator learning API', type: :request do
   end
 
   describe 'GET /gekanator/questions' do
+    it 'omits questions for deprecated tags' do
+      active_tag = Tag.create!(name: 'active_question_tag', category: :general)
+      deprecated_tag = Tag.create!(
+        name: 'deprecated_question_tag',
+        category: :general,
+        deprecated_at: Time.current
+      )
+
+      [active_tag, deprecated_tag].each do |question_tag|
+        GekanatorQuestion.create!(
+          text: "#{ question_tag.name }?",
+          kind: 'tag',
+          source: 'admin_curated',
+          status: 'accepted',
+          priority_weight: 1.0,
+          condition: {
+            type: 'tag',
+            key: "#{ question_tag.category }:#{ question_tag.name }"
+          },
+          created_by: admin
+        )
+      end
+
+      get '/gekanator/questions'
+
+      expect(response).to have_http_status(:ok)
+      question_ids = json.fetch('questions').map { |question| question.fetch('id') }
+      expect(question_ids).to include('tag:general:active_question_tag')
+      expect(question_ids).not_to include('tag:general:deprecated_question_tag')
+    end
+
     it 'returns accepted questions only and includes example_answers for post_similarity questions' do
       sign_in_as admin
 

backend/spec/requests/gekanator_posts_spec.rb

@@ -0,0 +1,33 @@
+require 'rails_helper'
+
+
+RSpec.describe 'Gekanator posts API', type: :request do
+  describe 'GET /gekanator/posts' do
+    it 'omits deprecated tags and returns the stored similarity cosine' do
+      active_tag = Tag.create!(name: 'active tag', category: :general)
+      deprecated_tag = Tag.create!(
+        name: 'deprecated tag',
+        category: :general,
+        deprecated_at: Time.current
+      )
+      post_record = Post.create!(title: 'source', url: 'https://example.com/source')
+      target_post = Post.create!(title: 'target', url: 'https://example.com/target')
+
+      PostTag.create!(post: post_record, tag: active_tag)
+      PostTag.create!(post: post_record, tag: deprecated_tag)
+      PostTag.create!(post: target_post, tag: deprecated_tag)
+      PostSimilarity.create!(post: post_record, target_post:, cos: 0.375)
+
+      get '/gekanator/posts'
+
+      expect(response).to have_http_status(:ok)
+
+      post_json = json.fetch('posts').find { |post| post.fetch('id') == post_record.id }
+      expect(post_json.fetch('tags').map { |tag| tag.fetch('name') }).to eq(['active tag'])
+      expect(post_json.fetch('post_similarity_edges')).to contain_exactly(
+        'target_post_id' => target_post.id,
+        'cos' => 0.375
+      )
+    end
+  end
+end

backend/spec/requests/posts_spec.rb

@@ -517,6 +517,24 @@ RSpec.describe 'Posts API', type: :request do
         expect([true, false]).to include(json['viewed'])
       end
 
+      it 'omits deprecated tags' do
+        deprecated_tag = Tag.create!(
+          name: 'deprecated_post_tag',
+          category: :general,
+          deprecated_at: Time.current
+        )
+        PostTag.create!(post: post_record, tag: deprecated_tag)
+
+        request
+
+        expect(response).to have_http_status(:ok)
+        tag_names = json.fetch('tags').flat_map { |node|
+          [node.fetch('name')] + node.fetch('children').map { |child| child.fetch('name') }
+        }
+        expect(tag_names).to include('spec_tag')
+        expect(tag_names).not_to include('deprecated_post_tag')
+      end
+
       context 'when post has parent, child, and sibling posts' do
         let!(:parent_post) do
           create_parent_post!(
@@ -697,6 +715,58 @@ RSpec.describe 'Posts API', type: :request do
       expect(names).not_to include('manko')
     end
 
+    it 'rejects a deprecated tag specified directly' do
+      Tag.create!(
+        name: 'deprecated_direct_tag',
+        category: :general,
+        deprecated_at: Time.current
+      )
+      sign_in_as(member)
+
+      post '/posts', params: post_write_params(
+        title: 'new post',
+        url: 'https://example.com/deprecated-direct-tag',
+        tags: 'deprecated_direct_tag',
+        thumbnail: dummy_upload
+      )
+
+      expect(response).to have_http_status(:unprocessable_entity)
+      expect(json.fetch('errors')).to include(
+        'tags' => ['廃止済みタグは付与できません．']
+      )
+    end
+
+    it 'expands through multiple deprecated parent tags and saves active ancestors' do
+      child = Tag.create!(name: 'active_child', category: :general)
+      deprecated_parent = Tag.create!(
+        name: 'deprecated_parent',
+        category: :general,
+        deprecated_at: Time.current
+      )
+      deprecated_grandparent = Tag.create!(
+        name: 'deprecated_grandparent',
+        category: :general,
+        deprecated_at: Time.current
+      )
+      active_grandparent = Tag.create!(name: 'active_grandparent', category: :general)
+      TagImplication.create!(tag: child, parent_tag: deprecated_parent)
+      TagImplication.create!(tag: deprecated_parent, parent_tag: deprecated_grandparent)
+      TagImplication.create!(tag: deprecated_grandparent, parent_tag: active_grandparent)
+      sign_in_as(member)
+
+      post '/posts', params: post_write_params(
+        title: 'expanded post',
+        url: 'https://example.com/expanded-deprecated-parent',
+        tags: 'active_child',
+        thumbnail: dummy_upload
+      )
+
+      expect(response).to have_http_status(:created)
+      saved_names = Post.find(json.fetch('id')).tags.map(&:name)
+      expect(saved_names).to include('active_child', 'active_grandparent')
+      expect(saved_names).not_to include('deprecated_parent', 'deprecated_grandparent')
+    end
+
     context "when nico tag already exists in tags" do
       before do
         Tag.find_undiscard_or_create_by!(
@@ -930,6 +1000,26 @@ RSpec.describe 'Posts API', type: :request do
       expect(names).to include('spec_tag_2')
     end
 
+    it 'rejects a deprecated tag specified directly' do
+      Tag.create!(
+        name: 'deprecated_update_tag',
+        category: :general,
+        deprecated_at: Time.current
+      )
+      sign_in_as(member)
+
+      put "/posts/#{ post_record.id }", params: post_update_params(
+        post_record,
+        title: 'updated title',
+        tags: 'deprecated_update_tag'
+      )
+
+      expect(response).to have_http_status(:unprocessable_entity)
+      expect(json.fetch('errors')).to include(
+        'tags' => ['廃止済みタグは付与できません．']
+      )
+    end
+
     context "when nico tag already exists in tags" do
       before do
         Tag.find_undiscard_or_create_by!(

backend/spec/requests/tag_versions_spec.rb

@@ -21,6 +21,7 @@ RSpec.describe 'TagVersions API', type: :request do
     event_type:,
     name:,
     category:,
+    deprecated_at: nil,
     aliases: [],
     parent_tags: [],
     created_by_user:,
@@ -33,6 +34,7 @@ RSpec.describe 'TagVersions API', type: :request do
             event_type: event_type,
             name: name,
             category: category,
+            deprecated_at: deprecated_at,
             aliases: Array(aliases).join(' '),
             parent_tag_ids: Array(parent_tags).map(&:id).join(' '),
             created_by_user: created_by_user,
@@ -65,6 +67,7 @@ RSpec.describe 'TagVersions API', type: :request do
       event_type: 'update',
       name: 'new_tag_name',
       category: 'meme',
+      deprecated_at: t_v2,
       aliases: ['alias_shared', 'alias_new'],
       parent_tags: [parent_shared, parent_new],
       created_by_user: member,
@@ -133,6 +136,10 @@ RSpec.describe 'TagVersions API', type: :request do
         'current' => 'meme',
         'prev' => 'general'
       )
+      expect(latest.fetch('deprecated_at')).to eq(
+        'current' => t_v2.iso8601,
+        'prev' => nil
+      )
       expect(latest.fetch('aliases')).to include(
         { 'name' => 'alias_shared', 'type' => 'context' },
         { 'name' => 'alias_new', 'type' => 'added' },
@@ -178,6 +185,10 @@ RSpec.describe 'TagVersions API', type: :request do
         'current' => 'general',
         'prev' => nil
       )
+      expect(first.fetch('deprecated_at')).to eq(
+        'current' => nil,
+        'prev' => nil
+      )
       expect(first.fetch('aliases')).to include(
         { 'name' => 'alias_shared', 'type' => 'added' },
         { 'name' => 'alias_old', 'type' => 'added' }

backend/spec/requests/tag_wiki_history_integrity_spec.rb

@@ -89,6 +89,7 @@ RSpec.describe 'Tag and wiki history integrity', type: :request do
           category: 'general',
           aliases: '',
           parent_tags: '',
+          deprecated: '0',
         }
       }
           .to change(TagVersion, :count).by(2)
@@ -123,6 +124,7 @@ RSpec.describe 'Tag and wiki history integrity', type: :request do
           category: 'meme',
           aliases: '',
           parent_tags: '',
+          deprecated: '0',
         }
       }
           .to change(TagVersion, :count).by(2)
@@ -149,6 +151,7 @@ RSpec.describe 'Tag and wiki history integrity', type: :request do
           category: 'general',
           aliases: 'put_tag_alias_only_alias',
           parent_tags: '',
+          deprecated: '0',
         }
       }
           .to change(TagVersion, :count).by(2)

backend/spec/requests/tags_spec.rb

@@ -76,6 +76,27 @@ RSpec.describe 'Tags API', type: :request do
       expect(response_tags.first['id']).to eq(meme.id)
     end
 
+    it 'filters tags by deprecated state' do
+      deprecated_tag = Tag.create!(
+        name: 'deprecated_filter',
+        category: :general,
+        deprecated_at: 1.day.from_now
+      )
+      active_tag = Tag.create!(name: 'active_filter', category: :general)
+
+      get '/tags', params: { name: '_filter', deprecated: '1' }
+
+      expect(response).to have_http_status(:ok)
+      expect(response_names).to include(deprecated_tag.name)
+      expect(response_names).not_to include(active_tag.name)
+
+      get '/tags', params: { name: '_filter', deprecated: '0' }
+
+      expect(response).to have_http_status(:ok)
+      expect(response_names).to include(active_tag.name)
+      expect(response_names).not_to include(deprecated_tag.name)
+    end
+
     it 'filters tags by post_count range' do
       low = Tag.create!(tag_name: TagName.create!(name: 'pc_low'), category: :general)
       mid = Tag.create!(tag_name: TagName.create!(name: 'pc_mid'), category: :general)
@@ -301,6 +322,21 @@ RSpec.describe 'Tags API', type: :request do
       expect(t['matched_alias']).to eq('unko')
       expect(json.map { |x| x['name'] }).not_to include('unknown')
     end
+
+    it 'omits deprecated tags' do
+      deprecated_tag = Tag.create!(
+        name: 'spec_deprecated',
+        category: :general,
+        deprecated_at: Time.current
+      )
+      deprecated_tag.update_columns(post_count: 1)
+
+      get '/tags/autocomplete', params: { q: 'spec_', present: '0' }
+
+      expect(response).to have_http_status(:ok)
+      expect(json.map { |item| item.fetch('name') }).to include('spec_tag')
+      expect(json.map { |item| item.fetch('name') }).not_to include('spec_deprecated')
+    end
   end
 
   describe 'GET /tags/name/:name' do
@@ -437,6 +473,32 @@ RSpec.describe 'Tags API', type: :request do
         expect(versions.second.created_by_user_id).to eq(member_user.id)
       end
 
+      it 'updates deprecated state and records it in tag versions' do
+        expect {
+          patch "/tags/#{ tag.id }", params: { deprecated: '1' }
+        }.to change(TagVersion, :count).by(2)
+
+        expect(response).to have_http_status(:ok)
+        expect(tag.reload.deprecated_at).to be_present
+
+        versions = tag.tag_versions.order(:version_no)
+        expect(versions.first.deprecated_at).to be_nil
+        expect(versions.second.deprecated_at).to eq(tag.deprecated_at)
+        expect(json.fetch('deprecated_at')).to be_present
+      end
+
+      it 'rejects deprecating a nico tag' do
+        nico_tag = Tag.create!(name: 'nico:deprecated_update', category: :nico)
+
+        patch "/tags/#{ nico_tag.id }", params: { deprecated: '1' }
+
+        expect(response).to have_http_status(:unprocessable_entity)
+        expect(nico_tag.reload.deprecated_at).to be_nil
+        expect(json.fetch('errors')).to include(
+          'deprecated' => ['ニコタグは廃止できません．']
+        )
+      end
+
       it 'returns 422 when changing normal tag category to nico' do
         expect {
           patch "/tags/#{tag.id}", params: { category: 'nico' }
@@ -585,6 +647,111 @@ RSpec.describe 'Tags API', type: :request do
       expect(row['has_children']).to eq(true)
       expect(row['children']).to eq([])
     end
+
+    it 'passes through deprecated tags when finding children' do
+      deprecated_middle = Tag.create!(
+        name: 'depth_deprecated_middle',
+        category: :character,
+        deprecated_at: Time.current
+      )
+      visible_descendant = Tag.create!(
+        name: 'depth_visible_descendant',
+        category: :material
+      )
+      TagImplication.create!(parent_tag: root_material, tag: deprecated_middle)
+      TagImplication.create!(parent_tag: deprecated_middle, tag: visible_descendant)
+
+      get '/tags/with-depth', params: { parent: root_material.id }
+
+      expect(response).to have_http_status(:ok)
+      expect(json.map { |item| item.fetch('name') }).to eq(['depth_visible_descendant'])
+      expect(json.map { |item| item.fetch('name') }).not_to include('depth_deprecated_middle')
+    end
+
+    it 'passes through multiple deprecated tags for roots and has_children' do
+      active_child = Tag.create!(
+        name: 'depth_active_child_below_deprecated',
+        category: :character
+      )
+      deprecated_parent = Tag.create!(
+        name: 'depth_deprecated_parent',
+        category: :character,
+        deprecated_at: Time.current
+      )
+      deprecated_grandparent = Tag.create!(
+        name: 'depth_deprecated_grandparent',
+        category: :material,
+        deprecated_at: Time.current
+      )
+      active_ancestor = Tag.create!(
+        name: 'depth_active_ancestor',
+        category: :meme
+      )
+      TagImplication.create!(tag: active_child, parent_tag: deprecated_parent)
+      TagImplication.create!(tag: deprecated_parent, parent_tag: deprecated_grandparent)
+      TagImplication.create!(tag: deprecated_grandparent, parent_tag: active_ancestor)
+
+      get '/tags/with-depth'
+
+      root_names = json.map { |item| item.fetch('name') }
+      expect(root_names).to include('depth_active_ancestor')
+      expect(root_names).not_to include('depth_active_child_below_deprecated')
+      ancestor_json = json.find { |item| item.fetch('id') == active_ancestor.id }
+      expect(ancestor_json.fetch('has_children')).to eq(true)
+
+      get '/tags/with-depth', params: { parent: active_ancestor.id }
+
+      expect(json.map { |item| item.fetch('name') }).to include(
+        'depth_active_child_below_deprecated'
+      )
+      expect(json.map { |item| item.fetch('name') }).not_to include(
+        'depth_deprecated_parent',
+        'depth_deprecated_grandparent'
+      )
+    end
+
+    it 'treats an active tag with only deprecated ancestors as a root' do
+      active_child = Tag.create!(
+        name: 'depth_root_below_deprecated',
+        category: :character
+      )
+      deprecated_parent = Tag.create!(
+        name: 'depth_root_deprecated_parent',
+        category: :material,
+        deprecated_at: Time.current
+      )
+      TagImplication.create!(tag: active_child, parent_tag: deprecated_parent)
+
+      get '/tags/with-depth'
+
+      expect(json.map { |item| item.fetch('name') }).to include(
+        'depth_root_below_deprecated'
+      )
+      expect(json.map { |item| item.fetch('name') }).not_to include(
+        'depth_root_deprecated_parent'
+      )
+    end
+
+    it 'terminates when deprecated implications contain a cycle' do
+      first = Tag.create!(
+        name: 'depth_cycle_first',
+        category: :character,
+        deprecated_at: Time.current
+      )
+      second = Tag.create!(
+        name: 'depth_cycle_second',
+        category: :material,
+        deprecated_at: Time.current
+      )
+      TagImplication.create!(tag: first, parent_tag: root_material)
+      TagImplication.create!(tag: second, parent_tag: first)
+      TagImplication.create!(tag: first, parent_tag: second)
+
+      get '/tags/with-depth', params: { parent: root_material.id }
+
+      expect(response).to have_http_status(:ok)
+      expect(json).to eq([])
+    end
   end
 
   describe 'GET /tags/name/:name/materials' do
@@ -732,6 +899,20 @@ RSpec.describe 'Tags API', type: :request do
         expect(tag.category).to eq('general')
       end
 
+      it 'deprecated がなければ 422 を返す' do
+        put "/tags/#{ tag.id }", params: {
+          name: 'new',
+          category: 'general',
+          aliases: '',
+          parent_tags: '',
+        }
+
+        expect(response).to have_http_status(:unprocessable_entity)
+        expect(json.fetch('errors')).to include(
+          'deprecated' => ['廃止状態は必須です．']
+        )
+      end
+
       it 'name, category, aliases, parent tags をまとめて更新できる' do
         old_parent = Tag.create!(
           tag_name: TagName.create!(name: 'put_old_parent'),
@@ -749,6 +930,7 @@ RSpec.describe 'Tags API', type: :request do
           category: 'meme',
           aliases: 'put_alias_a put_alias_b put_alias_a',
           parent_tags: 'put_kept_parent put_new_parent',
+          deprecated: '0',
         }
 
         expect(response).to have_http_status(:ok)
@@ -793,6 +975,7 @@ RSpec.describe 'Tags API', type: :request do
           category: 'general',
           aliases: 'spec_tag put_alias_self_test',
           parent_tags: '',
+          deprecated: '0',
         }
 
         expect(response).to have_http_status(:ok)
@@ -810,6 +993,7 @@ RSpec.describe 'Tags API', type: :request do
           category: 'general',
           aliases: 'unko',
           parent_tags: 'spec_tag',
+          deprecated: '0',
         }
 
         expect(response).to have_http_status(:ok)
@@ -825,6 +1009,7 @@ RSpec.describe 'Tags API', type: :request do
             category: 'meta',
             aliases: '',
             parent_tags: '',
+            deprecated: '0',
           }
         }.to change(TagVersion, :count).by(2)
 
@@ -860,6 +1045,7 @@ RSpec.describe 'Tags API', type: :request do
           category: 'general',
           aliases: 'unko',
           parent_tags: new_parent.name,
+          deprecated: '0',
         }
 
         expect(response).to have_http_status(:ok)
@@ -875,6 +1061,7 @@ RSpec.describe 'Tags API', type: :request do
             category: 'nico',
             aliases: '',
             parent_tags: '',
+            deprecated: '0',
           }
         }.not_to change(TagVersion, :count)
 
@@ -896,6 +1083,7 @@ RSpec.describe 'Tags API', type: :request do
             category: 'nico',
             aliases: '',
             parent_tags: '',
+            deprecated: '0',
           }
         }.not_to change(NicoTagVersion, :count)
 
@@ -916,6 +1104,7 @@ RSpec.describe 'Tags API', type: :request do
             category: old_category,
             aliases: '',
             parent_tags: '',
+            deprecated: '0',
           }
         }.not_to change(TagVersion, :count)
 
@@ -946,6 +1135,7 @@ RSpec.describe 'Tags API', type: :request do
             category: 'meme',
             aliases: 'unko',
             parent_tags: '',
+            deprecated: '0',
           }
         }
             .to change(TagVersion, :count).by(2)
@@ -981,6 +1171,7 @@ RSpec.describe 'Tags API', type: :request do
             category: 'general',
             aliases: 'unko put_stolen_alias',
             parent_tags: '',
+            deprecated: '0',
           }
         }
             .to change { tag.reload.tag_versions.count }.by(2)
@@ -1015,6 +1206,7 @@ RSpec.describe 'Tags API', type: :request do
           category: 'general',
           aliases: 'unko',
           parent_tags: child.name,
+          deprecated: '0',
         }
 
         expect(response).to have_http_status(:unprocessable_entity)
@@ -1036,6 +1228,7 @@ RSpec.describe 'Tags API', type: :request do
             category: 'general',
             aliases: 'unko',
             parent_tags: '',
+            deprecated: '0',
           }
         }
             .to change(TagVersion, :count).by(2)

backend/spec/requests/wiki_spec.rb

@@ -18,6 +18,13 @@ RSpec.describe 'Wiki API', type: :request do
         created_by_user: user,
         message: 'init')
   end
+  let!(:tag) do
+    Tag.create!(
+      tag_name: tn,
+      category: :general,
+      deprecated_at: Time.zone.local(2026, 6, 1)
+    )
+  end
 
   describe 'GET /wiki' do
     it 'returns wiki pages with title' do
@@ -30,6 +37,8 @@ RSpec.describe 'Wiki API', type: :request do
 
       expect(json[0]).to have_key('title')
       expect(json.map { |p| p['title'] }).to include('spec_wiki_title')
+      wiki_json = json.find { |item| item.fetch('id') == page.id }
+      expect(wiki_json.fetch('deprecated_at')).to eq(tag.deprecated_at.iso8601(3))
     end
   end
 
@@ -48,7 +57,8 @@ RSpec.describe 'Wiki API', type: :request do
 
         expect(json).to include(
             'id' => page.id,
-            'title' => 'spec_wiki_title')
+            'title' => 'spec_wiki_title',
+            'deprecated_at' => tag.deprecated_at.iso8601(3))
       end
     end
 
@@ -409,7 +419,11 @@ RSpec.describe 'Wiki API', type: :request do
         'kind' => 'content',
         'message' => 'r2'
       )
-      expect(top['wiki_page']).to include('id' => page.id, 'title' => 'spec_wiki_title')
+      expect(top['wiki_page']).to include(
+        'id' => page.id,
+        'title' => 'spec_wiki_title',
+        'deprecated_at' => tag.deprecated_at.iso8601(3)
+      )
       expect(top['user']).to include('id' => user.id, 'name' => user.name)
       expect(top).to have_key('timestamp')
 
@@ -479,6 +493,7 @@ RSpec.describe 'Wiki API', type: :request do
       expect(json).to include(
         'wiki_page_id' => page.id,
         'title' => 'spec_wiki_title',
+        'deprecated_at' => tag.deprecated_at.iso8601(3),
         'older_revision_id' => rev_a.id,
         'newer_revision_id' => rev_b.id
       )