Merge remote-tracking branch 'origin/main' into feature/047

backend/spec/models/post_version_spec.rb

@@ -0,0 +1,40 @@
+require 'rails_helper'
+
+RSpec.describe PostVersion, type: :model do
+  let!(:tag_name) { TagName.create!(name: 'post_version_spec_tag') }
+  let!(:tag) { Tag.create!(tag_name: tag_name, category: :general) }
+
+  let!(:post_record) do
+    Post.create!(title: 'spec post', url: 'https://example.com/post-version-spec').tap do |post|
+      PostTag.create!(post: post, tag: tag)
+    end
+  end
+
+  let!(:post_version) do
+    PostVersion.create!(
+      post: post_record,
+      version_no: 1,
+      event_type: 'create',
+      title: post_record.title,
+      url: post_record.url,
+      thumbnail_base: post_record.thumbnail_base,
+      tags: post_record.snapshot_tag_names.join(' '),
+      original_created_from: post_record.original_created_from,
+      original_created_before: post_record.original_created_before,
+      created_at: Time.current,
+      created_by_user: nil
+    )
+  end
+
+  it 'is read only after create' do
+    expect do
+      post_version.update!(title: 'changed')
+    end.to raise_error(ActiveRecord::ReadOnlyRecord)
+  end
+
+  it 'cannot be destroyed' do
+    expect do
+      post_version.destroy!
+    end.to raise_error(ActiveRecord::ReadOnlyRecord)
+  end
+end

backend/spec/models/tag_spec.rb

@@ -107,11 +107,13 @@ RSpec.describe Tag, type: :model do
     context 'when the source tag_name has a wiki_page' do
       let!(:source_post_tag) { PostTag.create!(post: post_record, tag: source_tag) }
       let!(:wiki_page) do
-        WikiPage.create!(
-          tag_name: source_tag_name,
-          created_user: create_admin_user!,
-          updated_user: create_admin_user!
-        )
+        admin = create_admin_user!
+
+        Wiki::Commit.create_content!(
+            tag_name: source_tag_name,
+            body: 'source wiki body',
+            created_by_user: admin,
+            message: 'init')
       end
 
       it 'rolls back the transaction' do
@@ -145,5 +147,69 @@ RSpec.describe Tag, type: :model do
         expect(target_tag.reload.post_count).to eq(0)
       end
     end
+
+    def snapshot_tags(post)
+      post.snapshot_tag_names.join(' ')
+    end
+
+    def create_post_version_for!(post, version_no: 1, event_type: 'create', created_by_user: nil)
+      PostVersion.create!(
+        post: post,
+        version_no: version_no,
+        event_type: event_type,
+        title: post.title,
+        url: post.url,
+        thumbnail_base: post.thumbnail_base,
+        tags: snapshot_tags(post),
+        original_created_from: post.original_created_from,
+        original_created_before: post.original_created_before,
+        created_at: Time.current,
+        created_by_user: created_by_user
+      )
+    end
+
+    context 'when post versions are enabled' do
+      let!(:source_post_tag) { PostTag.create!(post: post_record, tag: source_tag) }
+      let!(:unaffected_post) do
+        Post.create!(url: 'https://example.com/posts/2', title: 'unaffected post')
+      end
+
+      before do
+        create_post_version_for!(post_record)
+        create_post_version_for!(unaffected_post)
+      end
+
+      it 'creates an update post_version only for affected posts' do
+        expect {
+          described_class.merge_tags!(target_tag, [source_tag])
+        }.to change(PostVersion, :count).by(1)
+
+        affected_versions = post_record.reload.post_versions.order(:version_no)
+        expect(affected_versions.pluck(:version_no)).to eq([1, 2])
+
+        latest = affected_versions.last
+        expect(latest.event_type).to eq('update')
+        expect(latest.created_by_user).to be_nil
+        expect(latest.tags).to eq(snapshot_tags(post_record.reload))
+
+        expect(unaffected_post.reload.post_versions.count).to eq(1)
+      end
+    end
+
+    context 'when the source tag has no active post_tags' do
+      let!(:another_post) do
+        Post.create!(url: 'https://example.com/posts/3', title: 'another post')
+      end
+
+      before do
+        create_post_version_for!(another_post)
+      end
+
+      it 'does not create any post_version' do
+        expect {
+          described_class.merge_tags!(target_tag, [source_tag])
+        }.not_to change(PostVersion, :count)
+      end
+    end
   end
 end

backend/spec/models/version_record_spec.rb

@@ -0,0 +1,74 @@
+require 'rails_helper'
+
+RSpec.describe VersionRecord, type: :model do
+  let!(:tag) { create(:tag, name: 'version_record_tag') }
+  let!(:nico_tag) { create(:tag, :nico, name: 'nico:version_record_tag') }
+
+  it 'makes TagVersion read only after create' do
+    version = TagVersion.create!(
+      tag: tag,
+      version_no: 1,
+      event_type: 'create',
+      name: tag.name,
+      category: tag.category,
+      aliases: '',
+      parent_tag_ids: '',
+      created_at: Time.current,
+      created_by_user: nil
+    )
+
+    expect {
+      version.update!(name: 'changed')
+    }.to raise_error(ActiveRecord::ReadOnlyRecord)
+  end
+
+  it 'prevents TagVersion destroy' do
+    version = TagVersion.create!(
+      tag: tag,
+      version_no: 1,
+      event_type: 'create',
+      name: tag.name,
+      category: tag.category,
+      aliases: '',
+      parent_tag_ids: '',
+      created_at: Time.current,
+      created_by_user: nil
+    )
+
+    expect {
+      version.destroy!
+    }.to raise_error(ActiveRecord::ReadOnlyRecord)
+  end
+
+  it 'makes NicoTagVersion read only after create' do
+    version = NicoTagVersion.create!(
+      tag: nico_tag,
+      version_no: 1,
+      event_type: 'create',
+      name: nico_tag.name,
+      linked_tags: '',
+      created_at: Time.current,
+      created_by_user: nil
+    )
+
+    expect {
+      version.update!(name: 'nico:changed')
+    }.to raise_error(ActiveRecord::ReadOnlyRecord)
+  end
+
+  it 'prevents NicoTagVersion destroy' do
+    version = NicoTagVersion.create!(
+      tag: nico_tag,
+      version_no: 1,
+      event_type: 'create',
+      name: nico_tag.name,
+      linked_tags: '',
+      created_at: Time.current,
+      created_by_user: nil
+    )
+
+    expect {
+      version.destroy!
+    }.to raise_error(ActiveRecord::ReadOnlyRecord)
+  end
+end