外部タグを分離 (#419) (#420)

**本番 DB のバックアップをかならずすること**

Reviewed-on: #420
Co-authored-by: miteruzo <miteruzo@naver.com>

backend/app/models/external_tag.rb

@@ -0,0 +1,20 @@
+class ExternalTag < ApplicationRecord
+  enum :platform, nico: 'nico'
+  validates :platform, presence: true, inclusion: { in: ExternalTag.platforms.keys }
+
+  has_many :post_external_tags, dependent: :delete_all
+  has_many :posts, through: :post_external_tags
+
+  has_many :nico_tag_versions, foreign_key: :tag_id, inverse_of: :external_tag
+
+  has_many :nico_tag_relations,
+           foreign_key: :nico_tag_id,
+           inverse_of: :nico_tag,
+           dependent: :destroy
+
+  has_many :linked_tags, through: :nico_tag_relations, source: :tag
+
+  def snapshot_linked_tag_names
+    linked_tags.joins(:tag_name).order('tag_names.name').pluck('tag_names.name')
+  end
+end

backend/app/models/nico_tag_relation.rb

@@ -1,24 +1,10 @@
 class NicoTagRelation < ApplicationRecord
-  belongs_to :nico_tag, class_name: 'Tag'
-  belongs_to :tag, class_name: 'Tag'
+  belongs_to :nico_tag,
+             class_name: 'ExternalTag',
+             foreign_key: :nico_tag_id,
+             inverse_of: :nico_tag_relations
+  belongs_to :tag, class_name: 'Tag', foreign_key: :tag_id
 
   validates :nico_tag_id, presence: true
   validates :tag_id, presence: true
-
-  validate :nico_tag_must_be_nico
-  validate :tag_mustnt_be_nico
-
-  private
-
-  def nico_tag_must_be_nico
-    if nico_tag && nico_tag.category != 'nico'
-      errors.add :nico_tag_id, 'タグのカテゴリがニコニコである必要があります．'
-    end
-  end
-
-  def tag_mustnt_be_nico
-    if tag && tag.category == 'nico'
-      errors.add :tag_id, '連携先タグのカテゴリはニコニコであってはなりません．'
-    end
-  end
 end

backend/app/models/nico_tag_version.rb

@@ -1,7 +1,7 @@
 class NicoTagVersion < ApplicationRecord
   include VersionRecord
 
-  belongs_to :tag
+  belongs_to :external_tag, foreign_key: :tag_id, inverse_of: :nico_tag_versions
 
   validates :name, presence: true
 end

backend/app/models/post.rb

@@ -92,6 +92,9 @@ class Post < ApplicationRecord
            inverse_of: :parent_post
   has_many :children, through: :child_post_implications, source: :post
 
+  has_many :post_external_tags, dependent: :destroy
+  has_many :external_tags, through: :post_external_tags
+
   has_one_attached :thumbnail
 
   attribute :version_no, :integer, default: 1
@@ -150,19 +153,27 @@ class Post < ApplicationRecord
   end
 
   def snapshot_tags_json
-    post_tags
-        .joins(tag: :tag_name)
-        .includes(:sections, tag: :tag_name)
-        .order('tags.id')
-        .map do |pt|
-      { 'id' => pt.tag.id,
-        'version_no' => pt.tag.version_no,
-        'name' => pt.tag.name,
-        'category' => pt.tag.category,
-        'sections' => pt.sections.sort_by(&:begin_ms).map {
-          { 'begin_ms' => _1.begin_ms, 'end_ms' => _1.end_ms }
-        } }
-    end
+    tag_snapshots =
+        post_tags
+            .joins(tag: :tag_name)
+            .includes(:sections, tag: :tag_name)
+            .order('tags.id')
+            .map { |pt|
+          { 'tag_id' => pt.tag.id,
+            'version_no' => pt.tag.version_no,
+            'name' => pt.tag.name,
+            'category' => pt.tag.category,
+            'sections' => pt.sections.sort_by(&:begin_ms).map {
+                            { 'begin_ms' => _1.begin_ms, 'end_ms' => _1.end_ms }
+                          } }
+        }
+
+    external_tag_snapshots =
+        post_external_tags.order(:external_tag_id).map {
+          { 'external_tag_id' => _1.external_tag_id }
+        }
+
+    tag_snapshots + external_tag_snapshots
   end
 
   def self.section_literal section

backend/app/models/post_external_tag.rb

@@ -0,0 +1,4 @@
+class PostExternalTag < ApplicationRecord
+  belongs_to :post
+  belongs_to :external_tag, counter_cache: :post_count
+end

backend/app/models/tag.rb

@@ -28,11 +28,10 @@ class Tag < ApplicationRecord
   has_many :post_tags, inverse_of: :tag
   has_many :posts, through: :post_tags
 
-  has_many :nico_tag_relations, foreign_key: :nico_tag_id, dependent: :destroy
-  has_many :linked_tags, through: :nico_tag_relations, source: :tag
-
   has_many :reversed_nico_tag_relations,
-           class_name: 'NicoTagRelation', foreign_key: :tag_id, dependent: :destroy
+           class_name: 'NicoTagRelation',
+           foreign_key: :tag_id,
+           dependent: :destroy
   has_many :linked_nico_tags, through: :reversed_nico_tag_relations, source: :nico_tag
 
   has_many :tag_implications, foreign_key: :parent_tag_id, dependent: :destroy
@@ -50,7 +49,6 @@ class Tag < ApplicationRecord
   has_many :materials
 
   has_many :tag_versions
-  has_many :nico_tag_versions
 
   belongs_to :tag_name
   delegate :wiki_page, to: :tag_name
@@ -65,17 +63,13 @@ class Tag < ApplicationRecord
                   character:   'character',
                   general:     'general',
                   material:    'material',
-                  nico:        'nico',
                   meta:        'meta'
 
   validates :category, presence: true, inclusion: { in: Tag.categories.keys }
 
-  validate :nico_tag_name_must_start_with_nico
+  validate :tag_name_mustnt_start_with_nico
   validate :tag_name_must_be_canonical
   validate :category_must_be_deerjikist_with_deerjikists
-  validate :nico_tags_cannot_be_deprecated
-
-  scope :nico_tags, -> { nico }
 
   CATEGORY_PREFIXES = {
       'general:'    => :general,
@@ -110,10 +104,9 @@ class Tag < ApplicationRecord
 
   def self.normalise_tags! tag_names, with_tagme: true,
                                       with_no_deerjikist: true,
-                                      deny_nico: true,
                                       deny_deprecated: false,
                                       with_sections: false
-    if deny_nico && tag_names.any? { |n| n.downcase.start_with?('nico:') }
+    if tag_names.any? { |n| n.downcase.start_with?('nico:') }
       raise NicoTagNormalisationError
     end
 
@@ -273,12 +266,8 @@ class Tag < ApplicationRecord
         TagVersioning.record!(source_tag, event_type: :discard, created_by_user:)
         source_tag.destroy!
 
-        if source_tag.nico?
-          source_tag_name.destroy!
-        else
-          source_tag_name.update_columns(canonical_id: target_tag.tag_name_id,
-                                         updated_at: Time.current)
-        end
+        source_tag_name.update_columns(canonical_id: target_tag.tag_name_id,
+                                       updated_at: Time.current)
 
         TagVersioning.record!(target_tag, event_type: :update, created_by_user:)
       end
@@ -305,11 +294,9 @@ class Tag < ApplicationRecord
 
   private
 
-  def nico_tag_name_must_start_with_nico
-    n = name.to_s
-    if ((nico? && !(n.downcase.start_with?('nico:'))) || 
-        (!(nico?) && n.downcase.start_with?('nico:')))
-      errors.add :name, 'ニコニコ・タグの命名規則に反してゐます．'
+  def tag_name_mustnt_start_with_nico
+    if name.to_s.downcase.start_with?('nico:')
+      errors.add :name, 'タグの命名規則に反してゐます．'
     end
   end
 
@@ -350,10 +337,4 @@ class Tag < ApplicationRecord
 
     total_s * 1_000 + match[:ms].to_s.ljust(3, '0')[0, 3].to_i
   end
-
-  def nico_tags_cannot_be_deprecated
-    if nico? && deprecated_at.present?
-      errors.add :deprecated_at, 'ニコタグは廃止できません．'
-    end
-  end
 end

backend/app/models/tag_name_sanitisation_rule.rb

@@ -10,8 +10,9 @@ class TagNameSanitisationRule < ApplicationRecord
   validate :source_pattern_must_be_regexp
 
   class << self
-    def sanitise(name) =
-        rules.reduce(name.dup) { |name, (pattern, replacement)| name.gsub(pattern, replacement) }
+    def sanitise(name)
+      rules.reduce(name.dup) { |name, (pattern, replacement)| name.gsub(pattern, replacement) }
+    end
 
     def apply!
       TagName.find_each do |tn|