#399

backend/app/services/preview/thumbnail_fetcher.rb

@@ -25,6 +25,22 @@ module Preview
       fetch_image!(metadata[:image_url])
     end
 
+    def self.fetch_image_response(raw_url)
+      uri, = UrlSafety.validate(raw_url)
+      response = HttpFetcher.fetch(uri.to_s)
+      unless allowed_image_content_type?(response.content_type)
+        raise GenerationFailed, 'サムネール画像が見つかりませんでした．'
+      end
+
+      response
+    rescue HttpFetcher::FetchTimeout
+      raise
+    rescue HttpFetcher::ResponseTooLarge
+      raise
+    rescue HttpFetcher::FetchFailed
+      raise GenerationFailed, 'サムネール画像を取得できませんでした．'
+    end
+
     def self.title(raw_url)
       uri, = UrlSafety.validate(raw_url)
       HtmlMetadataExtractor.extract(
@@ -45,18 +61,7 @@ module Preview
     end
 
     def self.fetch_image!(url)
-      response = HttpFetcher.fetch(url)
-      unless allowed_image_content_type?(response.content_type)
-        raise GenerationFailed, 'サムネール画像が見つかりませんでした．'
-      end
-
-      response.body
-    rescue HttpFetcher::FetchTimeout
-      raise
-    rescue HttpFetcher::ResponseTooLarge
-      raise
-    rescue HttpFetcher::FetchFailed
-      raise GenerationFailed, 'サムネール画像を取得できませんでした．'
+      fetch_image_response(url).body
     end
 
     def self.niconico_thumbnail_url(uri)
@@ -70,16 +75,20 @@ module Preview
 
       xml.at_xpath('//thumbnail_url')&.text&.strip.presence
     rescue HttpFetcher::FetchFailed, HttpFetcher::FetchTimeout => e
-      Rails.logger.info("preview_niconico_getthumbinfo_fallback #{ { url: uri.to_s,
-                                                                     video_id:,
-                                                                     error: e.class.name,
-                                                                     message: e.message }.to_json }")
+      payload = {
+          url: uri.to_s,
+          video_id:,
+          error: e.class.name,
+          message: e.message }
+      Rails.logger.info("preview_niconico_getthumbinfo_fallback #{ payload.to_json }")
       nil
     rescue Nokogiri::XML::SyntaxError => e
-      Rails.logger.info("preview_niconico_getthumbinfo_fallback #{ { url: uri.to_s,
-                                                                     video_id:,
-                                                                     error: e.class.name,
-                                                                     message: e.message }.to_json }")
+      payload = {
+          url: uri.to_s,
+          video_id:,
+          error: e.class.name,
+          message: e.message }
+      Rails.logger.info("preview_niconico_getthumbinfo_fallback #{ payload.to_json }")
       nil
     end