AI: address review on PR #457

frontend/src/components/PostEditForm.tsx

@@ -153,21 +153,6 @@ const PostEditForm: FC<Props> = ({ post, onSave }) => {
     setDisabled (true)
     try
     {
-      const titleMissing = !title?.trim ()
-      const thumbnailMissing =
-	  !titleMissing
-	  && !(post.thumbnail?.trim () || post.thumbnailBase?.trim ())
-
-      if ((titleMissing || thumbnailMissing)
-	  && !(await dialogue.confirm ({
-	      title: titleMissing
-		  ? label ('edit.titleMissingConfirmation')
-		  : label ('edit.thumbnailMissingConfirmation'),
-	      confirmText: label ('shared:actions.update'),
-	      cancelText: label ('shared:actions.cancel'),
-	      closeLabel: label ('settings:actions.close') })))
-	return
-
       await update ({ id: post.id, title, tags, parentPostIds,
 		      duration: videoFlg ? duration : null,
 		      originalCreatedFrom, originalCreatedBefore },

frontend/src/components/TagDetailSidebar.test.tsx

@@ -39,6 +39,18 @@ describe ('TagDetailSidebar', () => {
     vi.clearAllMocks ()
   })
 
+  it ('inherits the sidebar width saved by the post list', () => {
+    localStorage.setItem ('sidebar:posts-index-tags:left:width', '320')
+
+    const { container } = renderWithProviders (
+	<TagDetailSidebar post={buildPost ()}/>)
+    const sidebar = container.querySelector<HTMLElement> (
+	'[style*="--sidebar-width"]')
+
+    expect (sidebar).toBeInTheDocument ()
+    expect (sidebar?.style.getPropertyValue ('--sidebar-width')).toBe ('320px')
+  })
+
   it ('keeps internal and external tags with the same numeric id in flat mode', () => {
     setClientTagRelationDisplayMode ('flat')
 

frontend/src/components/TagDetailSidebar.tsx

@@ -378,7 +378,7 @@ const TagDetailSidebar: FC<Props> = ({ className, post, sp }) => {
   }, [baseTags])
 
   return (
-      <SidebarComponent sidebarKey="post-detail-tags" className={className}>
+      <SidebarComponent sidebarKey="posts-index-tags" className={className}>
 	<TagSearch/>
 	<DndContext
 	    sensors={sensors}

frontend/src/components/layout/SidebarComponent.test.tsx

@@ -70,16 +70,6 @@ describe ('SidebarComponent', () => {
     vi.spyOn (HTMLElement.prototype, 'hasPointerCapture').mockReturnValue (true)
   })
 
-  it ('limits sidebar scrolling to desktop to avoid clipping mobile suggestions', () => {
-    renderSidebar ()
-
-    // jsdom has no layout; guard the responsive classes responsible for clipping.
-    const sidebar = screen.getByText ('Sidebar body')
-
-    expect (sidebar).not.toHaveClass ('overflow-y-auto')
-    expect (sidebar).toHaveClass ('md:overflow-y-auto')
-  })
-
   it ('uses maxWidth without applying the container main-width reserve twice', async () => {
     localStorage.setItem ('sidebar:test-sidebar:left:width', '700')
     const onWidthChange = vi.fn ()

frontend/src/components/layout/SidebarComponent.tsx

@@ -339,7 +339,7 @@ const SidebarComponent: FC<Props> = ({
 	  </style>
 	</Helmet>
 
-	<div className="h-full md:overflow-y-auto p-4 sidebar">
+	<div className="h-full overflow-y-auto p-4 sidebar">
 	  {children}
 	</div>
 

frontend/src/locales/ain-Kana/posts.json

@@ -1,5 +1,4 @@
 {
-  "_untranslated": ["edit.titleMissingConfirmation", "edit.thumbnailMissingConfirmation"],
   "list": {
     "tagline": "{{brand}}",
     "empty": "ミンタㇻ　タ　ネン　カ　イサㇺ",
@@ -32,8 +31,6 @@
     "showExternal": "ソイタㇰ　ソㇱ　アヌカレ"
   },
   "edit": {
-    "titleMissingConfirmation": "タイトルが設定されてゐません．更新しますか?",
-    "thumbnailMissingConfirmation": "サムネールが設定されてゐません．更新しますか?",
     "validationFailed": "アシㇼ　カㇻ　カ　エアイカㇷ゚……",
     "conflictTitle": "モㇱマ　クㇽ　アシㇼ　カㇻ　ワ　アン！",
     "conflictDescription": "モㇱマ　イカㇻ　クㇽ　エエトコ　アシㇼ　カㇻ　ワ　アン。",

frontend/src/locales/ja/posts.json

@@ -22,8 +22,6 @@
     "question": "表示しますか?", "showExternal": "外部ページを表示"
   },
   "edit": {
-    "titleMissingConfirmation": "タイトルが設定されてゐません．更新しますか?",
-    "thumbnailMissingConfirmation": "サムネールが設定されてゐません．更新しますか?",
     "validationFailed": "更新はできなかったよ……",
     "conflictTitle": "競合が発生しました．",
     "conflictDescription": "ほかの耕作員が先に更新してゐます．",

frontend/src/pages/tags/TagDetailPage.test.tsx

@@ -35,10 +35,6 @@ const renderPage = () =>
 describe ('TagDetailPage', () => {
   beforeEach (() => {
     vi.clearAllMocks ()
-    tagsApi.fetchTag.mockReset ()
-    api.apiPut.mockReset ()
-    api.isApiError.mockReset ()
-    toastApi.toast.mockReset ()
     api.isApiError.mockReturnValue (false)
   })
 
@@ -55,11 +51,8 @@ describe ('TagDetailPage', () => {
   })
 
   it ('submits edited tag fields', async () => {
-    const updatedTag = buildTag ({ id: 7, name: 'new', aliases: ['alias'] })
+    tagsApi.fetchTag.mockResolvedValueOnce (buildTag ({ id: 7, name: 'old' }))
-    tagsApi.fetchTag
+    api.apiPut.mockResolvedValueOnce (buildTag ({ id: 7, name: 'new', aliases: ['alias'] }))
-	.mockResolvedValue (updatedTag)
-	.mockResolvedValueOnce (buildTag ({ id: 7, name: 'old' }))
-    api.apiPut.mockResolvedValueOnce (updatedTag)
 
     renderPage ()