AI: address review on PR #460

frontend/server.ssr.test.mjs

@@ -2,6 +2,7 @@ import assert from 'node:assert/strict'
 import { createServer } from 'node:http'
 import { spawn } from 'node:child_process'
 import { after, before, test } from 'node:test'
+import { JSDOM } from 'jsdom'
 import { createServer as createViteServer } from 'vite'
 
 import { render } from './dist/server/entry-server.js'
@@ -402,6 +403,26 @@ test ('every canonical screen route returns page HTML without JavaScript', async
   }
 })
 
+test ('SSR HTML head includes reciprocal hreflang links with query parameters', async () => {
+  for (const locale of ['ja', 'ain-Kana']) {
+    const response = await fetch (`${httpOrigin}/${locale}/posts?page=2&limit=50`)
+    assert.equal (response.status, 200)
+    const dom = new JSDOM (await response.text ())
+    try
+    {
+      const links = [...dom.window.document.head.querySelectorAll ('link[rel="alternate"]')]
+      assert.deepEqual (links.map (link => ({
+        locale: link.getAttribute ('hreflang'), href: link.getAttribute ('href') })), [
+        { locale: 'ja', href: `${origin}/ja/posts?page=2&limit=50` },
+        { locale: 'ain-Kana', href: `${origin}/ain-Kana/posts?page=2&limit=50` }])
+    }
+    finally
+    {
+      dom.window.close ()
+    }
+  }
+})
+
 test ('YouTube posts return HTTP 200 with the embed rendered by SSR', async t => {
   for (const locale of ['ja', 'ain-Kana']) {
     await t.test (locale, async () => {

frontend/src/components/TagDetailSidebar.test.tsx

@@ -39,18 +39,6 @@ describe ('TagDetailSidebar', () => {
     vi.clearAllMocks ()
   })
 
-  it ('inherits the sidebar width saved by the post list', () => {
-    localStorage.setItem ('sidebar:posts-index-tags:left:width', '320')
-
-    const { container } = renderWithProviders (
-	<TagDetailSidebar post={buildPost ()}/>)
-    const sidebar = container.querySelector<HTMLElement> (
-	'[style*="--sidebar-width"]')
-
-    expect (sidebar).toBeInTheDocument ()
-    expect (sidebar?.style.getPropertyValue ('--sidebar-width')).toBe ('320px')
-  })
-
   it ('keeps internal and external tags with the same numeric id in flat mode', () => {
     setClientTagRelationDisplayMode ('flat')
 

frontend/src/components/TagDetailSidebar.tsx

@@ -378,7 +378,7 @@ const TagDetailSidebar: FC<Props> = ({ className, post, sp }) => {
   }, [baseTags])
 
   return (
-      <SidebarComponent sidebarKey="posts-index-tags" className={className}>
+      <SidebarComponent sidebarKey="post-detail-tags" className={className}>
 	<TagSearch/>
 	<DndContext
 	    sensors={sensors}

frontend/src/entry-server.tsx

@@ -1,6 +1,6 @@
 import { QueryClient, QueryClientProvider, dehydrate, skipToken } from '@tanstack/react-query'
 import { PassThrough } from 'node:stream'
-import { renderToPipeableStream } from 'react-dom/server'
+import { renderToPipeableStream, renderToStaticMarkup } from 'react-dom/server'
 import { HelmetProvider } from 'react-helmet-async'
 import { I18nextProvider } from 'react-i18next'
 import { createStaticHandler, createStaticRouter,
@@ -9,7 +9,7 @@ import { createStaticHandler, createStaticRouter,
 import { AppFrame, appRoutes, resolvePageRoute } from '@/App'
 import { apiGet, isApiError } from '@/lib/api'
 import { createUII18n } from '@/lib/i18n'
-import { fetchLocales, isLocaleCode, legacyLocalePath } from '@/lib/locales'
+import { fetchLocales, isLocaleCode, legacyLocalePath, switchLocalePath } from '@/lib/locales'
 import { localesKeys, sessionKeys } from '@/lib/queryKeys'
 import { withRenderContext } from '@/lib/renderContext.server'
 
@@ -171,8 +171,26 @@ export const render = async (
 	}))
       }
       const helmet = helmetContext.helmet!
+      const alternates = status === 200 && known != null
+	  ? await Promise.all (locales.locales.map (entry => entry.code)
+	      .filter (isLocaleCode)
+	      .filter (code => known.route.handle?.locale == null
+		  || known.route.handle.locale === code)
+	      .map (async targetLocale => {
+		const location = { pathname: url.pathname, search: url.search, hash: '' }
+		const path = targetLocale === locale
+		    ? url.pathname + url.search
+		    : (known.route.handle?.switchLocale != null
+		       ? await known.route.handle.switchLocale ({
+			   location, params: known.params, locale, targetLocale })
+		       : switchLocalePath (location, targetLocale))
+		return <link key={targetLocale} rel="alternate" hrefLang={targetLocale}
+		    href={new URL (path, origin).href}/>
+	      }))
+	  : []
       const head = [helmet.title, helmet.meta, helmet.link, helmet.style]
 	  .map (entry => entry.toString ()).join ('')
+	  + renderToStaticMarkup (<>{alternates}</>)
       const dehydrated = dehydrate (client, { shouldDehydrateQuery: query =>
 	  query.state.status !== 'pending'
 	  && query.meta?.clientOnly !== true