From 63dcc9b266c76f3a45f40cb617240022386cdb1b Mon Sep 17 00:00:00 2001
From: miteruzo <miteruzo@naver.com>
Date: Mon, 20 Apr 2026 12:47:34 +0900
Subject: [PATCH 1/2] #323

---
 backend/app/controllers/users_controller.rb | 31 ++++++++++++++++-----
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/backend/app/controllers/users_controller.rb b/backend/app/controllers/users_controller.rb
index 4d8e57e..3f2727f 100644
--- a/backend/app/controllers/users_controller.rb
+++ b/backend/app/controllers/users_controller.rb
@@ -1,18 +1,26 @@
 class UsersController < ApplicationController
   def create
-    user = User.create!(inheritance_code: SecureRandom.uuid, role: 'guest')
+    return head :unprocessable_entity if request.remote_ip.blank?
+
+    user = nil
+
+    User.transaction do
+      user = User.create!(inheritance_code: SecureRandom.uuid, role: :guest)
+      attach_ip_address!(user)
+    end
+
     render json: { code: user.inheritance_code,
-                   user: user.slice(:id, :name, :inheritance_code, :role) }
+                   user: user.slice(:id, :name, :inheritance_code, :role) },
+           status: :created
   end
 
   def verify
-    ip_bin = IPAddr.new(request.remote_ip).hton
-    ip_address = IpAddress.find_or_create_by!(ip_address: ip_bin)
-
     user = User.find_by(inheritance_code: params[:code])
     return render json: { valid: false } unless user
 
-    UserIp.find_or_create_by!(user:, ip_address:)
+    return head :unprocessable_entity if request.remote_ip.blank?
+
+    attach_ip_address!(user)
 
     render json: { valid: true, user: user.slice(:id, :name, :inheritance_code, :role) }
   end
@@ -41,9 +49,18 @@ class UsersController < ApplicationController
     return head :bad_request if name.blank?
 
     if user.update(name:)
-      render json: user.slice(:id, :name, :inheritance_code, :role), status: :created
+      render json: user.slice(:id, :name, :inheritance_code, :role), status: :ok
     else
       render json: user.errors, status: :unprocessable_entity
     end
   end
+
+  private
+
+  def attach_ip_address! user
+    ip_bin = IPAddr.new(request.remote_ip).hton
+    ip_address = IpAddress.find_or_create_by!(ip_address: ip_bin)
+
+    UserIp.create_or_find_by!(user:, ip_address:)
+  end
 end
-- 
2.34.1


From 2cfe9fdc557fa20a93d93d21205243a8d7fe347a Mon Sep 17 00:00:00 2001
From: miteruzo <miteruzo@naver.com>
Date: Mon, 20 Apr 2026 23:31:33 +0900
Subject: [PATCH 2/2] #323

---
 backend/app/controllers/users_controller.rb | 2 +-
 backend/spec/requests/users_spec.rb         | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/backend/app/controllers/users_controller.rb b/backend/app/controllers/users_controller.rb
index 3f2727f..64aa43c 100644
--- a/backend/app/controllers/users_controller.rb
+++ b/backend/app/controllers/users_controller.rb
@@ -59,7 +59,7 @@ class UsersController < ApplicationController
 
   def attach_ip_address! user
     ip_bin = IPAddr.new(request.remote_ip).hton
-    ip_address = IpAddress.find_or_create_by!(ip_address: ip_bin)
+    ip_address = IpAddress.create_or_find_by!(ip_address: ip_bin)
 
     UserIp.create_or_find_by!(user:, ip_address:)
   end
diff --git a/backend/spec/requests/users_spec.rb b/backend/spec/requests/users_spec.rb
index 89003a4..1f28e95 100644
--- a/backend/spec/requests/users_spec.rb
+++ b/backend/spec/requests/users_spec.rb
@@ -1,11 +1,10 @@
 require "rails_helper"
 
-
 RSpec.describe "Users", type: :request do
   describe "POST /users" do
     it "creates guest user and returns code" do
       post "/users"
-      expect(response).to have_http_status(:ok)
+      expect(response).to have_http_status(:created)
       expect(json["code"]).to be_present
       expect(json["user"]["role"]).to eq("guest")
     end
@@ -38,7 +37,7 @@ RSpec.describe "Users", type: :request do
       sign_in_as(user)
       put "/users/#{user.id}", params: { name: "new-name" }
 
-      expect(response).to have_http_status(:created)
+      expect(response).to have_http_status(:ok)
       expect(json["id"]).to eq(user.id)
       expect(json["name"]).to eq("new-name")
 
-- 
2.34.1