このコミットが含まれているのは:
@@ -1,8 +1,15 @@
|
||||
require 'rails_helper'
|
||||
|
||||
RSpec.describe Language, type: :model do
|
||||
it 'accepts supported language codes' do
|
||||
expect(described_class.new(code: 'en', name: 'English')).to be_valid
|
||||
it 'accepts Nipponese as the current supported language' do
|
||||
expect(described_class.find('ja')).to be_valid
|
||||
expect(described_class.where(deprecated_at: nil).pluck(:code)).to eq(['ja'])
|
||||
end
|
||||
|
||||
it 'accepts English when multilingual support is enabled' do
|
||||
pending '日本語以外の Language 有効化は別課題で実装する'
|
||||
expect { described_class.create!(code: 'en', name: 'English') }
|
||||
.to change(described_class, :count).by(1)
|
||||
end
|
||||
|
||||
it 'rejects an unsupported language code' do
|
||||
@@ -13,11 +20,13 @@ RSpec.describe Language, type: :model do
|
||||
}
|
||||
end
|
||||
|
||||
it 'does not treat French as a supported language' do
|
||||
expect {
|
||||
described_class.create!(code: 'fr', name: 'French')
|
||||
}.to raise_error { |error|
|
||||
expect(error).to be_a(ArgumentError).or be_a(ActiveRecord::RecordInvalid)
|
||||
}
|
||||
['en', 'fr'].each do |code|
|
||||
it "does not register #{ code } as a currently supported language" do
|
||||
expect {
|
||||
described_class.create!(code:, name: 'Unsupported')
|
||||
}.to raise_error { |error|
|
||||
expect(error).to be_a(ArgumentError).or be_a(ActiveRecord::RecordInvalid)
|
||||
}
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
@@ -1,18 +1,33 @@
|
||||
require 'rails_helper'
|
||||
|
||||
RSpec.describe Locale, type: :model do
|
||||
def prepare_english_reference!
|
||||
Language.find_or_create_by!(code: 'en') { _1.name = 'English' }
|
||||
Script.find_or_create_by!(code: 'Latn') { _1.name = 'Latin' }
|
||||
end
|
||||
include_context 'English locale'
|
||||
|
||||
def create_english_locale!
|
||||
prepare_english_reference!
|
||||
described_class.create!(code: 'en', language_code: 'en',
|
||||
script_code: 'Latn', name: 'English')
|
||||
script_code: 'Latn', region_code: 826,
|
||||
variants: '', name: 'English')
|
||||
end
|
||||
|
||||
it 'keeps the active Nipponese locale consistent with its identity tuple' do
|
||||
expect(described_class.where(deprecated_at: nil).pluck(:code)).to eq(['ja'])
|
||||
expect(described_class.nipponese).to have_attributes(
|
||||
code: 'ja', language_code: 'ja', script_code: 'Jpan',
|
||||
region_code: 392, variants: '')
|
||||
end
|
||||
|
||||
it 'rejects a duplicate locale identity tuple at the database boundary' do
|
||||
expect {
|
||||
described_class.insert_all!([{ code: 'ja-duplicate', language_code: 'ja',
|
||||
script_code: 'Jpan', region_code: 392,
|
||||
variants: '', name: '日本語',
|
||||
created_at: Time.current }])
|
||||
}.to raise_error(ActiveRecord::RecordNotUnique)
|
||||
end
|
||||
|
||||
it 'generates a primary name for every existing tag using the name generator' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
first = create(:tag, primary_name: 'first_existing_tag')
|
||||
second = create(:tag, primary_name: 'second_existing_tag')
|
||||
allow(TagName).to receive(:generate_name).and_call_original
|
||||
@@ -39,6 +54,7 @@ RSpec.describe Locale, type: :model do
|
||||
end
|
||||
|
||||
it 'does not duplicate an existing primary name in the new language' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
prepare_english_reference!
|
||||
tag = create(:tag, primary_name: 'already_named')
|
||||
existing = create(:tag_name, name: 'existing_english', tag:,
|
||||
@@ -54,6 +70,7 @@ RSpec.describe Locale, type: :model do
|
||||
end
|
||||
|
||||
it 'creates a primary name when the language has only an alias' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
prepare_english_reference!
|
||||
tag = create(:tag, primary_name: 'alias_only_tag')
|
||||
alias_name = create(:tag_name, :alias, name: 'alias_en',
|
||||
@@ -73,6 +90,7 @@ RSpec.describe Locale, type: :model do
|
||||
end
|
||||
|
||||
it 'rolls back the locale and all generated names when backfill fails' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
prepare_english_reference!
|
||||
first = create(:tag, primary_name: 'atomic_first')
|
||||
second = create(:tag, primary_name: 'atomic_second')
|
||||
@@ -88,12 +106,24 @@ RSpec.describe Locale, type: :model do
|
||||
end
|
||||
|
||||
it 'accepts a stable locale code outside the historical enum values' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
prepare_english_reference!
|
||||
|
||||
locale = described_class.create!(
|
||||
code: 'en-x-rspec', language_code: 'en',
|
||||
script_code: 'Latn', name: 'English')
|
||||
script_code: 'Latn', region_code: 826,
|
||||
variants: 'x-rspec', name: 'English')
|
||||
|
||||
expect(locale.reload).to have_attributes(code: 'en-x-rspec', language_code: 'en')
|
||||
expect(locale.reload).to have_attributes(
|
||||
code: 'en-x-rspec', language_code: 'en', script_code: 'Latn',
|
||||
region_code: 826, variants: 'x-rspec')
|
||||
end
|
||||
|
||||
it 'registers the future British English locale tuple' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
|
||||
expect(locale).to have_attributes(code: 'en', language_code: 'en',
|
||||
script_code: 'Latn', region_code: 826,
|
||||
variants: '')
|
||||
end
|
||||
end
|
||||
|
||||
@@ -4,17 +4,32 @@ RSpec.describe Script, type: :model do
|
||||
include_context 'English locale'
|
||||
|
||||
it 'selects locales by script code, not language code' do
|
||||
expect(described_class.find('Latn').locales).to include(locale)
|
||||
expect(described_class.find('Jpan').locales).to include(Locale.nipponese)
|
||||
expect(described_class.find('Jpan').locales).not_to include(locale)
|
||||
expect(described_class.find('Jpan').locales).to contain_exactly(Locale.nipponese)
|
||||
end
|
||||
|
||||
it 'accepts supported script codes and rejects unsupported ones' do
|
||||
expect(described_class.new(code: 'Latn', name: 'Latin')).to be_valid
|
||||
expect(described_class.find('Jpan')).to be_valid
|
||||
expect(described_class.where(deprecated_at: nil).pluck(:code)).to eq(['Jpan'])
|
||||
expect {
|
||||
described_class.create!(code: 'Zzzz', name: 'Unsupported')
|
||||
}.to raise_error { |error|
|
||||
expect(error).to be_a(ArgumentError).or be_a(ActiveRecord::RecordInvalid)
|
||||
}
|
||||
end
|
||||
|
||||
it 'does not register Latin as a currently supported script' do
|
||||
expect {
|
||||
described_class.create!(code: 'Latn', name: 'Latin')
|
||||
}.to raise_error { |error|
|
||||
expect(error).to be_a(ArgumentError).or be_a(ActiveRecord::RecordInvalid)
|
||||
}
|
||||
end
|
||||
|
||||
it 'selects Latin locales when multilingual support is enabled' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
|
||||
expect(described_class.find('Latn').locales).to contain_exactly(locale)
|
||||
expect(described_class.find('Jpan').locales).not_to include(locale)
|
||||
end
|
||||
end
|
||||
|
||||
@@ -38,6 +38,8 @@ RSpec.describe TagNameSanitisationRule, type: :model do
|
||||
include_context 'English locale'
|
||||
|
||||
it 'keeps both names when sanitisation produces a cross-language match' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
nipponese = create(:tag_name, name: 'foobar')
|
||||
english = create(:tag_name, name: 'temporary',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
@@ -50,6 +52,8 @@ RSpec.describe TagNameSanitisationRule, type: :model do
|
||||
end
|
||||
|
||||
it 'renames without merging tags or deleting either language identity' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
nipponese = create(:tag, primary_name: 'foobar')
|
||||
english_name = create(:tag_name, name: 'temporary',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
|
||||
@@ -4,6 +4,8 @@ RSpec.describe TagName, type: :model do
|
||||
include_context 'English locale'
|
||||
|
||||
it 'allows the same name in different languages' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
create(:tag_name, name: 'shared_name')
|
||||
english = build(:tag_name, name: 'shared_name',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
@@ -24,7 +26,15 @@ RSpec.describe TagName, type: :model do
|
||||
name = create(:tag_name)
|
||||
|
||||
expect(name.reload).to have_attributes(
|
||||
language_code: 'ja', script_code: 'Jpan', primary_flg: true, tag_id: nil)
|
||||
language_code: 'ja', script_code: 'Jpan', primary_flg: true,
|
||||
auto_generated: false, tag_id: nil)
|
||||
end
|
||||
|
||||
it 'defaults ordinary persisted human names to confirmed provenance' do
|
||||
name = described_class.create!(name: 'ordinary_human_name', language_code: 'ja',
|
||||
script_code: 'Jpan', primary_flg: true)
|
||||
|
||||
expect(name.reload.auto_generated).to be(false)
|
||||
end
|
||||
|
||||
it 'persists both sides of the representative tag factory association' do
|
||||
@@ -39,7 +49,7 @@ RSpec.describe TagName, type: :model do
|
||||
expect(tag.reload.tag_name_id).to eq(name.id)
|
||||
end
|
||||
|
||||
it 'creates a complete ordinary tag factory under every active language' do
|
||||
it 'creates a complete ordinary tag factory under the active Nipponese language' do
|
||||
tag = create(:tag, primary_name: 'factory_multilingual')
|
||||
|
||||
Locale.where(deprecated_at: nil).distinct.pluck(:language_code).each do |language_code|
|
||||
@@ -47,6 +57,13 @@ RSpec.describe TagName, type: :model do
|
||||
end
|
||||
expect(TagName.where(tag:, language_code: 'ja', primary_flg: true))
|
||||
.to contain_exactly(have_attributes(auto_generated: false))
|
||||
end
|
||||
|
||||
it 'completes an ordinary tag factory under future active languages' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
tag = create(:tag, primary_name: 'future_factory')
|
||||
|
||||
expect(TagName.where(tag:, language_code: 'en', primary_flg: true))
|
||||
.to contain_exactly(have_attributes(auto_generated: true))
|
||||
end
|
||||
@@ -95,6 +112,8 @@ RSpec.describe TagName, type: :model do
|
||||
end
|
||||
|
||||
it 'resolves the primary name of the alias language on the same tag' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
tag = create(:tag, primary_name: '日本語正本')
|
||||
english_primary = primary_tag_name_for(tag, 'en')
|
||||
english_primary.update!(name: 'english_primary', auto_generated: false)
|
||||
@@ -113,6 +132,8 @@ RSpec.describe TagName, type: :model do
|
||||
end
|
||||
|
||||
it 'resolves only aliases in the requested language' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
nipponese = create(:tag, primary_name: 'nipponese_canonical')
|
||||
english_name = create(:tag_name, name: 'english_canonical',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
|
||||
@@ -25,17 +25,18 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
describe '.normalise_tags!' do
|
||||
include_context 'English locale'
|
||||
|
||||
it 'canonicalises aliases in the supplied language only' do
|
||||
Language.find_or_create_by!(code: 'en') { _1.name = 'English' }
|
||||
Script.find_or_create_by!(code: 'Latn') { _1.name = 'Latin' }
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
prepare_english_reference!
|
||||
nipponese = create(:tag, primary_name: 'nipponese_canonical')
|
||||
english_name = create(:tag_name, name: 'english_canonical',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
english = create(:tag, primary_tag_name: english_name)
|
||||
primary_tag_name_for(english, 'ja').update!(
|
||||
name: 'english_in_nipponese', auto_generated: false)
|
||||
english_locale = Locale.create!(
|
||||
code: 'en', language_code: 'en', script_code: 'Latn', name: 'English')
|
||||
english_locale = locale
|
||||
nipponese_alias = create(:tag_name, :alias, name: 'shared_alias',
|
||||
tag: nipponese)
|
||||
english_alias = create(:tag_name, :alias, name: 'shared_alias',
|
||||
@@ -219,6 +220,8 @@ RSpec.describe Tag, type: :model do
|
||||
include_context 'English locale'
|
||||
|
||||
it 'creates the representative name with locale attributes and ownership' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
tag = described_class.find_or_create_by_tag_name!(
|
||||
locale, 'english_name', category: :character)
|
||||
|
||||
@@ -229,6 +232,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'uses the English primary as the source for a generated Nipponese name' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
allow(TagName).to receive(:generate_name).and_return('generated_nipponese')
|
||||
|
||||
tag = described_class.find_or_create_by_tag_name!(
|
||||
@@ -246,6 +251,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'gives a new tag one primary name for every active language' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
tag = described_class.find_or_create_by_tag_name!(
|
||||
Locale.nipponese, 'new_multilingual_tag', category: :general)
|
||||
|
||||
@@ -254,10 +261,13 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'creates one primary per language when multiple locales use English' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
described_class.find_or_create_by_tag_name!(
|
||||
locale, 'before_second_english_locale', category: :general)
|
||||
Locale.create!(code: 'en-x-rspec', language_code: 'en',
|
||||
script_code: 'Latn', name: 'English')
|
||||
script_code: 'Latn', region_code: 826,
|
||||
variants: 'x-rspec', name: 'English')
|
||||
|
||||
tag = described_class.find_or_create_by_tag_name!(
|
||||
locale, 'one_english_primary', category: :general)
|
||||
@@ -267,6 +277,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'rolls back a new tag and requested name if name generation fails' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
original_tag_count = described_class.count
|
||||
allow(TagName).to receive(:generate_name).and_raise('generation failed')
|
||||
|
||||
@@ -282,6 +294,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'keeps a detached requested name detached if generation fails' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
detached = create(:tag_name, :alias, name: 'atomic_detached',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
original_tag_count = described_class.count
|
||||
@@ -297,6 +311,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'promotes a detached alias into the requested primary name' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
detached = create(:tag_name, :alias, name: 'detached_english',
|
||||
language_code: 'en', script_code: 'Latn')
|
||||
|
||||
@@ -311,6 +327,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'creates separate tag identities for the same name in different languages' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
nipponese = described_class.find_or_create_by_tag_name!(
|
||||
Locale.nipponese, 'same_name', category: :general)
|
||||
english = described_class.find_or_create_by_tag_name!(
|
||||
@@ -328,6 +346,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'preserves the V1 representative when looking up another primary language' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
tag = create(:tag, primary_name: '日本語代表名')
|
||||
representative_id = tag.tag_name_id
|
||||
english = primary_tag_name_for(tag, 'en')
|
||||
@@ -342,6 +362,8 @@ RSpec.describe Tag, type: :model do
|
||||
end
|
||||
|
||||
it 'normalises names using the supplied locale' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
tags = described_class.normalise_tags!(
|
||||
locale, ['character:normalised_english'],
|
||||
with_tagme: false, with_no_deerjikist: false)
|
||||
@@ -363,6 +385,21 @@ RSpec.describe Tag, type: :model do
|
||||
|
||||
expect(primary_tag_name_for(tag, 'ja').name).to eq('lookup_new')
|
||||
expect(tag.category).to eq('character')
|
||||
expect(TagName.where(tag:, language_code: 'ja', primary_flg: true).count).to eq(1)
|
||||
expect(primary_tag_name_for(tag, 'ja').auto_generated).to be(false)
|
||||
end
|
||||
|
||||
it 'promotes a detached Nipponese alias into a human-confirmed primary' do
|
||||
detached = create(:tag_name, :alias, name: 'detached_nipponese')
|
||||
|
||||
tag = described_class.find_or_create_by_tag_name!(
|
||||
Locale.nipponese, detached.name, category: :general)
|
||||
|
||||
expect(detached.reload).to have_attributes(
|
||||
tag_id: tag.id, primary_flg: true, canonical_id: nil,
|
||||
auto_generated: false)
|
||||
expect(TagName.where(tag:, language_code: 'ja', primary_flg: true))
|
||||
.to contain_exactly(detached)
|
||||
end
|
||||
|
||||
it 'reuses the owning tag for an alias without changing its category' do
|
||||
@@ -417,6 +454,8 @@ RSpec.describe Tag, type: :model do
|
||||
include_context 'English locale'
|
||||
|
||||
it 'keeps the target primary and moves source names as aliases' do
|
||||
pending '日本語以外の Locale 有効化は別課題で実装する'
|
||||
locale
|
||||
english_primary = primary_tag_name_for(target_tag, 'en')
|
||||
source_primary = primary_tag_name_for(source_tag, 'en')
|
||||
source_alias = create(:tag_name, :alias, tag: source_tag,
|
||||
@@ -497,18 +536,15 @@ RSpec.describe Tag, type: :model do
|
||||
.to eq([[1, 'create'], [2, 'discard']])
|
||||
expect(versions.first).to eq(original_version)
|
||||
expect(versions.last.created_by_user).to eq(user)
|
||||
expect(versions.last.names).to include(
|
||||
hash_including('language_code' => 'ja', 'name' => source_name,
|
||||
'primary_flg' => true, 'auto_generated' => false),
|
||||
hash_including('language_code' => 'ja', 'name' => source_alias.name,
|
||||
'primary_flg' => false, 'auto_generated' => false))
|
||||
expect(versions.last.names.fetch('ja')).to eq(
|
||||
'name' => source_name, 'script_code' => 'Jpan',
|
||||
'auto_generated' => false,
|
||||
'aliases' => [{ 'name' => source_alias.name, 'script_code' => 'Jpan' }])
|
||||
expect(Tag.unscoped.exists?(source_tag.id)).to be(false)
|
||||
|
||||
target_versions = target_tag.tag_versions.order(:version_no)
|
||||
expect(target_versions.pluck(:event_type)).to eq(['create', 'update'])
|
||||
target_aliases = target_versions.last.names.filter_map { |name|
|
||||
name['name'] if name['language_code'] == 'ja' && !name['primary_flg']
|
||||
}
|
||||
target_aliases = target_versions.last.names.fetch('ja').fetch('aliases').pluck('name')
|
||||
expect(target_aliases).to contain_exactly('merge_alias', source_name)
|
||||
end
|
||||
|
||||
|
||||
@@ -12,12 +12,11 @@ RSpec.describe VersionRecord, type: :model do
|
||||
name: primary_tag_name_for(tag, 'ja').name,
|
||||
category: tag.category,
|
||||
aliases: '',
|
||||
names: [{ language_code: 'ja', name: primary_tag_name_for(tag, 'ja').name,
|
||||
script_code: 'Jpan', primary_flg: true }],
|
||||
names: { ja: { name: primary_tag_name_for(tag, 'ja').name,
|
||||
script_code: 'Jpan', auto_generated: false, aliases: [] } },
|
||||
parent_tag_ids: '',
|
||||
created_at: Time.current,
|
||||
created_by_user: nil
|
||||
)
|
||||
created_by_user: nil)
|
||||
|
||||
expect {
|
||||
version.update!(name: 'changed')
|
||||
@@ -32,12 +31,11 @@ RSpec.describe VersionRecord, type: :model do
|
||||
name: primary_tag_name_for(tag, 'ja').name,
|
||||
category: tag.category,
|
||||
aliases: '',
|
||||
names: [{ language_code: 'ja', name: primary_tag_name_for(tag, 'ja').name,
|
||||
script_code: 'Jpan', primary_flg: true }],
|
||||
names: { ja: { name: primary_tag_name_for(tag, 'ja').name,
|
||||
script_code: 'Jpan', auto_generated: false, aliases: [] } },
|
||||
parent_tag_ids: '',
|
||||
created_at: Time.current,
|
||||
created_by_user: nil
|
||||
)
|
||||
created_by_user: nil)
|
||||
|
||||
expect {
|
||||
version.destroy!
|
||||
|
||||
新しいイシューから参照
ユーザーをブロックする