コミットを比較

..
1 コミット
作成者 SHA1 メッセージ 日付
Codex Night Worker d6fc57a00e AI: address issue #479 2026-11-16 00:18:56 +09:00
14個のファイルの変更、30行の追加、222行の削除
+1 -1
ファイルの表示
@@ -424,7 +424,7 @@ races according to the target constraint's business meaning.
and JSON keys are generally snake_case.
- Preserve existing HTTP status conventions:
`:unauthorized` for no user, `:forbidden` for insufficient role or banned
user, `:not_found` for missing records, and `:unprocessable_entity` for
user, `:not_found` for missing records, and `:unprocessable_content` for
validation failures.
- For diagnostic or internal helper JSON, prefer a deliberately light response
shape over full representation classes when callers only need identifiers,
+1 -1
ファイルの表示
@@ -95,7 +95,7 @@ class ApplicationController < ActionController::API
render_validation_error base: ['すでに存在してゐます.']
end
def render_validation_error record = nil, fields: { }, base: [], status: :unprocessable_entity
def render_validation_error record = nil, fields: { }, base: [], status: :unprocessable_content
errors = { }
if record
+3 -3
ファイルの表示
@@ -18,7 +18,7 @@ class CountsExportsController < ApplicationController
render json: { error: 'private_condition' }, status: :forbidden
rescue CountsTableQuery::TooManyColumns
render json: { error: 'too_many_columns', max_columns: CountsTableQuery::MAX_COLUMNS },
status: :unprocessable_entity
status: :unprocessable_content
rescue ActiveRecord::StatementTimeout
render json: { error: 'counts_query_timeout' }, status: :service_unavailable
rescue ArgumentError, TypeError, KeyError, JSON::ParserError
@@ -63,7 +63,7 @@ class CountsExportsController < ApplicationController
render json: { error: 'private_condition' }, status: :forbidden
rescue CountsTableQuery::TooManyColumns
render json: { error: 'too_many_columns', max_columns: CountsTableQuery::MAX_COLUMNS },
status: :unprocessable_entity
status: :unprocessable_content
rescue ActiveRecord::StatementTimeout
render json: { error: 'counts_query_timeout' }, status: :service_unavailable
rescue ArgumentError, TypeError, KeyError, JSON::ParserError
@@ -107,7 +107,7 @@ class CountsExportsController < ApplicationController
render json: { error: 'private_condition' }, status: :forbidden
rescue CountsTableQuery::TooManyColumns
render json: { error: 'too_many_columns', max_columns: CountsTableQuery::MAX_COLUMNS },
status: :unprocessable_entity
status: :unprocessable_content
rescue ActiveRecord::StatementTimeout
render json: { error: 'counts_query_timeout' }, status: :service_unavailable
rescue ArgumentError, TypeError, KeyError, JSON::ParserError
+1 -1
ファイルの表示
@@ -24,7 +24,7 @@ class CountsTablesController < ApplicationController
render json: { error: 'private_condition' }, status: :forbidden
rescue CountsTableQuery::TooManyColumns
render json: { error: 'too_many_columns', max_columns: CountsTableQuery::MAX_COLUMNS },
status: :unprocessable_entity
status: :unprocessable_content
rescue CountsPivotTotals::TimedOut
Rails.logger.warn('counts_query_timeout: pivot_totals')
render json: { error: 'counts_query_timeout', stage: 'totals',
+2 -2
ファイルの表示
@@ -15,7 +15,7 @@ class GekanatorGamesController < ApplicationController
answers:)
if game.invalid?
render json: { errors: game.errors.full_messages }, status: :unprocessable_entity
render json: { errors: game.errors.full_messages }, status: :unprocessable_content
return
end
@@ -31,7 +31,7 @@ class GekanatorGamesController < ApplicationController
learned_example_count:
}, status: :created
rescue ActiveRecord::RecordInvalid => e
render json: { errors: e.record.errors.full_messages }, status: :unprocessable_entity
render json: { errors: e.record.errors.full_messages }, status: :unprocessable_content
end
def extra_questions
+1 -1
ファイルの表示
@@ -536,7 +536,7 @@ class MaterialsController < ApplicationController
errors: { },
base_errors: ['ZIP export に必要な素材ファイルが欠損しています.'],
missing_files: },
status: :unprocessable_entity
status: :unprocessable_content
end
def build_uploaded_material_blob! file, file_sha256
+6 -6
ファイルの表示
@@ -29,14 +29,14 @@ class PostVersionsController < ApplicationController
count = q.except(:select, :order, :limit, :offset).count
# Apply visibility and pagination before joining the previous snapshots.
page_scope = q.order(Arel.sql('post_versions.created_at DESC, post_versions.id DESC'))
.limit(limit).offset(offset).select('post_versions.*')
versions = version_scope.from(page_scope, :post_versions)
ids = q.order(Arel.sql('post_versions.created_at DESC, post_versions.id DESC'))
.limit(limit)
.offset(offset)
.pluck('post_versions.id')
versions = version_scope.merge(q).where(id: ids)
.order(Arel.sql('post_versions.created_at DESC, post_versions.id DESC'))
render json: { versions: serialise_versions(versions, locale.language_code),
count:, population_count: HistoryAccess.population_count(PostVersion) }
render json: { versions: serialise_versions(versions, locale.language_code), count:, population_count: HistoryAccess.population_count(PostVersion) }
end
private
+2 -2
ファイルの表示
@@ -429,7 +429,7 @@ class PostsController < ApplicationController
filters = literals.map do |literal|
internal, = source_ids.fetch(literal[:name])
name = internal.empty? ? literal[:name] : names[internal.first]
return head :unprocessable_entity unless name && internal.length <= 1
return head :unprocessable_content unless name && internal.length <= 1
literal[:negative] ? "not:#{ name }" : name
end
@@ -438,7 +438,7 @@ class PostsController < ApplicationController
literals.zip(translated).each do |literal, translation|
unless (source_ids.fetch(literal[:name]).map(&:sort) ==
target_ids.fetch(translation[:name]).map(&:sort))
return head :unprocessable_entity
return head :unprocessable_content
end
end
index = 0
+2 -2
ファイルの表示
@@ -55,7 +55,7 @@ class TheatresController < ApplicationController
theatre = Theatre.find_by(id: params[:id])
return head :not_found unless theatre
requested_post_id = params[:post_id].to_i
return head :unprocessable_entity if requested_post_id <= 0
return head :unprocessable_content if requested_post_id <= 0
skipped = false
conflicted = false
@@ -95,7 +95,7 @@ class TheatresController < ApplicationController
theatre = Theatre.find_by(id: params[:id])
return head :not_found unless theatre
requested_post_id = params[:post_id].to_i
return head :unprocessable_entity if requested_post_id <= 0
return head :unprocessable_content if requested_post_id <= 0
conflicted = false
+6 -5
ファイルの表示
@@ -41,9 +41,10 @@ class HistoryAccess < ActiveSupport::CurrentAttributes
table = model.table_name
keys = KEYS.fetch(table)
matches = keys.map { "boundary.#{ _1 } = #{ row }.#{ _1 }" }.join(' AND ')
# Any discard at or after this version hides it, including after a restore.
clauses = ["NOT EXISTS (SELECT 1 FROM #{ table } boundary WHERE #{ matches } " +
"AND boundary.version_no >= #{ row }.version_no AND boundary.event_type = 'discard')"]
boundaries = "SELECT #{ keys.join(', ') }, MAX(version_no) AS version_no FROM #{ table } " +
"WHERE event_type = 'discard' GROUP BY #{ keys.join(', ') }"
clauses = ["NOT EXISTS (SELECT 1 FROM (#{ boundaries }) boundary WHERE #{ matches } " +
"AND boundary.version_no >= #{ row }.version_no)"]
clauses += reference_sql(table, row) if references
clauses.map { "(#{ _1 })" }.join(' AND ')
end
@@ -61,8 +62,8 @@ class HistoryAccess < ActiveSupport::CurrentAttributes
# A scalar lookup avoids MySQL's semijoin rewrite losing the JSON row correlation.
"(SELECT 1 FROM JSON_TABLE(COALESCE(#{ document }, JSON_ARRAY()), " +
"'$[*]' COLUMNS (reference_id BIGINT PATH '$' NULL ON EMPTY)) reference_entry " +
"JOIN #{ table } blocked ON reference_entry.reference_id = blocked.#{ key } " +
"WHERE blocked.event_type = 'discard' LIMIT 1) IS NULL"
"JOIN (#{ discarded_keys(table, key) }) blocked " +
"ON reference_entry.reference_id = blocked.#{ key } LIMIT 1) IS NULL"
end
def self.list_reference(table, key, document)
+2 -2
ファイルの表示
@@ -20,7 +20,7 @@ RSpec.describe 'error responses', type: :request do
patch "/tags/#{ tag.id }", params: { category: 'nico' }
expect(response).to have_http_status(:unprocessable_entity)
expect(response).to have_http_status(:unprocessable_content)
expect(json).to include(
'type' => 'validation_error',
'message' => '入力内容を確認してください.',
@@ -37,7 +37,7 @@ RSpec.describe 'error responses', type: :request do
put "/users/#{ user.id }", params: { name: 'a' * 256 }
expect(response).to have_http_status(:unprocessable_entity)
expect(response).to have_http_status(:unprocessable_content)
expect(json).to include(
'type' => 'validation_error',
'message' => '入力内容を確認してください.')
+1 -157
ファイルの表示
@@ -33,9 +33,6 @@ RSpec.describe 'Post history privacy', type: :request do
end
PostVersion.create!(post: post_record, version_no: index + 1, event_type: event,
title: "version #{ index + 1 }", url: post_record.url, tags: '',
thumbnail_base: "history-#{ index + 1 }", video_ms: (index + 1) * 1000,
original_created_from: origin - 1.year + index.days,
original_created_before: origin - 1.year + (index + 1).days,
tags_json: snapshots, parent_post_ids: '', created_at: origin + (index + 1).days)
end
end
@@ -66,7 +63,7 @@ RSpec.describe 'Post history privacy', type: :request do
expect(response.parsed_body.fetch('versions').first.fetch('title').fetch('prev')).to be_nil
end
['anonymous', 'guest', 'member', 'admin'].each do |role|
['anonymous', 'member', 'admin'].each do |role|
context "as #{ role }" do
before do
sign_in_as(create(:user, role.to_sym)) unless role == 'anonymous'
@@ -118,15 +115,6 @@ RSpec.describe 'Post history privacy', type: :request do
expect(body.fetch('versions').pluck('version_no')).to eq(expected)
restored = body.fetch('versions').find { _1.fetch('version_no') == 3 }
expect(restored.fetch('title').fetch('prev')).to eq(role == 'admin' ? 'version 2' : nil)
unless role == 'admin'
fields = [
'url', 'thumbnail_base', 'video_ms',
'original_created_from', 'original_created_before']
fields.each do |field|
expect(restored.fetch(field).fetch('prev')).to be_nil
end
expect(restored.fetch('tags')).to eq([])
end
end
it 'uses only an authorised previous version for tag filtering' do
@@ -136,150 +124,6 @@ RSpec.describe 'Post history privacy', type: :request do
expect(response.parsed_body.fetch('versions').pluck('version_no')).to eq(expected)
expect(response.parsed_body.fetch('count')).to eq(expected.length)
end
it 'returns an empty history with an exact count' do
get '/posts/versions', params: { post: other_post.id }
expect(response).to have_http_status(:ok)
expect(response.parsed_body).to include('versions' => [], 'count' => 0,
'population_count' => 4)
end
it 'keeps counts and timestamp ties consistent across history pages' do
rows = 25.times.map do |index|
PostVersion.create!(post: post_record, version_no: index + 5, event_type: 'update',
title: 'page snapshot', url: post_record.url, tags: '', tags_json: [],
parent_post_ids: '', created_at: origin + 5.days)
end
rows << PostVersion.create!(post: other_post, version_no: 1, event_type: 'create',
title: 'another post', url: other_post.url, tags: '', tags_json: [],
parent_post_ids: '', created_at: origin + 5.days)
earlier = role == 'admin' ? [4, 3, 2, 1] : [3]
expected = rows.reverse.map { [_1.post_id, _1.version_no] } +
earlier.map { [post_record.id, _1] }
expected.each_slice(7).with_index do |page_rows, index|
get '/posts/versions', params: { page: index + 1, limit: 7 }
expect(response).to have_http_status(:ok)
body = response.parsed_body
expect(body.fetch('count')).to eq(expected.length)
expect(body.fetch('population_count')).to eq(30)
expect(body.fetch('versions').map { [_1.fetch('post_id'), _1.fetch('version_no')] })
.to eq(page_rows)
end
get '/posts/versions', params: { page: 10, limit: 7 }
expect(response).to have_http_status(:ok)
expect(response.parsed_body).to include('versions' => [], 'count' => expected.length)
end
it 'loads the page and its authorised diff in one data query' do
statements = []
listener = lambda do |_name, _start, _finish, _id, payload|
next if ['SCHEMA', 'TRANSACTION'].include?(payload[:name])
statements << payload[:sql] if payload[:sql].match?(/\ASELECT/i)
end
ActiveSupport::Notifications.subscribed(listener, 'sql.active_record') do
get '/posts/versions', params: { post: post_record.id, limit: 1 }
end
expect(response).to have_http_status(:ok)
history_queries = statements.select { _1.include?('post_versions') }
counts, details = history_queries.partition { _1.match?(/\ASELECT COUNT\(/i) }
expect(counts.length).to eq(2)
expect(counts.join(' ')).not_to include('LEFT JOIN post_versions prev')
expect(details.length).to eq(1)
end
it 'hides references to a discarded parent even after its restore' do
['discard', 'restore'].each_with_index do |event, index|
PostVersion.create!(post: other_post, version_no: index + 1, event_type: event,
title: 'parent snapshot', url: other_post.url, tags: '', tags_json: [],
parent_post_ids: '', created_at: origin + index.hours)
end
[other_post.id.to_s, ''].each_with_index do |parents, index|
PostVersion.create!(post: post_record, version_no: index + 5, event_type: 'update',
title: 'parent reference', url: post_record.url, tags: '', tags_json: [],
parent_post_ids: parents, created_at: origin + (index + 5).days)
end
get '/posts/versions', params: { post: post_record.id }
expect(response).to have_http_status(:ok)
body = response.parsed_body
expected = role == 'admin' ? [6, 5, 4, 3, 2, 1] : [6, 3]
expect(body.fetch('versions').pluck('version_no')).to eq(expected)
expect(body.fetch('count')).to eq(expected.length)
previous = body.fetch('versions').first.fetch('title').fetch('prev')
expect(previous).to eq(role == 'admin' ? 'parent reference' : nil)
end
it 'keeps restored tag references private' do
TagVersion.create!(tag:, version_no: 3, event_type: 'restore',
name: 'private-history-tag', category: 'general', aliases: '', parent_tag_ids: '',
names: { ja: { name: 'private-history-tag', script_code: 'Jpan',
auto_generated: false, aliases: [] } },
created_at: origin + 2.hours)
PostVersion.create!(post: post_record, version_no: 5, event_type: 'update',
title: 'restored tag reference', url: post_record.url, tags: '',
tags_json: [{ tag_id: tag.id, version_no: 3, sections: [] }],
parent_post_ids: '', created_at: origin + 5.days)
get '/posts/versions', params: { post: post_record.id }
expect(response).to have_http_status(:ok)
expected = role == 'admin' ? [5, 4, 3, 2, 1] : [3]
expect(response.parsed_body.fetch('versions').pluck('version_no')).to eq(expected)
expect(response.parsed_body.fetch('count')).to eq(expected.length)
end
it 'uses the external linkage recorded at the post snapshot time' do
NicoTagVersion.create!(external_tag: external, version_no: 2, event_type: 'update',
linked_tag_ids: '', created_at: origin + 5.days)
PostVersion.create!(post: post_record, version_no: 5, event_type: 'update',
title: 'public external reference', url: post_record.url, tags: '',
tags_json: [{ external_tag_id: external.id }], parent_post_ids: '',
created_at: origin + 6.days)
get '/posts/versions', params: { post: post_record.id, external_tag: external.id }
expect(response).to have_http_status(:ok)
body = response.parsed_body
expected = role == 'admin' ? [5, 4] : [5]
expect(body.fetch('versions').pluck('version_no')).to eq(expected)
expect(body.fetch('count')).to eq(expected.length)
latest = body.fetch('versions').first
previous = latest.fetch('title').fetch('prev')
expect(previous).to eq(role == 'admin' ? 'version 4' : nil)
expect(latest.fetch('tags')).to contain_exactly(a_hash_including(
'name' => 'nico:external-history-tag',
'type' => role == 'admin' ? 'context' : 'added'))
end
it 'hides references to historical external discard events after restore' do
public_external = create(:external_tag)
# Discard/restore events can remain in history despite current event validation.
snapshots = ['create', 'discard', 'restore'].each_with_index.map do |event, index|
{ tag_id: public_external.id, version_no: index + 1, event_type: event,
linked_tag_ids: '', created_at: origin + index.days }
end
NicoTagVersion.insert_all!(snapshots)
[5, 6].each do |number|
PostVersion.create!(post: post_record, version_no: number, event_type: 'update',
title: 'external discard reference', url: post_record.url, tags: '',
tags_json: [{ external_tag_id: public_external.id }], parent_post_ids: '',
created_at: origin + number.days)
end
get '/posts/versions', params: { post: post_record.id, external_tag: public_external.id }
expect(response).to have_http_status(:ok)
expected = role == 'admin' ? [6, 5] : []
expect(response.parsed_body.fetch('versions').pluck('version_no')).to eq(expected)
expect(response.parsed_body.fetch('count')).to eq(expected.length)
end
end
end
end
-37
ファイルの表示
@@ -2,7 +2,6 @@ import { QueryClient } from '@tanstack/react-query'
import { beforeEach, describe, expect, it, vi } from 'vitest'
import { prefetchForURL } from '@/lib/prefetchers'
import { postsKeys } from '@/lib/queryKeys'
const postsApi = vi.hoisted (() => ({
fetchPost: vi.fn (),
@@ -89,42 +88,6 @@ describe ('prefetchForURL', () => {
expect (postsApi.fetchPost).toHaveBeenCalledWith ('12', 'ja')
})
it.each (['/posts/changes', '/ja/posts/changes']) (
'prefetches post history with matching filters and cache key at %s', async path => {
const client = qc ()
const params = { post: '12', page: 2, limit: 5 }
const history = { versions: [], count: 7 }
postsApi.fetchPostChanges.mockResolvedValueOnce (history)
await prefetchForURL (client, `${path}?id=12&page=2&limit=5`)
expect (postsApi.fetchPostChanges).toHaveBeenCalledExactlyOnceWith (params, 'ja')
expect (client.getQueryData (postsKeys.changes (params, 'ja'))).toEqual (history)
expect (client.getQueryCache ().getAll ()).toHaveLength (1)
})
it ('preserves a tag filter when prefetching one post history', async () => {
const client = qc ()
const params = { post: '12', tag: '7', page: 1, limit: 20 }
await prefetchForURL (client, '/ja/posts/changes?id=12&tag=7')
expect (postsApi.fetchPostChanges).toHaveBeenCalledExactlyOnceWith (params, 'ja')
expect (client.getQueryData (postsKeys.changes (params, 'ja')))
.toEqual ({ versions: [], count: 0 })
})
it ('prefetches unfiltered post history with its own cache key', async () => {
const client = qc ()
const params = { page: 2, limit: 5 }
await prefetchForURL (client, '/ja/posts/changes?page=2&limit=5')
expect (postsApi.fetchPostChanges).toHaveBeenCalledExactlyOnceWith (params, 'ja')
expect (client.getQueryData (postsKeys.changes (params, 'ja')))
.toEqual ({ versions: [], count: 0 })
})
it ('prefetches tag indexes from query parameters', async () => {
await prefetchForURL (
qc (),
+2 -2
ファイルの表示
@@ -214,11 +214,11 @@ const prefetchPostChanges: Prefetcher = async (qc, url, locale) => {
}
await qc.prefetchQuery ({
queryKey: postsKeys.changes ({ ...(id && { post: id }),
queryKey: postsKeys.changes ({ ...(id && { id }),
...(tag && { tag }),
...(externalTag && { externalTag }),
page, limit }, locale),
queryFn: () => fetchPostChanges ({ ...(id && { post: id }),
queryFn: () => fetchPostChanges ({ ...(id && { id }),
...(tag && { tag }),
...(externalTag && { externalTag }),
page, limit }, locale) })